Makefile+github: add make fmt-check to check for formatting

This commit is contained in:
yyforyongyu 2022-08-23 03:22:51 +08:00
parent 0735522194
commit 859c5e5da4
No known key found for this signature in database
GPG Key ID: 9BCD95C4FF296868
3 changed files with 26 additions and 1 deletions

View File

@ -32,6 +32,24 @@ env:
GO_VERSION: 1.18.2
jobs:
########################
# format code
########################
fmt-check:
name: check code format
runs-on: ubuntu-latest
steps:
- name: git checkout
uses: actions/checkout@v3
- name: setup go ${{ env.GO_VERSION }}
uses: actions/setup-go@v3
with:
go-version: '${{ env.GO_VERSION }}'
- name: fmt
run: make fmt-check
########################
# RPC and mobile compilation check
########################

View File

@ -258,6 +258,10 @@ fmt: $(GOIMPORTS_BIN)
@$(call print, "Formatting source.")
gofmt -l -w -s $(GOFILES_NOVENDOR)
fmt-check: fmt
@$(call print, "Checking fmt results.")
if test -n "$$(git status --porcelain)"; then echo "code not formatted correctly, please run `make fmt` again!"; git status; git diff; exit 1; fi
lint: docker-tools
@$(call print, "Linting source.")
$(DOCKER_TOOLS) golangci-lint run -v $(LINT_WORKERS)

View File

@ -45,6 +45,9 @@ transaction](https://github.com/lightningnetwork/lnd/pull/6730).
* [The `golangci-lint` tool was updated to
`v1.46.2`](https://github.com/lightningnetwork/lnd/pull/6731)
* Updated the github actions to use `make fmt-check` in its [build
process](https://github.com/lightningnetwork/lnd/pull/6853).
# Contributors (Alphabetical Order)
* Carla Kirk-Cohen
@ -55,4 +58,4 @@ transaction](https://github.com/lightningnetwork/lnd/pull/6730).
* hieblmi
* Olaoluwa Osuntokun
* Oliver Gugger
* Priyansh Rastogi
* Priyansh Rastogi