build: update to Go 1.18

.github/workflows/main.yml

@@ -24,7 +24,7 @@ env:
   # /dev.Dockerfile
   # /make/builder.Dockerfile
   # /.github/workflows/release.yml
-  GO_VERSION: 1.17.3
+  GO_VERSION: 1.18
 
 jobs:
   ########################

.github/workflows/release.yaml

@@ -16,7 +16,7 @@ env:
   # /dev.Dockerfile
   # /make/builder.Dockerfile
   # /.github/workflows/main.yml
-  GO_VERSION: 1.17.3
+  GO_VERSION: 1.18
 
 jobs:
   main:

.travis.yml

@@ -21,7 +21,7 @@ go:
   # /make/builder.Dockerfile
   # /.github/workflows/main.yml
   # /.github/workflows/release.yml
-  - "1.17.x"
+  - "1.18.x"
 
 env:
   global:

Dockerfile

@@ -4,7 +4,7 @@
 # /make/builder.Dockerfile
 # /.github/workflows/main.yml
 # /.github/workflows/release.yml
-FROM golang:1.17.3-alpine as builder
+FROM golang:1.18-alpine as builder
 
 # Force Go to use the cgo based DNS resolver. This is required to ensure DNS
 # queries required to connect to linked containers succeed.

chainntnfs/bitcoindnotify/bitcoind_test.go

@@ -175,7 +175,7 @@ func TestHistoricalConfDetailsTxIndex(t *testing.T) {
 	switch txStatus {
 	case chainntnfs.TxFoundMempool:
 	default:
-		t.Fatal("should have found the transaction within the "+
+		t.Fatalf("should have found the transaction within the "+
 			"mempool, but did not: %v", txStatus)
 	}
 

discovery/gossiper_test.go

@@ -2009,7 +2009,7 @@ func TestDeDuplicatedAnnouncements(t *testing.T) {
 	// indexes as due to the randomized order of map iteration they may be
 	// in either place.
 	if !reflect.DeepEqual(batch[2].msg, na) && !reflect.DeepEqual(batch[3].msg, na) {
-		t.Fatal("first node announcement not in last part of batch: "+
+		t.Fatalf("first node announcement not in last part of batch: "+
 			"got %v, expected %v", batch[2].msg,
 			na)
 	}

discovery/syncer_test.go

@@ -2125,7 +2125,7 @@ func TestGossipSyncerSyncTransitions(t *testing.T) {
 		select {
 		case msgs := <-msgChan:
 			if len(msgs) != 1 {
-				t.Fatal("expected to send a single message at "+
+				t.Fatalf("expected to send a single message at "+
 					"a time, got %d", len(msgs))
 			}
 			msgSent = msgs[0]

htlcswitch/circuit_test.go

@@ -490,7 +490,7 @@ func TestCircuitMapPersistence(t *testing.T) {
 	// Removing already-removed circuit should return an error.
 	err = circuitMap.DeleteCircuits(circuit1.Incoming)
 	if err != nil {
-		t.Fatal("Unexpected failure when deleting already "+
+		t.Fatalf("Unexpected failure when deleting already "+
 			"deleted circuit: %v", err)
 	}
 

lnrpc/routerrpc/router_backend_test.go

@@ -203,7 +203,7 @@ func testQueryRoutes(t *testing.T, useMissionControl bool, useMsat bool,
 			route.Vertex, error) {
 
 			if chanID != 555 {
-				t.Fatal("expected endpoints to be fetched for "+
+				t.Fatalf("expected endpoints to be fetched for "+
 					"channel 555, but got %v instead",
 					chanID)
 			}

make/builder.Dockerfile

@@ -4,7 +4,7 @@
 # /dev.Dockerfile
 # /.github/workflows/main.yml
 # /.github/workflows/release.yml
-FROM golang:1.17.3-buster
+FROM golang:1.18-buster
 
 MAINTAINER Olaoluwa Osuntokun <laolu@lightning.engineering>