Commit Graph

13879 Commits

Author SHA1 Message Date
Oliver Gugger
5bd3e91750 rpcwallet: pass prev output fetcher into ComputeInputScript
This commit fixes signing of Taproot inputs when some of the other
inputs of the transaction are not known to the wallet (such as a Pool
account for example).
If we want to sign for a Taproot (change) input when depositing into a
Pool account the wallet won't know the Pool account input. So we need to
make sure we pass it along inside the PrevOutputFetcher (which contains
the UTXO information extracted from the PSBT).
2022-11-11 10:20:09 +01:00
Oliver Gugger
ed2e542515 rpcwallet: don't re-use sign desc in loop
This commit fixes an issue with signing for mixed inputs in a remote
signing setup where the re-use of the sign descriptor would lead to the
sign method not being reset correctly if a p2wkh input is following a
p2tr input.
2022-11-11 10:20:09 +01:00
Oliver Gugger
b3f6fe315e itest: add test coverage for Taproot tweak key mutation 2022-11-11 10:20:09 +01:00
Oliver Gugger
082d68d0ca mod: bump btcwallet to version with addr validation
This commit bumps the btcwallet dependency to the version that includes
the address validation that asserts we can sign for an address before we
use it.
2022-11-11 10:20:08 +01:00
Oliver Gugger
e3536dd770 mod+keychain+lntest: bump btcd to version with tweak fix
This commit bumps to the latest version of btcd that fixes a key
mutation issue when signing for Taproot outputs.
2022-11-11 10:20:08 +01:00
Olaoluwa Osuntokun
bcdf24b15e Merge pull request #7126 from yyforyongyu/temp-fix-itest
itest+funding: decrease sleep time and add a temporary fix for itest
2022-11-10 16:53:44 -08:00
yyforyongyu
22ae772b3f docs: replace release docs re checking FundingLocked interval 2022-11-10 13:59:17 +08:00
yyforyongyu
b7816489a1 itest: add temp fix to bring back btcd build 2022-11-10 13:59:17 +08:00
yyforyongyu
4b558c3af5 funding: decrease checking interval to be 10ms in itest
When waiting for the peer to send us FundingLocked, we check whether
we've received this message periodically. This commit changes the
checking interval from 1s to 10ms in itest, which allows us to still
stop the CPU spike while responding to the message quickly.
2022-11-10 13:59:14 +08:00
Oliver Gugger
22fec76339 Merge pull request #7114 from ellemouton/useCorrectBaseBranchOnPush
github: only check commits on PR events
2022-11-04 10:27:23 +01:00
Elle Mouton
5499ce36fa github+docs: only check commits on PR action 2022-11-04 11:07:19 +02:00
Oliver Gugger
ae6006a84e Merge pull request #7095 from yyforyongyu/funding-locked
funding: wait for one sec if funding locked is not received
2022-11-02 09:27:41 +01:00
Oliver Gugger
421c9c660c Merge pull request #7103 from ellemouton/checkAgainstBaseBranch
github: check commits against base branch
2022-11-02 09:22:13 +01:00
Oliver Gugger
926fdf486c Merge pull request #6573 from voltagecloud/tls-reloader
cert: add TLS reloader
cert/v1.2.0
2022-11-02 09:10:15 +01:00
Elle Mouton
5ea99578a8 github: check commits against base branch 2022-11-02 09:08:21 +02:00
Orbital
a647c87972 docs: update release notes 2022-11-01 16:44:23 -05:00
Orbital
2f35b9aa7f cert: add TLS reloader and return bytes from GenCert
Co-authored-by: gkrizek <graham@krizek.io>
2022-11-01 16:44:18 -05:00
yyforyongyu
8761a9a056 funding: wait for one sec if funding locked is not received 2022-11-02 02:02:49 +08:00
Oliver Gugger
31a803c931 Merge pull request #7100 from guggero/btcd-dep-update
mod+docs: bump btcd version to v0.23.3 on master branch
2022-11-01 17:32:50 +01:00
Oliver Gugger
b0673d06ea docs: add release notes for 0.16.0-beta 2022-11-01 16:40:56 +01:00
Oliver Gugger
3013e939dd docs: add release notes for 0.15.4-beta 2022-11-01 16:39:19 +01:00
Oliver Gugger
1628424c33 mod: bump btcd to v0.23.3 2022-11-01 16:38:36 +01:00
Oliver Gugger
84401f6f6c Merge pull request #7039 from TonyGiorgio/sync-7034
Remove ErrSynchronizingChain
2022-10-31 08:35:48 +01:00
Oliver Gugger
b9d40a5123 Merge pull request #7070 from habibitcoin/master
doc: remove ⛰  emoji from commands
2022-10-28 19:35:51 +02:00
habibitcoin
04a1160939 docs: remove $ from multiline commands or frequently copied [skip ci] 2022-10-28 12:32:24 -05:00
habibitcoin
0b1e881d18 scripted-diff: replace ⛰ emoji with $ [skip ci]
-BEGIN VERIFY SCRIPT-
sed -i 's/⛰/$/g' $(git grep -l '⛰')
-END VERIFY SCRIPT-
2022-10-28 12:06:49 -04:00
Tony Giorgio
09537596fc funding+lnwire: remove ErrSynchronizingChain 2022-10-28 10:06:59 -05:00
Oliver Gugger
e7f4b183ae Merge pull request #7090 from Kodylow/fix-adming-typo
fixes adming typo
2022-10-28 11:20:31 +02:00
Kody Low
c89dd86a2e fix typo 2022-10-27 16:26:47 -07:00
Oliver Gugger
81b17ef4fd Merge pull request #6517 from bottlepay/lookup-htlc
htlcswitch: final settle signal
2022-10-27 17:52:37 +02:00
Joost Jager
3a89a84744 rpcserver: add LookupHtlc call 2022-10-27 16:43:09 +02:00
Joost Jager
511fb00777 htlcswitch: add final htlc event to notifier 2022-10-27 16:42:36 +02:00
Joost Jager
28256b7ea8 htlcswitch: keep final htlc outcome 2022-10-27 16:42:36 +02:00
Joost Jager
b85cda2a1d routerrpc: add htlc notifier subscribed event 2022-10-27 16:42:35 +02:00
Oliver Gugger
281cdd4209 Merge pull request #7083 from hieblmi/fwdinghistory-alias-opt-in
rpcserver: opting-in to peer alias lookup in `ForwardingHistory`
2022-10-27 14:04:52 +02:00
Slyghtning
f8ef283589 docs: update release notes 2022-10-27 07:11:20 -04:00
Slyghtning
8e53996c52 itest: test ForwardingHistory peer lookup opt-in behavior 2022-10-27 07:11:20 -04:00
Slyghtning
46b8de35ac lnrpc+lncli: rename skip_peer_alias_lookup to reflect opt-in behavior 2022-10-27 07:11:19 -04:00
Oliver Gugger
55d62f8bab Merge pull request #6776 from yyforyongyu/2-new-itest
itest: continued itest refactor and fix - I
2022-10-26 21:59:42 +02:00
eugene
64b608bce0 routing: check pubkey when applying channel update 2022-10-27 03:09:02 +08:00
yyforyongyu
14f45d0722 lntemp+lntest: fix make lint 2022-10-27 01:11:35 +08:00
yyforyongyu
0d29f154db docs: update release notes for itest refactor 2022-10-27 01:11:35 +08:00
yyforyongyu
5ed37166ef contractcourt: return htlcResolution when currentHeight has reached expiry
Only create the sweep tx when the height has reached, otherwise we will
get a broadcast error. Previously it wasn't caught by itest due to the
blocks were mined very fast, so the lock time was always reached.
2022-10-27 01:11:35 +08:00
yyforyongyu
2285bfdf9f contractcourt+brontide: fix typo and inaccurate logging 2022-10-27 01:11:35 +08:00
yyforyongyu
42eab93ba0 lntemp+lntest: use t.Cleanup to register cleanup functions 2022-10-27 01:11:34 +08:00
yyforyongyu
ab62109865 lntemp+lntest: always wait for nodes sync after mining blocks
In this commit, we introduce two mining methods, `MineBlocks` and
`MineBlocksAndAssertNumTxes`, to `HarnessTest`. These methods are
different from the miner's methods as they would 1) mine the blocks
slowly and 2) assert all active nodes have synced. The miner's methods
are kept for future tests such as mining blocks really fast and see the
behavior of `lnd`.
2022-10-27 01:11:34 +08:00
yyforyongyu
f202d27324 itest: break testChannelBackupRestore into smaller tests
This commit breaks the large `testChannelBackupRestore` into smaller
tests to take advantage of our parallel testing framework. A smaller
test also makes the debugging easier, hence better code health.
2022-10-27 01:11:34 +08:00
yyforyongyu
78de9dae05 itest: break testMultiHopHtlcClaims into smaller test cases
This commit breaks the large `testMultiHopHtlcClaims` into independent
test cases to take the advantage of parallel testing. The old setup will
put the stress of creating and syncing new blocks into a single core,
which causes a much longer test time and sometimes times out.
2022-10-27 01:11:34 +08:00
yyforyongyu
3f14ee5870 itest: fix testMultiHopHtlcRemoteChainClaim and linters
This commit makes sure the test `testMultiHopHtlcRemoteChainClaim` takes
account of the one block mined while closing the channel.
2022-10-27 01:11:34 +08:00
yyforyongyu
47279fb9af itest: fix testMultiHopHtlcLocalChainClaim 2022-10-27 01:11:34 +08:00