highperfocused/multica
1
0
Fork 0
mirror of https://github.com/multica-ai/multica.git synced 2026-07-05 13:29:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(runtimes): prefer Local machine as default selection (MUL-2359) (#2792)

Browse Source 
On desktop, localDaemonId is fetched async, so on first paint the only
machines available are remotes — the existing auto-select picks the
first remote, then sticks because subsequent renders see selectedMachineId
still in the list. Result: the local Mac never gets the default focus
even though it sorts first.

Re-evaluate the default on every machines change, preferring the local
section. Honor a user pick once it's been made.

Co-authored-by: multica-agent <github@multica.ai>
This commit is contained in:
Bohan Jiang
2026-05-18 16:29:02 +08:00
committed by GitHub
parent ceb967aefa
commit 1796ef6dff
1 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
packages/views/runtimes/components/runtimes-page.tsx
View File

@@ -1,6 +1,6 @@
"use client";
import React, { useCallback, useEffect, useMemo, useState } from "react";
import React, { useCallback, useEffect, useMemo, useRef, useState } from "react";
import { useDefaultLayout } from "react-resizable-panels";
import {
Cloud,
@@ -85,6 +85,14 @@ export function RuntimesPage({
const [selectedMachineId, setSelectedMachineId] = useState<string | null>(
null,
);
// Tracks whether the user has explicitly picked a machine. Until then,
// auto-default keeps preferring the Local section (which on desktop may
// appear later than remotes — `localDaemonId` is fetched async).
const userSelectedRef = useRef(false);
const handleSelectMachine = useCallback((id: string) => {
userSelectedRef.current = true;
setSelectedMachineId(id);
}, []);
const [showConnectDialog, setShowConnectDialog] = useState(false);
const { defaultLayout, onLayoutChanged } = useDefaultLayout({
id: "multica_runtimes_layout",
@@ -133,9 +141,16 @@ export function RuntimesPage({
if (selectedMachineId !== null) setSelectedMachineId(null);
return;
}
if (!selectedMachineId || !filteredMachines.some((m) => m.id === selectedMachineId)) {
setSelectedMachineId(filteredMachines[0]?.id ?? null);
}
const stillValid =
!!selectedMachineId &&
filteredMachines.some((m) => m.id === selectedMachineId);
// Honor an explicit user pick. Otherwise re-evaluate the default so the
// Local machine wins as soon as it shows up, even if a remote was the
// first-paint default.
if (userSelectedRef.current && stillValid) return;
const local = filteredMachines.find((m) => m.section === "local");
const nextId = local?.id ?? filteredMachines[0]?.id ?? null;
if (nextId !== selectedMachineId) setSelectedMachineId(nextId);
}, [filteredMachines, selectedMachineId]);
const selectedMachine =
@@ -170,7 +185,7 @@ export function RuntimesPage({
setSearch={setMachineSearch}
filter={machineFilter}
setFilter={setMachineFilter}
onSelect={setSelectedMachineId}
onSelect={handleSelectMachine}
/>
<MachineDetail
machine={selectedMachine}
@@ -206,7 +221,7 @@ export function RuntimesPage({
setSearch={setMachineSearch}
filter={machineFilter}
setFilter={setMachineFilter}
onSelect={setSelectedMachineId}
onSelect={handleSelectMachine}
className="h-full border-b-0 border-r"
/>
</ResizablePanel>