highperfocused/multica
1
0
Fork 0
mirror of https://github.com/multica-ai/multica.git synced 2026-07-05 13:29:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(handler): fix timeline test assertions for handler-package isolation

Browse Source 
The TestListTimeline_* assertions assumed CreateIssue would seed an
"issue_created" activity_log row, but the activity listener that publishes
those rows is registered in cmd/server/main.go — handler-package tests
don't wire it up. CI saw 5 entries (3 comments + 2 activities) where the
test expected ≥6.

Drop the auto-activity assumption: assert exactly 5 entries in
TestListTimeline_MergesCommentsAndActivities, and tighten
TestListTimeline_EmptyIssue to assert a fully-empty timeline.

Co-authored-by: multica-agent <github@multica.ai>
This commit is contained in:
Jiang Bohan
2026-05-09 16:02:05 +08:00
parent 08c7bf6fae
commit ccaa7dc6cf
1 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
server/internal/handler/activity_test.go
View File

@@ -93,10 +93,9 @@ func TestListTimeline_ReturnsAllEntriesAscending(t *testing.T) {
if status != http.StatusOK {
t.Fatalf("status = %d, want 200", status)
}
// Issue creation seeds an "issue created" activity, so we expect
// (1 issue-created activity) + 5 seeded comments. The seeded comments
// are timestamped strictly after the auto-activity, so the comment
// order alone is what we assert.
// Handler tests don't register the activity listener (that lives in
// cmd/server), so issue creation does not seed an auto-activity here.
// We assert directly on the seeded comments.
commentEntries := []TimelineEntry{}
for _, e := range entries {
if e.Type == "comment" {
@@ -128,9 +127,10 @@ func TestListTimeline_MergesCommentsAndActivities(t *testing.T) {
i, entries[i-1].CreatedAt, entries[i].CreatedAt)
}
}
// At least: 1 auto issue-created activity + 3 comments + 2 activities = 6.
if len(entries) < 6 {
t.Fatalf("entries = %d, want at least 6", len(entries))
// 3 seeded comments + 2 seeded activities = 5. Handler tests don't
// register the activity listener, so there is no auto issue-created row.
if got, want := len(entries), 5; got != want {
t.Fatalf("entries = %d, want %d", got, want)
}
}
@@ -213,10 +213,9 @@ func TestListTimeline_EmptyIssue(t *testing.T) {
if status != http.StatusOK {
t.Fatalf("status = %d, want 200", status)
}
// Issue creation seeds one "issue created" activity; no comments.
for _, e := range entries {
if e.Type == "comment" {
t.Errorf("unexpected comment entry: %+v", e)
}
// Handler tests don't wire the activity listener, so a freshly-created
// issue with no comments has an empty timeline.
if got := len(entries); got != 0 {
t.Fatalf("entries = %d, want 0", got)
}
}