highperfocused/multica
1
0
Fork 0
mirror of https://github.com/multica-ai/multica.git synced 2026-07-13 05:16:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(projects): show URL tooltip on already-attached repos in Add Resource list

Browse Source 
The repo button in the Add Resource popover used the native `disabled`
attribute when a repo was already attached. Browsers suppress pointer
events on disabled form controls, so the tooltip on the URL text never
fired for attached rows — the issue spec calls out "hovering over any
URL should also show the complete URL in a tooltip".

Switch to `aria-disabled` plus a click guard so the row still announces
as disabled to assistive tech, looks the same visually, and is no
longer click-able, but hover still reaches the tooltip trigger.

Co-authored-by: multica-agent <github@multica.ai>
This commit is contained in:
Jiang Bohan
2026-05-06 11:53:08 +08:00
parent 64c605e227
commit e1be458788
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/views/projects/components/project-resources-section.tsx
View File

@@ -118,16 +118,21 @@ export function ProjectResourcesSection({ projectId }: { projectId: string }) {
<div className="space-y-1">
{workspace.repos.map((repo) => {
const isAttached = attachedUrls.has(repo.url);
const isDisabled = isAttached || createResource.isPending;
return (
// Use aria-disabled instead of the native `disabled` attribute so
// hover events still reach the tooltip trigger on attached rows
// (browsers suppress pointer events on disabled form controls).
<button
key={repo.url}
type="button"
disabled={isAttached || createResource.isPending}
aria-disabled={isDisabled}
onClick={async () => {
if (isDisabled) return;
await handleAttach(repo.url);
setAddOpen(false);
}}
className="flex w-full items-center gap-2 rounded-md px-2 py-1.5 text-xs text-left hover:bg-accent transition-colors disabled:opacity-50 disabled:cursor-not-allowed"
className="flex w-full items-center gap-2 rounded-md px-2 py-1.5 text-xs text-left hover:bg-accent transition-colors aria-disabled:opacity-50 aria-disabled:cursor-not-allowed aria-disabled:hover:bg-transparent"
>
<FolderGit className="size-3.5" />
<Tooltip>