highperfocused/multica
1
0
Fork 0
mirror of https://github.com/multica-ai/multica.git synced 2026-08-03 19:20:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(handler): bump the agent's own runtime version in quick-create parent test (MUL-4330)

Browse Source 
TestQuickCreateIssueParentTrustBoundary bumped an arbitrary `LIMIT 1`
agent_runtime, but the handler version-checks agent.RuntimeID — the runtime
bound to the request's agent. In the shared handler test workspace, other
tests register additional runtimes, so the two diverge and the agent's real
runtime keeps the seed's empty cli_version, tripping the daemon-version gate
(422 daemon_version_unsupported) before the parent_issue_id assertions run.
Bump the runtime tied to the agent instead, making the setup deterministic.

Co-authored-by: multica-agent <github@multica.ai>
This commit is contained in:
J
2026-07-10 15:51:04 +08:00
parent 500c8cb149
commit e7ead2333f
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
server/internal/handler/quick_create_parent_test.go
View File

@@ -33,23 +33,27 @@ func TestQuickCreateIssueParentTrustBoundary(t *testing.T) {
}
ctx := context.Background()
// Resolve the seeded runtime + agent for this workspace, then bump the
// runtime metadata to a CLI version that clears MinQuickCreateCLIVersion.
// The seed runtime uses metadata '{}'::jsonb which would otherwise trip
// the daemon-version gate before we ever reach the parent_issue_id check.
// Resolve the agent this request targets, then bump the CLI version on the
// runtime BOUND TO that agent — that is the runtime the version gate checks
// (the handler uses agent.RuntimeID). Picking an arbitrary `LIMIT 1`
// agent_runtime is wrong when the shared test workspace holds more than one
// runtime (other handler tests register their own): the LIMIT 1 row need
// not be the agent's runtime, so the agent's real runtime stays on the
// seed's empty '{}' metadata and trips the daemon-version gate before we
// ever reach the parent_issue_id check.
var runtimeID, agentID string
if err := testPool.QueryRow(ctx,
`SELECT id FROM agent_runtime WHERE workspace_id = $1 LIMIT 1`,
testWorkspaceID,
).Scan(&runtimeID); err != nil {
t.Fatalf("fetch runtime: %v", err)
}
if err := testPool.QueryRow(ctx,
`SELECT id FROM agent WHERE workspace_id = $1 LIMIT 1`,
testWorkspaceID,
).Scan(&agentID); err != nil {
t.Fatalf("fetch agent: %v", err)
}
if err := testPool.QueryRow(ctx,
`SELECT runtime_id FROM agent WHERE id = $1`,
agentID,
).Scan(&runtimeID); err != nil {
t.Fatalf("fetch agent runtime: %v", err)
}
if _, err := testPool.Exec(ctx,
`UPDATE agent_runtime SET metadata = jsonb_build_object('cli_version', $1::text) WHERE id = $2`,
agent.MinQuickCreateCLIVersion, runtimeID,