highperfocused/multica
1
0
Fork 0
mirror of https://github.com/multica-ai/multica.git synced 2026-08-03 03:03:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): align grouped-issues pagination test with new default sort (MUL-2314)

Browse Source 
The default ListGroupedIssues sort changed from `position ASC` to
`created_at DESC, id DESC` in c462c80b. This test had its expected
order hard-coded to the old position-ASC sequence, so backend CI was
failing on it.

Add sub-millisecond sleeps between creates so created_at is
monotonically distinct, then flip the expected order to newest-first.
No handler change — the fix is in the test assertions.

Co-authored-by: multica-agent <github@multica.ai>
This commit is contained in:
Naiyuan Qing
2026-05-18 15:01:39 +08:00
parent 0127d6a258
commit f3db9dce4e
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
server/internal/handler/issue_grouped_test.go
View File

@@ -81,8 +81,14 @@ func TestListGroupedIssuesAssigneePaginatesPerGroup(t *testing.T) {
return id
}
// Sleep between creates so created_at is monotonically increasing and
// distinct. The default sort is `created_at DESC, id DESC` (MUL-2314),
// so without the sleeps timestamps can collide at sub-millisecond
// resolution and the id-tie-breaker makes the order non-deterministic.
createIssue("Grouped member one", "member", assigneeID, 1)
time.Sleep(10 * time.Millisecond)
createIssue("Grouped member two", "member", assigneeID, 2)
time.Sleep(10 * time.Millisecond)
createIssue("Grouped member three", "member", assigneeID, 3)
createIssue("Grouped agent one", "agent", agentID, 1)
@@ -117,7 +123,9 @@ func TestListGroupedIssuesAssigneePaginatesPerGroup(t *testing.T) {
if memberGroup.Total != 3 || len(memberGroup.Issues) != 2 {
t.Fatalf("member group total/page mismatch: total=%d len=%d", memberGroup.Total, len(memberGroup.Issues))
}
if memberGroup.Issues[0].Title != "Grouped member one" || memberGroup.Issues[1].Title != "Grouped member two" {
// Default sort is `created_at DESC, id DESC` (MUL-2314), so the newest
// issue ("three") comes first.
if memberGroup.Issues[0].Title != "Grouped member three" || memberGroup.Issues[1].Title != "Grouped member two" {
t.Fatalf("member group order mismatch: %#v", memberGroup.Issues)
}
@@ -150,7 +158,8 @@ func TestListGroupedIssuesAssigneePaginatesPerGroup(t *testing.T) {
if nextResp.Groups[0].ID != memberGroupID || nextResp.Groups[0].Total != 3 || len(nextResp.Groups[0].Issues) != 1 {
t.Fatalf("unexpected next-page group: %#v", nextResp.Groups[0])
}
if nextResp.Groups[0].Issues[0].Title != "Grouped member three" {
// With newest-first default sort, the third page entry is the oldest ("one").
if nextResp.Groups[0].Issues[0].Title != "Grouped member one" {
t.Fatalf("unexpected next-page issue: %#v", nextResp.Groups[0].Issues[0])
}
}