multica

highperfocused/multica

Fork 0

mirror of https://github.com/multica-ai/multica.git synced 2026-07-05 13:29:44 +02:00

...

Author	SHA1	Message	Date
Naiyuan Qing	5367200914	docs(squad): add Task 2b — wrap DeleteSquad transfer + archive in one tx Reviewer round-3 flagged that the v3 invariant ("after archive no issue points to the squad") was asserted on the happy path only. DeleteSquad's current best-effort impl breaks it two ways: - transfer failure → slog.Warn but archive proceeds (Unknown Squad, reopen-into-archived-squad bugs reappear) - archive failure after a committed transfer → 500 with squad still active but emptied Task 2b rewrites DeleteSquad to run TransferSquadAssignees + ArchiveSquad inside one pgx tx, mirroring the project.go:266-314 pattern. Publish moves below Commit. Adds two regression tests that lock both partial-write failure modes. Co-authored-by: multica-agent <github@multica.ai>	2026-05-15 15:24:31 +08:00
Naiyuan Qing	b09817ca51	docs(squad): plan v3 — revert to count-all/transfer-all on archive Reviewer round 2 surfaced two structural problems with plan v2's active-only carve-out: 1. useActorName resolves squad names via ListSquads, which filters archived_at IS NULL. A closed issue with an archived-squad assignee would render as "Unknown Squad". 2. The status-only update path in UpdateIssue skips validateAssigneePair, so a done/cancelled issue with an archived-squad assignee could be reopened to in_progress, violating the "no active issue on an archived squad" invariant enforced elsewhere. Both problems disappear by reverting to count-all + transfer-all: after ArchiveSquad runs, no issue points at the archived squad, so neither case can occur. The product trade-off is that closed historical issues now show the leader agent instead of the archived squad in their "Assigned to" badge — consistent with existing agent-level reassignment behavior elsewhere in the product. Field rename: active_issue_count -> issue_count. TransferSquadAssignees SQL is unchanged (already transfers all). Co-authored-by: multica-agent <github@multica.ai>	2026-05-15 15:12:30 +08:00
Naiyuan Qing	8a8cd22f6f	docs(squad): address plan-review feedback for archive + role plan Resolve the 4 items the reviewer raised on MUL-2265: 1. TS schema: declare `active_issue_count` as optional (`number \| null \| undefined`) so list/create/update Squad responses don't lie about their shape; only `getSquad` parses through SquadSchema. 2. Archive semantics: restrict TransferSquadAssignees to active issues (status NOT IN done, cancelled) so dialog count and SQL operate on one set and terminal-state issues keep their historical assignee. 3. Index assumption: corrected — `idx_issue_assignee (assignee_type, assignee_id)` exists and is sufficient at realistic squad cardinality; no new index needed. 4. Fixed `*int64` test comparison and added `.loose()` to SquadSchema per the local schemas.ts convention. Co-authored-by: multica-agent <github@multica.ai>	2026-05-15 14:49:38 +08:00

Author

SHA1

Message

Date

Naiyuan Qing

5367200914

docs(squad): add Task 2b — wrap DeleteSquad transfer + archive in one tx

Reviewer round-3 flagged that the v3 invariant ("after archive no
issue points to the squad") was asserted on the happy path only.
DeleteSquad's current best-effort impl breaks it two ways:
- transfer failure → slog.Warn but archive proceeds (Unknown Squad,
  reopen-into-archived-squad bugs reappear)
- archive failure after a committed transfer → 500 with squad still
  active but emptied

Task 2b rewrites DeleteSquad to run TransferSquadAssignees +
ArchiveSquad inside one pgx tx, mirroring the project.go:266-314
pattern. Publish moves below Commit. Adds two regression tests that
lock both partial-write failure modes.

Co-authored-by: multica-agent <github@multica.ai>

2026-05-15 15:24:31 +08:00

Naiyuan Qing

b09817ca51

docs(squad): plan v3 — revert to count-all/transfer-all on archive

Reviewer round 2 surfaced two structural problems with plan v2's
active-only carve-out:

1. useActorName resolves squad names via ListSquads, which filters
   archived_at IS NULL. A closed issue with an archived-squad assignee
   would render as "Unknown Squad".

2. The status-only update path in UpdateIssue skips validateAssigneePair,
   so a done/cancelled issue with an archived-squad assignee could be
   reopened to in_progress, violating the "no active issue on an archived
   squad" invariant enforced elsewhere.

Both problems disappear by reverting to count-all + transfer-all: after
ArchiveSquad runs, no issue points at the archived squad, so neither
case can occur. The product trade-off is that closed historical issues
now show the leader agent instead of the archived squad in their
"Assigned to" badge — consistent with existing agent-level reassignment
behavior elsewhere in the product.

Field rename: active_issue_count -> issue_count.
TransferSquadAssignees SQL is unchanged (already transfers all).

Co-authored-by: multica-agent <github@multica.ai>

2026-05-15 15:12:30 +08:00

Naiyuan Qing

8a8cd22f6f

docs(squad): address plan-review feedback for archive + role plan

Resolve the 4 items the reviewer raised on MUL-2265:

1. TS schema: declare `active_issue_count` as optional (`number | null | undefined`)
   so list/create/update Squad responses don't lie about their shape; only
   `getSquad` parses through SquadSchema.
2. Archive semantics: restrict TransferSquadAssignees to active issues
   (status NOT IN done, cancelled) so dialog count and SQL operate on one set
   and terminal-state issues keep their historical assignee.
3. Index assumption: corrected — `idx_issue_assignee (assignee_type,
   assignee_id)` exists and is sufficient at realistic squad cardinality;
   no new index needed.
4. Fixed `*int64` test comparison and added `.loose()` to SquadSchema per
   the local schemas.ts convention.

Co-authored-by: multica-agent <github@multica.ai>

2026-05-15 14:49:38 +08:00

1 changed files with 1283 additions and 0 deletions

1283

docs/plans/2026-05-15-squad-archive-and-role.md Normal file

View File

File diff suppressed because it is too large Load Diff

Compare commits

3 Commits

agent/walt ... agent/squi

1283

docs/plans/2026-05-15-squad-archive-and-role.md Normal file

View File

Compare commits

3 Commits agent/walt ... agent/squi

1283 docs/plans/2026-05-15-squad-archive-and-role.md Normal file View File

3 Commits

agent/walt ... agent/squi

1283

docs/plans/2026-05-15-squad-archive-and-role.md Normal file

View File