Compare commits

...

2 Commits

Author SHA1 Message Date
Jiayuan
eed41083cf fix(daemon): preserve existing GIT_CONFIG_* entries in gitEnv
Instead of resetting GIT_CONFIG_COUNT to 1, read the existing count
from the environment and append safe.directory at the next available
index. This preserves any env-scoped git config (auth, URL rewrites,
extra headers) injected into the daemon process.

Adds TestGitEnvPreservesExistingConfig to verify the append behavior.

Co-authored-by: multica-agent <github@multica.ai>
2026-05-01 16:10:09 +02:00
Jiayuan
798d16edf2 fix(daemon): add safe.directory=* to gitEnv to fix CI dubious ownership errors
TestRegisterTaskReposAllowsProjectOnlyURL and
TestRegisterTaskReposSurvivesWorkspaceRefresh fail on GitHub Actions CI
because git clone --bare from local temp directories triggers git's
safe.directory ownership check when the runner UID differs from the
directory owner.

Set safe.directory=* via GIT_CONFIG env vars in gitEnv() so all daemon
git subprocesses trust any directory. The daemon manages its own bare
caches and worktrees, so the ownership check provides no security value.

Co-authored-by: multica-agent <github@multica.ai>
2026-05-01 15:59:46 +02:00
2 changed files with 87 additions and 1 deletions

View File

@@ -10,6 +10,7 @@ import (
"os/exec"
"path/filepath"
"regexp"
"strconv"
"strings"
"sync"
"time"
@@ -19,8 +20,34 @@ import (
// It passes the full daemon environment so credential helpers (e.g. gh) can
// locate their config, and disables TTY prompting so auth failures produce
// clear errors instead of blocking on a non-existent terminal.
//
// safe.directory=* is set via GIT_CONFIG_* env vars so git trusts all
// directories regardless of ownership. The daemon manages its own bare
// caches and worktrees, so the ownership check adds no security value
// and breaks CI environments where the runner UID differs from the
// directory owner.
func gitEnv() []string {
return append(os.Environ(), "GIT_TERMINAL_PROMPT=0")
base := os.Environ()
// Find the existing GIT_CONFIG_COUNT so we append at the next index
// rather than overwriting any env-scoped git config (auth, URL
// rewrites, extra headers, etc.).
existing := 0
for _, e := range base {
if strings.HasPrefix(e, "GIT_CONFIG_COUNT=") {
if n, err := strconv.Atoi(strings.TrimPrefix(e, "GIT_CONFIG_COUNT=")); err == nil {
existing = n
}
}
}
idx := strconv.Itoa(existing)
return append(base,
"GIT_TERMINAL_PROMPT=0",
"GIT_CONFIG_COUNT="+strconv.Itoa(existing+1),
"GIT_CONFIG_KEY_"+idx+"=safe.directory",
"GIT_CONFIG_VALUE_"+idx+"=*",
)
}
// RepoInfo describes a repository to cache.

View File

@@ -44,6 +44,65 @@ func TestGitEnv(t *testing.T) {
if !foundHome {
t.Error("gitEnv() must include HOME from os.Environ()")
}
// Must set safe.directory=* via GIT_CONFIG env vars.
envHas := func(env []string, want string) bool {
for _, e := range env {
if e == want {
return true
}
}
return false
}
if !envHas(env, "GIT_CONFIG_KEY_0=safe.directory") {
t.Error("gitEnv() must include GIT_CONFIG_KEY_0=safe.directory (no pre-existing config)")
}
if !envHas(env, "GIT_CONFIG_VALUE_0=*") {
t.Error("gitEnv() must include GIT_CONFIG_VALUE_0=*")
}
}
func TestGitEnvPreservesExistingConfig(t *testing.T) {
// GIT_CONFIG_COUNT env vars are process-wide; cannot use t.Setenv in
// parallel tests, so run sequentially.
t.Setenv("GIT_CONFIG_COUNT", "2")
t.Setenv("GIT_CONFIG_KEY_0", "url.https://github.com/.insteadOf")
t.Setenv("GIT_CONFIG_VALUE_0", "gh:")
t.Setenv("GIT_CONFIG_KEY_1", "http.extraHeader")
t.Setenv("GIT_CONFIG_VALUE_1", "Authorization: Bearer tok")
env := gitEnv()
envHas := func(want string) bool {
for _, e := range env {
if e == want {
return true
}
}
return false
}
// safe.directory must be appended at index 2 (next available).
if !envHas("GIT_CONFIG_COUNT=3") {
t.Error("expected GIT_CONFIG_COUNT=3")
}
if !envHas("GIT_CONFIG_KEY_2=safe.directory") {
t.Error("expected GIT_CONFIG_KEY_2=safe.directory")
}
if !envHas("GIT_CONFIG_VALUE_2=*") {
t.Error("expected GIT_CONFIG_VALUE_2=*")
}
// Original entries must still be present.
if !envHas("GIT_CONFIG_KEY_0=url.https://github.com/.insteadOf") {
t.Error("existing GIT_CONFIG_KEY_0 was lost")
}
if !envHas("GIT_CONFIG_VALUE_0=gh:") {
t.Error("existing GIT_CONFIG_VALUE_0 was lost")
}
if !envHas("GIT_CONFIG_KEY_1=http.extraHeader") {
t.Error("existing GIT_CONFIG_KEY_1 was lost")
}
}
func TestBareDirName(t *testing.T) {