mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-04 07:34:25 +02:00
* docs(timezone): add scheduling/viewing timezone architecture RFC * feat(db): replace daily rollups with task_usage_hourly, add user.timezone Migrations 100-104: add "user".timezone (Viewing tz), build the UTC hourly task_usage_hourly rollup with its pipeline, drop the legacy task_usage_daily / task_usage_dashboard_daily pipelines, and drop the agent_runtime.timezone column. Report queries now slice day boundaries at read time by the caller-supplied @tz instead of materialising in a fixed tz. Regenerate sqlc. * feat(server): add task_usage_hourly backfill command Replace the two legacy backfill commands (daily / dashboard_daily) with a single backfill_task_usage_hourly that loads historical task_usage into the new UTC hourly rollup, sliced per workspace. * refactor(server): resolve viewing timezone in report handlers Report handlers resolve the Viewing tz per request (?tz query param, then user.timezone, then UTC) and pass it to the hourly-rollup queries. Drop the UseDailyRollup feature flags and the old raw-scan/daily-rollup dual paths, remove the /api/usage endpoints, and stop the daemon from reporting and the runtime handler from accepting host timezone. * refactor(core): switch report queries to viewing timezone API client and dashboard/runtime queries send ?tz with each report request, the user schema/types carry the new timezone field, and the runtime timezone field/mutation is removed. * feat(views): add viewing timezone preference and UI Add the useViewingTimezone hook and a Timezone setting in Preferences; report charts and the dashboard week boundary follow the viewer tz. Remove the runtime detail timezone editor and its locale strings. * fix(test): update fixtures and stabilize tests for timezone refactor The timezone architecture refactor changed several types without updating dependent test code: - RuntimeDevice no longer has a timezone field — drop it from the create-agent-dialog runtime fixture. - User now requires a timezone field — add it to the apps/web mockUser fixture. - The PreferencesTab timezone tests asserted on the async save handler (PATCH then store update) with a bare expect, racing the mutation's settle callback, and timed out querying the Select's ~600-option IANA list on a loaded CI runner. Wrap the assertions in waitFor and extend the timeout for those three tests. * docs(timezone): document self-host migration order and trigger invariant Add a SELF-HOST UPGRADE ORDER runbook to the backfill command's package comment: applying migrations 100-104 in a single migrate-up drops the legacy daily rollups before the hourly backfill runs, leaving dashboards empty until cron catches up. Add an INVARIANT comment on trg_atq_dirty_hourly noting that agent_id must be added to the trigger's OF list if it ever becomes mutable, otherwise dirty buckets for the old agent_id are silently missed. * style(runtimes): drop trailing blank line in runtime-detail
167 lines
6.4 KiB
TypeScript
167 lines
6.4 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
||
import {
|
||
DashboardAgentRunTimeListSchema,
|
||
DashboardUsageByAgentListSchema,
|
||
DashboardUsageDailyListSchema,
|
||
DuplicateIssueErrorBodySchema,
|
||
EMPTY_USER,
|
||
RuntimeHourlyActivityListSchema,
|
||
RuntimeUsageByAgentListSchema,
|
||
RuntimeUsageByHourListSchema,
|
||
RuntimeUsageListSchema,
|
||
UserSchema,
|
||
} from "./schemas";
|
||
import { parseWithFallback } from "./schema";
|
||
|
||
// The duplicate-issue branch in create-issue.tsx feeds ApiError.body
|
||
// (typed as `unknown`) through this schema. Any future server drift that
|
||
// loses the contract MUST fail the parse so the UI falls back to a normal
|
||
// error toast instead of rendering an empty / partial duplicate card.
|
||
describe("DuplicateIssueErrorBodySchema", () => {
|
||
const valid = {
|
||
code: "active_duplicate_issue",
|
||
error: "An active issue with this title already exists: MUL-12 – Login bug",
|
||
issue: {
|
||
id: "11111111-1111-1111-1111-111111111111",
|
||
identifier: "MUL-12",
|
||
title: "Login bug",
|
||
},
|
||
};
|
||
|
||
it("accepts a well-formed body", () => {
|
||
expect(DuplicateIssueErrorBodySchema.safeParse(valid).success).toBe(true);
|
||
});
|
||
|
||
it("accepts unknown extra fields via .loose()", () => {
|
||
const forwardCompat = {
|
||
...valid,
|
||
hint: "Try a different title",
|
||
issue: { ...valid.issue, workspace_id: "ws-1", status: "todo" },
|
||
};
|
||
expect(DuplicateIssueErrorBodySchema.safeParse(forwardCompat).success).toBe(true);
|
||
});
|
||
|
||
it("rejects a renamed code (so renames degrade to the generic toast)", () => {
|
||
const renamed = { ...valid, code: "duplicate_issue" };
|
||
expect(DuplicateIssueErrorBodySchema.safeParse(renamed).success).toBe(false);
|
||
});
|
||
|
||
it("rejects a missing issue object", () => {
|
||
const { issue: _omit, ...without } = valid;
|
||
expect(DuplicateIssueErrorBodySchema.safeParse(without).success).toBe(false);
|
||
});
|
||
|
||
it("rejects a non-string issue.id", () => {
|
||
const broken = { ...valid, issue: { ...valid.issue, id: 42 } };
|
||
expect(DuplicateIssueErrorBodySchema.safeParse(broken).success).toBe(false);
|
||
});
|
||
|
||
it("accepts a missing error field (it is optional)", () => {
|
||
const { error: _omit, ...without } = valid;
|
||
expect(DuplicateIssueErrorBodySchema.safeParse(without).success).toBe(true);
|
||
});
|
||
});
|
||
|
||
// `user.timezone` (Viewing tz) was added in the timezone-architecture RFC.
|
||
// A desktop build older than the server — or a server predating the
|
||
// `user.timezone` migration — will return a `/api/me` body with no
|
||
// `timezone` key. The schema must not fail closed on that: the field
|
||
// defaults to `null`, which the frontend resolves to the browser-detected
|
||
// tz at render time.
|
||
describe("UserSchema timezone drift", () => {
|
||
const base = {
|
||
id: "11111111-1111-1111-1111-111111111111",
|
||
name: "Ada",
|
||
email: "ada@example.com",
|
||
};
|
||
|
||
it("defaults timezone to null when the field is absent", () => {
|
||
const parsed = UserSchema.parse(base);
|
||
expect(parsed.timezone).toBe(null);
|
||
});
|
||
|
||
it("preserves an explicit IANA timezone", () => {
|
||
const parsed = UserSchema.parse({ ...base, timezone: "Asia/Tokyo" });
|
||
expect(parsed.timezone).toBe("Asia/Tokyo");
|
||
});
|
||
|
||
it("accepts an explicit null timezone", () => {
|
||
const parsed = UserSchema.parse({ ...base, timezone: null });
|
||
expect(parsed.timezone).toBe(null);
|
||
});
|
||
|
||
// Wrong-type drift: a future server bug sending `timezone` as a number
|
||
// must not throw into the UI. parseWithFallback degrades the whole user
|
||
// object to the explicit fallback (EMPTY_USER) so /api/me callers keep a
|
||
// valid shape instead of white-screening.
|
||
it("falls back to EMPTY_USER when timezone is the wrong type", () => {
|
||
const parsed = parseWithFallback(
|
||
{ ...base, timezone: 42 },
|
||
UserSchema,
|
||
EMPTY_USER,
|
||
{ endpoint: "GET /api/me" },
|
||
);
|
||
expect(parsed).toBe(EMPTY_USER);
|
||
});
|
||
});
|
||
|
||
// The workspace dashboard and runtime-detail pages were re-pointed at the
|
||
// unified `task_usage_hourly` rollup. Every numeric field drives chart /
|
||
// KPI math, and string keys (date / agent_id / model) bucket the series.
|
||
// The contract these schemas must hold: a row missing a field degrades
|
||
// that field to a sane default rather than dropping the WHOLE array to
|
||
// the `[]` fallback — one drifted row must not blank the entire chart.
|
||
describe("dashboard + runtime usage schema drift", () => {
|
||
it("coerces a missing numeric field to 0 instead of dropping the array", () => {
|
||
const parsed = DashboardUsageDailyListSchema.parse([
|
||
{ date: "2026-05-19", model: "claude-opus-4-7", input_tokens: 100 },
|
||
]);
|
||
expect(parsed).toHaveLength(1);
|
||
expect(parsed[0]?.output_tokens).toBe(0);
|
||
expect(parsed[0]?.cache_read_tokens).toBe(0);
|
||
expect(parsed[0]?.cache_write_tokens).toBe(0);
|
||
});
|
||
|
||
it("coerces a missing date key to \"\" so the rest of the series survives", () => {
|
||
const parsed = DashboardUsageDailyListSchema.parse([
|
||
{ model: "claude-opus-4-7", input_tokens: 5 },
|
||
]);
|
||
expect(parsed).toHaveLength(1);
|
||
expect(parsed[0]?.date).toBe("");
|
||
});
|
||
|
||
it("coerces a missing agent_id key to \"\" for the agent-runtime panel", () => {
|
||
const parsed = DashboardAgentRunTimeListSchema.parse([
|
||
{ total_seconds: 42, task_count: 3, failed_count: 0 },
|
||
]);
|
||
expect(parsed).toHaveLength(1);
|
||
expect(parsed[0]?.agent_id).toBe("");
|
||
});
|
||
|
||
it("coerces a missing agent_id key to \"\" for the usage-by-agent panel", () => {
|
||
const parsed = DashboardUsageByAgentListSchema.parse([
|
||
{ model: "claude-opus-4-7", input_tokens: 7 },
|
||
]);
|
||
expect(parsed[0]?.agent_id).toBe("");
|
||
});
|
||
|
||
it("coerces missing fields on every runtime usage schema", () => {
|
||
expect(RuntimeUsageListSchema.parse([{ date: "2026-05-19" }])[0]?.input_tokens).toBe(0);
|
||
expect(RuntimeHourlyActivityListSchema.parse([{ hour: 9 }])[0]?.count).toBe(0);
|
||
expect(RuntimeUsageByAgentListSchema.parse([{ model: "x" }])[0]?.agent_id).toBe("");
|
||
expect(RuntimeUsageByHourListSchema.parse([{ hour: 9 }])[0]?.model).toBe("");
|
||
});
|
||
|
||
it("rejects a non-array body so parseWithFallback can return its fallback", () => {
|
||
expect(DashboardUsageDailyListSchema.safeParse(null).success).toBe(false);
|
||
expect(RuntimeUsageListSchema.safeParse({ rows: [] }).success).toBe(false);
|
||
});
|
||
|
||
it("keeps unknown server-side fields via .loose()", () => {
|
||
const parsed = RuntimeUsageListSchema.parse([
|
||
{ date: "2026-05-19", region: "us-east" },
|
||
]);
|
||
expect((parsed[0] as Record<string, unknown>).region).toBe("us-east");
|
||
});
|
||
});
|