mirror of
https://github.com/multica-ai/multica.git
synced 2026-08-12 19:06:06 +02:00
* fix: ingest feishu media as chat attachments * fix: ingest feishu post embedded media * fix(lark): make inbound media retries safe * fix lark media resource limit * fix(lark): move inbound media off ack path * fix(channel): make inbound media runs durable * fix(channel): close enqueue-vs-append race on media deferral EnqueueChatTask read the session-wide media deadline in one statement and sealed the input batch in a later one. Under READ COMMITTED a media message committing between the two got sealed into a task the deadline read had already decided was 'queued', so the daemon could claim it before its attachment bound — the agent received the bare placeholder, and the later media-ready promotion was a no-op against a non-deferred task. After the seal, re-derive the deferral from the sealed batch itself in the same transaction (DeferChatTaskForSealedPendingMedia): if any sealed message still carries an unexpired media marker, flip the task to deferred with fire_at aligned to the latest marker. The existing post-commit promote fence already covers the opposite direction (marker cleared mid-transaction). Adds a deterministic regression test that injects the media append between the deadline read and the seal via a wrapped pgx.Tx. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): keep committed chat task out of enqueue error path The post-commit media-ready fence returned its error from EnqueueChatTask even though the deferred task was already durably committed. The router flush treats any enqueue error as "no task exists": it clears the typing indicator and logs an enqueue failure while the run still happens at its fire_at deadline. Log the fence failure instead — the claim-path deferred promoter re-queues the task regardless. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): cap global media resolution concurrency Media jobs were serialized per session but unbounded across sessions: a burst could open arbitrarily many concurrent 45s Lark downloads, and each unknown-length upload may buffer up to the 100 MiB resource cap in memory. Gate resolveAndBindMedia behind a global slot semaphore (default 8, RouterConfig.MediaConcurrency). Per-session ordering is unchanged; on shutdown a job cancelled while waiting for a slot proceeds straight to the bounded DB finalize so marker clearing stays prompt. Also document that the per-message media budget spans queue/slot waits (it must match the persisted fire_at) and why timed-out uploads cannot leak unbounded orphans. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(chat): keep channel-sealed user messages on task cancel Sealing the channel input batch stamps task_id onto channel user messages, which exposed them to the cancel draft-restore path: an empty-transcript cancel would DeleteUserChatMessageByTask the sealed Feishu/Slack messages and detach their attachments. Those messages are the durable record of what the platform sender wrote — the sender has no Multica composer to restore a draft into. Gate the restore-delete on ChatSessionHasChannelBinding in both the synchronous finalize and the deferred finalize (the latter covers markers left by an older replica during a rolling deploy); a bound session now settles as "Stopped." instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): skip the media pipeline for messages without media Every inbound message on a Media-enabled platform persisted a 45s media deadline and queued a resolution job, so a plain text message could wait behind the global media semaphore (its task deferred while other sessions download 100 MiB videos) and a crash between append and clear delayed a pure-text run to the full 45s fallback. Add MediaResolver.HasMedia — a pure in-memory probe the Router calls on the ACK path — and only persist the deadline / enqueue the job when the message actually references platform media. The Feishu resolver decodes the already-received payload and reports standalone image or video keys and post-embedded img/media spans. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(chat): gate cancel restore on immutable channel provenance The previous guard keyed the cancel restore-delete off ChatSessionHasChannelBinding, but a binding only proves routing exists right now: archiving a session and rebinding an installation both delete the binding while preserving chat history, so a still-cancellable sealed task could again restore-delete the original inbound messages. Persist provenance on the message instead: migration 203 adds chat_message.channel_ingested, stamped inside the channel append transaction and never mutated, and both cancel finalize paths now gate on TaskHasChannelIngestedMessages over the task's sealed batch. The binding-existence query is removed. Regression tests cover ingest -> archive/unbind -> cancel for a queued and a started task. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): reclaim media uploads that never gain an attachment row Deadline expiry dropped already-resolved refs and a BindMedia failure was log-only, leaving uploaded objects with no attachment row and no reclaim path — the dedup mark commits with the message before media runs, so a redelivery is dropped as a duplicate and never re-resolves (and thus never overwrites) those keys, and workspace/session deletion only enumerates the attachment table. Add MediaResolver.DiscardMedia — a best-effort delete by StorageKey — and call it from both failure paths in resolveAndBindMedia. The Feishu resolver forwards to the storage backend's Delete. Tests cover a partial upload discarded at the deadline, discard on bind failure, and key-level deletion in the resolver. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(server): refresh comments stale after detached media ingestion Channel tasks now seal a self-owned input batch, media ingestion is no longer out of scope for the flattener, and MediaRefs are filled by the detached resolver after append rather than by feishuChannel pre-engine. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(chat): stop keying channel empty-completion silence off chat_input_task_id Sealing gave channel tasks a self input-owner, which broke writeChatCompletionOutcome's discriminator: it treated any owned task as direct, so an empty channel completion wrote the no_response fallback row and the outbound patcher — which forwards any non-empty chat:done content verbatim — pushed the English fallback body to Feishu/Slack, violating the MUL-4351 contract. Silence is now decided by the immutable channel_ingested provenance of the task's input batch, looked up by the batch OWNER id (chat_input_task_id): auto-retry clones inherit the owner while their sealed messages stay tagged with the parent's id, so keying off the task's own id would misread a channel retry as direct. The cancel-path provenance gates switch to the same owner key via chatInputOwnerID. chat_input_task_id is back to meaning only "input batch owner". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(migrations): renumber to 203/204 after upstream took 202 Upstream main merged 202_runtime_profile_add_qwen while this branch held 202/203, tripping TestMigrationNumericPrefixesStayUniqueAfterLegacySet on the CI merge tree. channel_media_pending becomes 203 and channel_ingested becomes 204; no content changes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channels): gate outbound delivery on channel provenance, not owner Merging main brought #5645 (keep direct chat replies in Multica), whose outbound gate assumed channel tasks leave chat_input_task_id NULL. Sealed channel tasks own an input batch too, so on the merge tree every channel reply and failure notice was classified as direct and silently dropped — agents stopped replying in Feishu/Slack. Both outbound gates now call engine.TaskInputIsChannelIngested: a NULL owner keeps #5645's deliver-by-default for pre-sealing tasks, an owned batch delivers only when it carries the immutable channel_ingested stamp (keyed by the owner id, so auto-retry clones inherit the verdict). Direct replies stay in Multica; sealed channel replies reach the platform. Tests cover both directions on both platforms. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): discard media orphans on a fresh context, after finalize DiscardMedia shared finalizeCtx with BindMedia, so a bind that failed because the finalize deadline expired handed the storage deletes an already-dead context — the compensation silently no-opped and the orphans leaked anyway. The deadline path also ran S3 deletes before the marker clear, eating the same 5s budget the user-facing bind/promotion needed. Collect the refs from both failure paths, run bind + promotion on the finalize budget first, then delete on a fresh discard context. The bind-failure test now pins that discard receives a live context. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): compensate result-uncertain media uploads and commits The compensation protocol treated "the call returned an error" as "the side effect did not happen", which is wrong in both directions across the result-uncertain windows: - An upload error can follow a server-side write (lost response, deadline mid-write). The attempted key never reached the router, so nothing could reclaim it and dedup guarantees no re-resolve. The resolver now idempotently deletes the deterministic key on a fresh budget right at the failure site. - A commit error is not a rollback guarantee: a lost ack can report failure after Postgres durably committed the attachment rows, and the router's discard would then delete objects those rows reference. BindMediaRefs now converges the ambiguity on a fresh budget — any of the batch's URLs present proves the atomic commit landed (bind reports success); none proves the rollback (discard stays safe); a failed verification returns ErrMediaBindResultUnknown and the router keeps the uploads, preferring a rare orphan over a broken attachment. Fault-injection coverage: an upload error deletes the attempted key; a lost-ack commit keeps the bound attachment and reports success; a verified rollback stays a discardable error; the router keeps uploads on the unknown-outcome sentinel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(migrations): renumber to 207/208 after upstream took 203-206 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(channel): note DiscardMedia self-invocation and the unknown-outcome skip Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(migrations): renumber to 212/213 after upstream took 207-211 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(channel): replace inline media compensation with an intent ledger and reconciler Inline best-effort compensation cannot answer "did my side effect happen?" at the moment it needs the answer — the DELETE/PUT reordering and the empty-read-vs-in-flight-COMMIT gaps were both instances of the same two-system atomicity problem. Persist the intent instead and let an asynchronous reconciler settle it: - channel_media_pending_object (migration 214; claim index 215 as its own single-statement CONCURRENTLY migration): a state machine row ('pending' -> 'deleting') with lease, attempt, and backoff columns. - The resolver upserts the row BEFORE each PUT, state-guarded so a key the reconciler owns is never resurrected (the resource is skipped). ObjectURL is a pure function of configuration, so the row carries the attachment URL pre-upload. - BindMediaRefs deletes the batch's rows INSIDE the attachment-insert transaction: commit landed <=> intents gone, atomically, so an ambiguous COMMIT never needs adjudication. A key already claimed to 'deleting' is skipped (placeholder stays). - Nothing is ever deleted inline. The reconciler — an independent worker so storage latency cannot starve other sweepers — claims due rows ('pending' past the settle delay, or expired leases) under a fresh lease, checks for a durable attachment reference only AFTER the claim (race-free: bind can no longer succeed on the key), deletes unreferenced objects outside any transaction, and backs off failed deletes with attempt-based retry. Crash windows converge for free. - The settle delay is a fixed constant carrying NO correctness weight; invariant tests pin it at >=10x every pipeline budget. Metrics cover deletes, referenced clears, delete failures, and ledger backlog. Removed: MediaResolver.DiscardMedia, ErrMediaBindResultUnknown, the post-commit verification, and both router discard branches. Tests: intent-before-upload ordering; upload error leaves the row and deletes nothing; bind-wins vs reconciler-wins on the same key; lost-ack and rolled-back commit injections (intent cleared iff the attachment landed); reconciler three-state settle; expired-lease reclaim; delete failure backoff and retry; settle invariants. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): never build or sweep the media reconciler without storage store is nil when S3 is unconfigured AND the local upload dir fails to initialize, but the reconciler was constructed unconditionally and main only gates the goroutine on the reconciler pointer — the first unreferenced ledger row (rows can pre-exist from a boot where storage worked) would nil-pointer panic a bare goroutine and take down the process. Construct the reconciler only when a storage backend exists, and guard RunOnce defensively: with no deleter it skips the sweep without claiming, so rows are not stranded in 'deleting' until lease expiry. Test covers the pre-existing-row + missing-storage boot. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(migrations): renumber to 213-216 after upstream took 212 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(channel): remove the dead pre-resolved MediaRefs ingress path lark.InboundMessage.MediaRefs and the resolver's early-returns for pre-populated refs were vestiges of the pre-detached synchronous design — no producer fills them before the router anymore. Worse, the intent ledger made the path actively misleading: refs arriving without ledger rows would be silently skipped at bind (with a log blaming the reconciler), contradicting the field's "already persisted" contract. Delete the field, its channelMessageFromLark mapping, and both early-returns; channel.InboundMessage.MediaRefs is now documented as what it actually is — ResolveMedia's output channel, always empty on ingress, attachable only through a claimed ledger intent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): enforce workspace tenancy on every ledger query The intent-ledger upsert's conflict branch guarded only on state, so a cross-workspace storage_key collision could rewrite the row's workspace/message/url ownership; release and delete keyed on (storage_key, lease_token) alone. The derived key embeds the workspace UUID so none of this is reachable today — but tenancy must be enforced by the workspace column in every query, never derived from the key string (MUL-3515 rule, restated in this PR's review). The upsert now updates only within the same workspace (a cross-tenant conflict updates nothing, returns no row, and the resolver skips the upload — the fail-safe direction), and release/delete take (workspace_id, storage_key, lease_token). Tests pin that a foreign workspace can neither steal, release, nor delete a row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(migrations): build the ledger primary key via a concurrent index storage_key TEXT PRIMARY KEY created its unique index implicitly at CREATE TABLE, against the repo convention that every migration index — including a new table's unique index — is built CONCURRENTLY in its own single-statement migration (the exact three-step pattern client_usage_daily shipped in 207-209). The table now declares storage_key NOT NULL, 216 builds the unique index concurrently, and 217 attaches the primary key USING INDEX; the claim index moves to 218. ON CONFLICT (storage_key) still resolves against the constraint, and the full down/up round-trip is verified. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): bound each reconciler object delete with its own timeout DeleteObject ran on the worker-lifetime context and the SDK's default HTTP client has no overall request timeout, so one black-holed connection would wedge the sequential sweep loop — and with it every later batch and the backlog gauge — forever; a single-replica deployment has no other worker to reclaim the lease. Each delete now gets a 30s timeout (well under the 2min lease), and a timed-out delete takes the existing release/backoff path. Covered by a blocking-deleter test with an injectable timeout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): anchor the media deadline to the DB clock and bound queue waits by it Two deadline gaps from review: - The persisted marker was an application-clock timestamp compared against SQL now() everywhere it is read, so a skewed app node could shrink the fallback window and hand the agent a placeholder before the resolver's local budget ended. The append transaction now anchors a relative budget (MediaPendingSeconds) with now() + make_interval, writer and readers sharing one clock; the local resolve budget stays monotonic app-side. A DB test pins that the remaining budget measured by the DB clock equals the requested one. - enqueueMedia's waits (per-session order, global slot) only watched shutdown, so in a burst an already-expired job kept its goroutine and payload until it reached the front. Both waits now also watch the message's deadline; on expiry the job skips the resolver entirely and runs only the empty finalize (marker clear + promotion), which also unblocks the session's later messages. Covered by a queued-expiry test that finalizes while the only slot is deterministically held. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(migrations): renumber to 216-221 after upstream took 213-215 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): start the local media budget before the append transaction The DB anchors the durable fallback at insert-time now(), but the local monotonic budget started only after AppendMessage returned — so the resolver outlived the fallback by the append/commit latency, a window where the deferred task is already claimable while the resolver still runs and the agent reads a placeholder that binds moments later. Capture the local deadline before calling AppendMessage, restoring the ordering local-gives-up <= durable-fallback-fires. A slow-append test pins that the resolver's context deadline is measured from the pre-append instant. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(migrations): renumber to 224-229 after upstream took 216-223 Verified against the merged tree: the numeric-prefix uniqueness test passes and the full migration set applies cleanly from scratch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): heartbeat the reconciler lease per row One claim covers up to 50 rows under a single 2-minute lease, but the batch is processed sequentially and each delete may run its full 30s timeout — a few stalled deletes could outlive the lease mid-batch, letting another replica reclaim the tail: duplicate concurrent deletes, inflated attempt/backoff on rows whose owner was alive, and skewed metrics. The lease is now renewed before EACH row's settle work, so it only ever needs to cover one row's worst case (invariant-tested: lease >= 2x the per-delete timeout). A renewal that matches no row means another worker reclaimed it after a genuine expiry — the row is skipped, leaving the new owner's state untouched. Test simulates a mid-batch reclaim and pins the skip. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): dedup post media resources and make local writes atomic A rich post may reference the same image_key/file_key in several spans. The object key derives from (message, type, key), so duplicates uploaded to the SAME key twice: LocalStorage.UploadStream truncated the destination up front and removed it outright on a copy error, so a second failing attempt destroyed the object the first success had produced — leaving an attachment row pointing at nothing. A second succeeding attempt instead produced two attachment rows for one object. Collapse duplicate spans by (fetch type, platform key) before the upload loop, and write local uploads through a temp file renamed into place so a failed write can only discard its own temp file. Tests cover a duplicated span uploading once and a failed re-upload leaving the previous object intact. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): fence late-materializing PUTs with a tombstone schedule A DELETE cannot be ordered against a PUT the client already abandoned: the store may materialize the object after the delete completes. The reconciler cleared the ledger row right after deleting, so such an object had no row and nothing to reclaim it — which made the settle delay the de-facto correctness barrier for the PUT/DELETE race, exactly what the design says it must not be. The row is now kept as a tombstone ('tombstoned' state, migration 226's CHECK) and re-deleted on a widening schedule (15m, 1h, 6h, 24h, the pass index carried in last_error), so a late materialization is reclaimed by a later pass; only after the schedule is exhausted is the row dropped. Claim, heartbeat, lease, and tenancy predicates are unchanged — a tombstone is claimed exactly like any other due row. A separate gauge reports tombstones so they cannot be mistaken for a backlog of objects awaiting reclaim, and the header comment now states precisely what state fences (bind/commit) versus what the schedule fences (late PUTs). Tests: the reviewer's interleaving — DELETE completes, the abandoned PUT materializes right after, and the object is gone by the end of the schedule — plus a full schedule walk asserting the object is counted once and the row clears at the end. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): tombstones must re-delete, not re-ask the reference question A tombstone revisit ran the same reference check as a first settle, so an attachment carrying the same URL — a re-ingested copy of the object — sent the row down the "referenced, keep it" branch: the object was kept and the row cleared, abandoning the re-delete schedule that fences the ORIGINAL object against an abandoned PUT. A tombstone has already been judged unreferenced and deleted; it exists only to re-delete whatever materializes later, so it now goes straight to the delete + schedule tail (extracted as settleDeletedObject, shared with the first settle). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(channel): keep the tombstone schedule position in its own column The re-delete pass index was encoded into last_error, which the failure path also writes: one failed re-delete erased the position and restarted the walk. A store failing intermittently could therefore keep a tombstone alive indefinitely — every recovery would resume at pass 1 and the row would never reach the end of the schedule to be dropped. tombstone_pass is now its own column (the table is introduced in this PR, so migration 226 carries it), advanced only by a successful delete, and the tombstone write clears the now-stale last_error. Test walks the schedule across a failed re-delete and asserts it resumes rather than restarts, and that the row still terminates. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(lark): derive media object keys per chat message The object key was derived from the platform message alone, so a second ingest of the same Feishu message reused the first ingest's ledger row. That row can be a tombstone (up to ~31h while the re-delete schedule runs), and the intent upsert refuses anything that has left 'pending', so the second ingest skipped the upload and silently produced a placeholder with no attachment. A re-ingest is reachable: the inbound dedup claim is reclaimable once 60s stale and the dedup row is only vacuumed after 24h. Keying on the chat message the object will attach to keeps the two ingests independent, and nothing leaks: each one's objects are covered by its own ledger row. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * refactor(storage): route both local upload paths through one atomic write UploadStream wrote through a temp file and renamed into place, but the buffered Upload path still truncated the destination up front — the destructive shape the stream path exists to avoid, one caller away from coming back. Both now share writeAtomic, which also restores the 0644 the direct write used (CreateTemp makes files 0600). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(channel): gofmt the media-pending append fields Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(storage): keep the local upload chmod best-effort The rename-into-place rewrite made a failed chmod fail the whole upload. CreateTemp's 0600 has to be widened to the 0644 the direct write used, but an upload dir on a mount that ignores chmod (SMB/NFS/FUSE) accepted the old direct write fine — turning those deployments' uploads into hard errors would be a regression for a cosmetic property. Log and continue. Tests pin 0644 on both upload paths, and that a failed buffered upload leaves no temp litter and no damage to a previous object. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(channel): never re-delete an object an attachment references The tombstone pass skipped the reference check and deleted unconditionally, so a durable attachment carrying that URL lost the only object it can read — the dangling attachment the intent ledger exists to prevent, and the opposite of the posture every other path here takes ("a reclaimable orphan beats a broken attachment"). The check now runs on every pass. A positive result on a tombstone is unreachable by design — keys are per (chat message, resource) and a bind cannot attach a key that has left 'pending' — so reaching it means an invariant broke: keep the object, clear the row, log it, and count it on a dedicated reconciler_tombstone_referenced_total counter. The test's contract is flipped to assert the referenced object survives. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(storage): make the local staging file reclaimable after a crash os.CreateTemp's random suffix meant a crash between the staging write and the rename left a file nothing could name: the ledger records only the final storage key, and DeleteObject removed only the object and its sidecar. Each leftover can approach the 100 MiB resource cap and they accumulate without bound. The staging path is now derived from the object key, so DeleteObject removes it alongside the object — which makes the media reconciler reclaim it too, since the intent row is written before the upload. Opening it 0644 directly also drops the chmod the previous commit had to make best-effort. Both read paths refuse the staging name (keys come from the request URL, and a half-written body should not be readable); a user-supplied ".tmp" extension is unaffected, since object keys are generated and never dot-prefixed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(channel): renumber the media migrations after merging main main took 224 (agent_task_session_rollout_missing), so the ledger group moves to 225-230 and the cross-references inside the table migration follow. main's CompleteTask also grew a sessionRolloutMissing parameter; the three call sites this PR added to chat_input_ownership_test.go pass false. Verified the way the numbering is meant to be verified: full migration set applied from scratch on the merged tree, and the whole server suite run against that database. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * fix(channel): let Postgres compute every reconciler deadline The reconciler built settle cutoffs, lease expiry, backoff and re-delete times from the process clock and compared them against the database's now(). A replica whose clock had drifted would therefore settle rows whose upload was still in flight (the object is deleted and the bind then refuses to attach — media silently lost), hand out leases that are born expired (rows churn between workers, attempt/backoff inflate), or compress the tombstone schedule that fences a late-materializing PUT. The four settle queries now take durations and derive their timestamps from now(), so every replica reads one clock. The parameter types are the guard: an app-side timestamp can no longer be passed. Test asserts the persisted lease, backoff and re-delete deadlines all track the database's now(). The generated code also picks up main's new agent_task_queue column in the two RETURNING task.* queries this PR adds. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * chore(lark): drop unrelated gofmt-only churn from this PR Six files carried whitespace/comment-reformatting with no functional change, unrelated to the inbound media pipeline. Reverting them to the base revision keeps the diff focused on the feature (75 -> 69 files): server/internal/service/empty_claim_cache.go server/internal/integrations/lark/markdown_detect.go server/internal/integrations/lark/ws_chunk_assembler.go server/internal/integrations/lark/ws_chunk_assembler_test.go server/internal/integrations/lark/ws_frame_test.go server/internal/integrations/lark/registration_test.go Verified: `git diff -w` against these files was already empty, so no behavior is affected. go vet clean; tests covering these files pass. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Bohan-J <bohan@devv.ai> Co-authored-by: multica-agent <github@multica.ai>
323 lines
14 KiB
Go
323 lines
14 KiB
Go
package engine
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
|
|
"github.com/jackc/pgx/v5"
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
|
|
"github.com/multica-ai/multica/server/internal/integrations/channel"
|
|
"github.com/multica-ai/multica/server/internal/service"
|
|
db "github.com/multica-ai/multica/server/pkg/db/generated"
|
|
)
|
|
|
|
// This file defines the pluggable seams the Router runs the inbound pipeline
|
|
// through. Everything platform-specific lives behind these interfaces; a
|
|
// platform registers a ResolverSet and the channel-agnostic Router stays
|
|
// unchanged. The Feishu implementation is the first ResolverSet.
|
|
|
|
// Outcome categorizes what the Router decided to do with an inbound message.
|
|
// Values match the legacy lark outcomes 1:1 so behavior and dashboards carry
|
|
// over unchanged.
|
|
type Outcome string
|
|
|
|
const (
|
|
OutcomeDropped Outcome = "dropped"
|
|
OutcomeNeedsBinding Outcome = "needs_binding"
|
|
OutcomeIngested Outcome = "ingested"
|
|
OutcomeAgentOffline Outcome = "agent_offline"
|
|
OutcomeAgentArchived Outcome = "agent_archived"
|
|
)
|
|
|
|
// DropReason enumerates the drop-audit categories. Values match the legacy
|
|
// lark drop reasons 1:1.
|
|
type DropReason string
|
|
|
|
const (
|
|
DropReasonUnboundUser DropReason = "unbound_user"
|
|
DropReasonNonWorkspaceMember DropReason = "non_workspace_member"
|
|
DropReasonNotAddressedInGroup DropReason = "not_addressed_in_group"
|
|
DropReasonDuplicate DropReason = "duplicate"
|
|
DropReasonRevokedInstallation DropReason = "revoked_installation"
|
|
DropReasonInvalidEvent DropReason = "invalid_event"
|
|
)
|
|
|
|
// Result is the typed verdict the Router produces for one inbound message,
|
|
// consumed by the outbound side (OutboundReplier / typing). It mirrors the
|
|
// legacy lark.DispatchResult.
|
|
type Result struct {
|
|
Outcome Outcome
|
|
DropReason DropReason
|
|
InstallationID pgtype.UUID
|
|
ChatSessionID pgtype.UUID
|
|
// Sender is the platform-native sender id (e.g. Lark open_id), so the
|
|
// replier can target a binding prompt back to the sender.
|
|
Sender string
|
|
IssueID pgtype.UUID
|
|
IssueNumber int32
|
|
IssueIdentifier string
|
|
IssueTitle string
|
|
}
|
|
|
|
// ResolvedInstallation is the channel-agnostic installation context the Router
|
|
// needs after routing. Platform carries the adapter's own installation value
|
|
// opaquely so the set's other ports (binder, replier, typing) reuse it without
|
|
// a re-fetch; the Router never reads Platform.
|
|
type ResolvedInstallation struct {
|
|
ID pgtype.UUID
|
|
WorkspaceID pgtype.UUID
|
|
AgentID pgtype.UUID
|
|
InstallerUserID pgtype.UUID
|
|
Active bool
|
|
Platform any
|
|
}
|
|
|
|
// ResolvedIdentity is the sender mapped to a Multica user.
|
|
type ResolvedIdentity struct {
|
|
UserID pgtype.UUID
|
|
}
|
|
|
|
// EnsureSessionParams carries the inputs for SessionBinder.EnsureSession.
|
|
// Sender is the resolved session creator (the sole human for p2p, the
|
|
// installer for group chats — the Router decides which and passes it here).
|
|
type EnsureSessionParams struct {
|
|
Installation ResolvedInstallation
|
|
Sender pgtype.UUID
|
|
Message channel.InboundMessage
|
|
}
|
|
|
|
// AppendParams carries the inputs for SessionBinder.AppendMessage. ClaimToken
|
|
// is the dedup owner-fence token; the binder runs the dedup Mark INSIDE its
|
|
// chat_message+session tx so the durable write and the Mark commit atomically.
|
|
// MediaPendingSeconds persists the placeholder fallback budget; the append
|
|
// transaction turns it into a DB-clock deadline (now() + budget) so every
|
|
// now()-based consumer reads the same clock that wrote it.
|
|
type AppendParams struct {
|
|
SessionID pgtype.UUID
|
|
Sender pgtype.UUID
|
|
InstallationID pgtype.UUID
|
|
Message channel.InboundMessage
|
|
ClaimToken pgtype.UUID
|
|
MediaPendingSeconds float64
|
|
}
|
|
|
|
// AppendResult reports what AppendMessage decided.
|
|
type AppendResult struct {
|
|
// MessageID is the durable chat_message row created by AppendMessage.
|
|
// Detached media processing uses it to link attachments after the
|
|
// connector ACK path has completed.
|
|
MessageID pgtype.UUID
|
|
// IssueCommand is non-nil when the message was an /issue command.
|
|
IssueCommand *IssueCommand
|
|
// DedupMarked is true when AppendMessage finalized the dedup claim in its
|
|
// own tx; the Router then skips the post-pipeline finalize.
|
|
DedupMarked bool
|
|
}
|
|
|
|
// BindMediaParams carries stored media references to the post-append
|
|
// attachment transaction. MessageID is the durable chat_message created by
|
|
// AppendMessage; media downloads must never run inside this transaction.
|
|
type BindMediaParams struct {
|
|
MessageID pgtype.UUID
|
|
SessionID pgtype.UUID
|
|
WorkspaceID pgtype.UUID
|
|
Sender pgtype.UUID
|
|
MediaRefs []channel.MediaRef
|
|
}
|
|
|
|
// IssueCommand is the parsed /issue command.
|
|
type IssueCommand struct {
|
|
Title string
|
|
Description string
|
|
}
|
|
|
|
// Sentinel errors the resolvers return so the Router can map them to the right
|
|
// product outcome instead of an infrastructure failure.
|
|
var (
|
|
// ErrInstallationNotFound: no installation matches the message's routing
|
|
// key → invalid_event drop.
|
|
ErrInstallationNotFound = errors.New("engine: installation not found")
|
|
// ErrSenderUnbound: the sender has no identity binding → needs_binding.
|
|
ErrSenderUnbound = errors.New("engine: sender unbound")
|
|
// ErrSenderNotMember: the sender is bound but not a workspace member →
|
|
// non_workspace_member drop.
|
|
ErrSenderNotMember = errors.New("engine: sender not a workspace member")
|
|
// ErrDuplicate: Claim found the message already processed / in flight →
|
|
// duplicate drop.
|
|
ErrDuplicate = errors.New("engine: duplicate message")
|
|
// ErrClaimLost: a concurrent reclaim rotated the dedup token mid-flight →
|
|
// treated as a duplicate.
|
|
ErrClaimLost = errors.New("engine: dedup claim lost")
|
|
)
|
|
|
|
// InstallationResolver routes an inbound message to its installation. The
|
|
// adapter reads whatever platform routing key it needs from the message
|
|
// (Source or Raw). Return ErrInstallationNotFound when none matches; return a
|
|
// ResolvedInstallation with Active=false when it exists but is revoked.
|
|
type InstallationResolver interface {
|
|
ResolveInstallation(ctx context.Context, msg channel.InboundMessage) (ResolvedInstallation, error)
|
|
}
|
|
|
|
// IdentityResolver maps the message sender to a Multica user within the
|
|
// installation, re-checking workspace membership. Return ErrSenderUnbound or
|
|
// ErrSenderNotMember for the product cases.
|
|
type IdentityResolver interface {
|
|
ResolveSender(ctx context.Context, inst ResolvedInstallation, msg channel.InboundMessage) (ResolvedIdentity, error)
|
|
}
|
|
|
|
// Deduper is the two-phase idempotency seam. Claim mints an owner-fence token
|
|
// (ErrDuplicate when already processed / in flight); Mark/Release are fenced on
|
|
// the token (a no-op on token mismatch is not an error).
|
|
type Deduper interface {
|
|
Claim(ctx context.Context, installationID pgtype.UUID, messageID string) (claimToken pgtype.UUID, err error)
|
|
Mark(ctx context.Context, installationID pgtype.UUID, messageID string, claimToken pgtype.UUID) error
|
|
Release(ctx context.Context, installationID pgtype.UUID, messageID string, claimToken pgtype.UUID) error
|
|
}
|
|
|
|
// SessionBinder ensures the chat_session and appends the message (with the
|
|
// in-tx dedup Mark). AppendMessage returns ErrClaimLost when the token was
|
|
// rotated mid-flight.
|
|
type SessionBinder interface {
|
|
EnsureSession(ctx context.Context, p EnsureSessionParams) (pgtype.UUID, error)
|
|
AppendMessage(ctx context.Context, p AppendParams) (AppendResult, error)
|
|
BindMedia(ctx context.Context, p BindMediaParams) error
|
|
}
|
|
|
|
// MediaResolver resolves platform media after the user message and dedup mark
|
|
// are durable. The Router runs it off the connector ACK path and binds any
|
|
// returned MediaRefs; the independently scheduled task remains deferred until
|
|
// binding finishes or the persisted deadline expires. Implementations are
|
|
// best-effort: failures leave the stored placeholder text intact and NEVER
|
|
// delete anything inline — every uploaded object is covered by an intent-
|
|
// ledger row written before the PUT (see MediaIntentLedger), and the
|
|
// asynchronous reconciler settles whatever binding did not claim.
|
|
type MediaResolver interface {
|
|
// HasMedia reports whether msg references platform media that
|
|
// ResolveMedia would fetch. The Router calls it synchronously on the
|
|
// connector ACK path to decide whether to persist a media deadline and
|
|
// queue a resolution job at all, so implementations must be pure
|
|
// in-memory checks (no I/O). A false result keeps the message on the
|
|
// plain ingest path: no marker, no deferred run, no semaphore slot.
|
|
HasMedia(msg channel.InboundMessage) bool
|
|
// ResolveMedia downloads the platform media and uploads it to object
|
|
// storage. chatMessageID is the durable chat_message the refs will bind
|
|
// to; the intent ledger keys the reconciler's reference check on it.
|
|
ResolveMedia(ctx context.Context, inst ResolvedInstallation, sender ResolvedIdentity, sessionID, chatMessageID pgtype.UUID, msg channel.InboundMessage) channel.InboundMessage
|
|
}
|
|
|
|
// MediaIntentLedger persists upload intent BEFORE the object is written. The
|
|
// row is the only artifact any failure path leaves behind: upload error,
|
|
// resolve deadline, bind failure, ambiguous commit, or a crash all simply
|
|
// leave it for the reconciler, which settles it long after any in-flight PUT
|
|
// or COMMIT can still land. This is what makes "did my side effect happen?"
|
|
// a question nobody has to answer inline.
|
|
type MediaIntentLedger interface {
|
|
// RecordPendingMediaObject upserts the intent row. ok=false means the
|
|
// key has left 'pending' (the reconciler owns it) — the caller must skip
|
|
// the upload entirely rather than resurrect the row.
|
|
RecordPendingMediaObject(ctx context.Context, p RecordPendingMediaObjectParams) (ok bool, err error)
|
|
}
|
|
|
|
// RecordPendingMediaObjectParams identifies one intended object. StorageURL
|
|
// is the URL the attachment row will carry (pure function of the key), so
|
|
// the reconciler can check for a durable reference. InstallationID is an
|
|
// ops-diagnostic only.
|
|
type RecordPendingMediaObjectParams struct {
|
|
StorageKey string
|
|
WorkspaceID pgtype.UUID
|
|
ChatMessageID pgtype.UUID
|
|
StorageURL string
|
|
InstallationID pgtype.UUID
|
|
}
|
|
|
|
// NewDBMediaIntentLedger adapts *db.Queries to MediaIntentLedger.
|
|
func NewDBMediaIntentLedger(q *db.Queries) MediaIntentLedger {
|
|
return dbMediaIntentLedger{q: q}
|
|
}
|
|
|
|
type dbMediaIntentLedger struct{ q *db.Queries }
|
|
|
|
func (l dbMediaIntentLedger) RecordPendingMediaObject(ctx context.Context, p RecordPendingMediaObjectParams) (bool, error) {
|
|
_, err := l.q.RecordChannelMediaPendingObject(ctx, db.RecordChannelMediaPendingObjectParams{
|
|
StorageKey: p.StorageKey,
|
|
WorkspaceID: p.WorkspaceID,
|
|
ChatMessageID: p.ChatMessageID,
|
|
StorageUrl: p.StorageURL,
|
|
InstallationID: p.InstallationID,
|
|
})
|
|
if errors.Is(err, pgx.ErrNoRows) {
|
|
// The state-guarded upsert matched a 'deleting' row: the reconciler
|
|
// owns this key and it must not be resurrected.
|
|
return false, nil
|
|
}
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
return true, nil
|
|
}
|
|
|
|
// Auditor records a dropped inbound event (no message body — drop-audit
|
|
// policy). instID may be the zero UUID for installation-less events.
|
|
type Auditor interface {
|
|
RecordDrop(ctx context.Context, instID pgtype.UUID, msg channel.InboundMessage, reason DropReason) error
|
|
}
|
|
|
|
// OutboundReplier delivers the verdict-driven reply (binding prompt, offline /
|
|
// archived notice, /issue confirmation). Optional; nil disables outbound
|
|
// replies. Driven off the ACK critical path by the Router.
|
|
type OutboundReplier interface {
|
|
Reply(ctx context.Context, inst ResolvedInstallation, msg channel.InboundMessage, res Result)
|
|
}
|
|
|
|
// TypingNotifier shows a "processing" indicator when a message is ingested and
|
|
// clears it once the message reaches a terminal outcome. Optional; nil disables
|
|
// it.
|
|
type TypingNotifier interface {
|
|
// OnIngested shows the indicator for a successfully ingested message.
|
|
OnIngested(ctx context.Context, inst ResolvedInstallation, msg channel.InboundMessage, sessionID pgtype.UUID)
|
|
// OnSettled clears the indicator for a session whose run trigger produced no
|
|
// task (agent offline / archived, or an enqueue failure). In that case no
|
|
// task lifecycle event is ever published, so the platform's own bus-driven
|
|
// clear (on chat-done / task-failed) would never fire and the indicator would
|
|
// stick. The Router calls this from the debounced flush. Idempotent: a
|
|
// session with no indicator is a no-op.
|
|
OnSettled(ctx context.Context, sessionID pgtype.UUID)
|
|
}
|
|
|
|
// ResolverSet is the per-platform bundle the Router runs the pipeline through.
|
|
// Installation/Identity/Dedup/Session/Audit are required; Replier/Typing are
|
|
// optional. OriginType is the issue.origin_type label written for /issue
|
|
// commands from this channel (Feishu: "lark_chat").
|
|
type ResolverSet struct {
|
|
Installation InstallationResolver
|
|
Identity IdentityResolver
|
|
Dedup Deduper
|
|
Session SessionBinder
|
|
Media MediaResolver
|
|
Audit Auditor
|
|
Replier OutboundReplier
|
|
Typing TypingNotifier
|
|
OriginType string
|
|
}
|
|
|
|
// IssueCreator is the narrow subset of service.IssueService the Router needs
|
|
// for the /issue command. Shared across platforms.
|
|
type IssueCreator interface {
|
|
Create(ctx context.Context, p service.IssueCreateParams, opts service.IssueCreateOpts) (service.IssueCreateResult, error)
|
|
}
|
|
|
|
// TaskEnqueuer is the narrow subset of service.TaskService the Router needs to
|
|
// trigger a chat run. Shared across platforms.
|
|
type TaskEnqueuer interface {
|
|
EnqueueChatTask(ctx context.Context, session db.ChatSession, initiatorUserID pgtype.UUID, forceFreshSession bool) (db.AgentTaskQueue, error)
|
|
PromoteChannelChatTasksIfMediaReady(ctx context.Context, sessionID pgtype.UUID) error
|
|
}
|
|
|
|
// SessionReader reads the rows the debounced flush + /issue identifier need.
|
|
// Shared across platforms; backed by *db.Queries (the channel-backed store).
|
|
type SessionReader interface {
|
|
GetChatSession(ctx context.Context, id pgtype.UUID) (db.ChatSession, error)
|
|
GetWorkspace(ctx context.Context, id pgtype.UUID) (db.Workspace, error)
|
|
}
|