mirror of
https://github.com/multica-ai/multica.git
synced 2026-07-05 13:29:44 +02:00
d6e7824ff1
* feat(feedback): add in-app feedback flow and Help launcher Replaces the duplicated bottom-sidebar user popover and "What's new" links with a single Help menu (Docs / Feedback / Change log) pinned to the sidebar footer. Feedback opens a rich-text modal that POSTs to a new /api/feedback endpoint; submissions land in a dedicated feedback table with per-user hourly rate limiting (10/hr) to deter spam without adding middleware infrastructure. User identity (avatar + name + email) moves into the workspace dropdown header so the sidebar is no longer visually redundant. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(feedback): harden submit path and cap request body - Read editor markdown via ref at submit time instead of debounced state, so ⌘+Enter immediately after typing doesn't drop the last keystrokes. - Block submission while images are still uploading; toast prompts the user to wait instead of silently sending markdown with blob: URLs that get stripped. - Cap /api/feedback request body at 64 KiB via MaxBytesReader so an authenticated client can't bloat the metadata JSONB column with an oversized url field. - Add Go handler tests covering happy path, empty-message rejection, and the hourly rate limit boundary. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * feat(analytics): instrument feedback funnel Adds two events pairing frontend intent with backend conversion so we can compute a completion rate for the in-app Feedback modal: - `feedback_opened` (frontend) — fires once on FeedbackModal mount. Source is currently always "help_menu" but the type is a union so future entry points have to extend it explicitly. Workspace id is attached when present. - `feedback_submitted` (backend) — fires from CreateFeedback after the DB insert succeeds and the hourly rate-limit check has passed. Message content itself is never sent to PostHog; the event carries a coarse length bucket (0-100 / 100-500 / 500-2000 / 2000+), an image-presence flag, and the client platform / version pulled from X-Client-* headers via middleware.ClientMetadataFromContext. Affects no existing funnel; seeds a new Feedback funnel for product triage. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
76 lines
2.3 KiB
Go
76 lines
2.3 KiB
Go
package handler
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strconv"
|
|
"testing"
|
|
)
|
|
|
|
func TestCreateFeedbackHappyPath(t *testing.T) {
|
|
clearFeedbackForTestUser(t)
|
|
|
|
req := newRequest("POST", "/api/feedback", CreateFeedbackRequest{
|
|
Message: "Love the product, dark mode flashes on startup",
|
|
})
|
|
w := httptest.NewRecorder()
|
|
testHandler.CreateFeedback(w, req)
|
|
|
|
if w.Code != http.StatusCreated {
|
|
t.Fatalf("expected 201, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
var resp FeedbackResponse
|
|
if err := json.NewDecoder(w.Body).Decode(&resp); err != nil {
|
|
t.Fatalf("decode response: %v", err)
|
|
}
|
|
if resp.ID == "" {
|
|
t.Fatal("expected feedback id in response")
|
|
}
|
|
}
|
|
|
|
func TestCreateFeedbackEmptyMessage(t *testing.T) {
|
|
req := newRequest("POST", "/api/feedback", CreateFeedbackRequest{Message: " "})
|
|
w := httptest.NewRecorder()
|
|
testHandler.CreateFeedback(w, req)
|
|
if w.Code != http.StatusBadRequest {
|
|
t.Fatalf("expected 400, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestCreateFeedbackRateLimit(t *testing.T) {
|
|
clearFeedbackForTestUser(t)
|
|
|
|
for i := 0; i < feedbackHourlyRateLimit; i++ {
|
|
req := newRequest("POST", "/api/feedback", CreateFeedbackRequest{
|
|
Message: "feedback #" + strconv.Itoa(i),
|
|
})
|
|
w := httptest.NewRecorder()
|
|
testHandler.CreateFeedback(w, req)
|
|
if w.Code != http.StatusCreated {
|
|
t.Fatalf("iteration %d: expected 201, got %d: %s", i, w.Code, w.Body.String())
|
|
}
|
|
}
|
|
req := newRequest("POST", "/api/feedback", CreateFeedbackRequest{Message: "one too many"})
|
|
w := httptest.NewRecorder()
|
|
testHandler.CreateFeedback(w, req)
|
|
if w.Code != http.StatusTooManyRequests {
|
|
t.Fatalf("expected 429, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
}
|
|
|
|
// clearFeedbackForTestUser wipes all feedback rows for the shared test user
|
|
// at both test start (fresh state) and test end (via t.Cleanup), so tests
|
|
// in this file don't interfere with each other or with the hourly rate-limit
|
|
// window when run in sequence.
|
|
func clearFeedbackForTestUser(t *testing.T) {
|
|
t.Helper()
|
|
if _, err := testPool.Exec(context.Background(), `DELETE FROM feedback WHERE user_id = $1`, parseUUID(testUserID)); err != nil {
|
|
t.Fatalf("clear feedback: %v", err)
|
|
}
|
|
t.Cleanup(func() {
|
|
testPool.Exec(context.Background(), `DELETE FROM feedback WHERE user_id = $1`, parseUUID(testUserID))
|
|
})
|
|
}
|