mirror of
https://github.com/multica-ai/multica.git
synced 2026-06-17 11:48:42 +02:00
* docs(timezone): add scheduling/viewing timezone architecture RFC * feat(db): replace daily rollups with task_usage_hourly, add user.timezone Migrations 100-104: add "user".timezone (Viewing tz), build the UTC hourly task_usage_hourly rollup with its pipeline, drop the legacy task_usage_daily / task_usage_dashboard_daily pipelines, and drop the agent_runtime.timezone column. Report queries now slice day boundaries at read time by the caller-supplied @tz instead of materialising in a fixed tz. Regenerate sqlc. * feat(server): add task_usage_hourly backfill command Replace the two legacy backfill commands (daily / dashboard_daily) with a single backfill_task_usage_hourly that loads historical task_usage into the new UTC hourly rollup, sliced per workspace. * refactor(server): resolve viewing timezone in report handlers Report handlers resolve the Viewing tz per request (?tz query param, then user.timezone, then UTC) and pass it to the hourly-rollup queries. Drop the UseDailyRollup feature flags and the old raw-scan/daily-rollup dual paths, remove the /api/usage endpoints, and stop the daemon from reporting and the runtime handler from accepting host timezone. * refactor(core): switch report queries to viewing timezone API client and dashboard/runtime queries send ?tz with each report request, the user schema/types carry the new timezone field, and the runtime timezone field/mutation is removed. * feat(views): add viewing timezone preference and UI Add the useViewingTimezone hook and a Timezone setting in Preferences; report charts and the dashboard week boundary follow the viewer tz. Remove the runtime detail timezone editor and its locale strings. * fix(test): update fixtures and stabilize tests for timezone refactor The timezone architecture refactor changed several types without updating dependent test code: - RuntimeDevice no longer has a timezone field — drop it from the create-agent-dialog runtime fixture. - User now requires a timezone field — add it to the apps/web mockUser fixture. - The PreferencesTab timezone tests asserted on the async save handler (PATCH then store update) with a bare expect, racing the mutation's settle callback, and timed out querying the Select's ~600-option IANA list on a loaded CI runner. Wrap the assertions in waitFor and extend the timeout for those three tests. * docs(timezone): document self-host migration order and trigger invariant Add a SELF-HOST UPGRADE ORDER runbook to the backfill command's package comment: applying migrations 100-104 in a single migrate-up drops the legacy daily rollups before the hourly backfill runs, leaving dashboards empty until cron catches up. Add an INVARIANT comment on trg_atq_dirty_hourly noting that agent_id must be added to the trigger's OF list if it ever becomes mutable, otherwise dirty buckets for the old agent_id are silently missed. * style(runtimes): drop trailing blank line in runtime-detail
150 lines
4.3 KiB
Go
150 lines
4.3 KiB
Go
package handler
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"net/http/httptest"
|
|
"testing"
|
|
)
|
|
|
|
func newTimezoneTestUser(t *testing.T, email string) string {
|
|
t.Helper()
|
|
ctx := context.Background()
|
|
|
|
var userID string
|
|
if err := testPool.QueryRow(ctx,
|
|
`INSERT INTO "user" (name, email) VALUES ($1, $2) RETURNING id`,
|
|
"Timezone Test", email,
|
|
).Scan(&userID); err != nil {
|
|
t.Fatalf("insert test user: %v", err)
|
|
}
|
|
t.Cleanup(func() {
|
|
testPool.Exec(ctx, `DELETE FROM "user" WHERE id = $1`, userID)
|
|
})
|
|
return userID
|
|
}
|
|
|
|
func TestUpdateMeAcceptsTimezone(t *testing.T) {
|
|
userID := newTimezoneTestUser(t, "tz-set@multica.ai")
|
|
|
|
w := httptest.NewRecorder()
|
|
req := newPatchMeRequest(userID, `{"timezone":"Asia/Shanghai"}`)
|
|
testHandler.UpdateMe(w, req)
|
|
|
|
if w.Code != 200 {
|
|
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
|
|
var stored *string
|
|
if err := testPool.QueryRow(context.Background(),
|
|
`SELECT timezone FROM "user" WHERE id = $1`, userID,
|
|
).Scan(&stored); err != nil {
|
|
t.Fatalf("lookup user: %v", err)
|
|
}
|
|
if stored == nil || *stored != "Asia/Shanghai" {
|
|
t.Fatalf("expected timezone=Asia/Shanghai, got %v", stored)
|
|
}
|
|
|
|
var resp map[string]any
|
|
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("decode response: %v", err)
|
|
}
|
|
if got, _ := resp["timezone"].(string); got != "Asia/Shanghai" {
|
|
t.Fatalf("expected response timezone=Asia/Shanghai, got %v", resp["timezone"])
|
|
}
|
|
}
|
|
|
|
func TestUpdateMeRejectsInvalidTimezone(t *testing.T) {
|
|
userID := newTimezoneTestUser(t, "tz-reject@multica.ai")
|
|
|
|
w := httptest.NewRecorder()
|
|
req := newPatchMeRequest(userID, `{"timezone":"Not/A/Real/Zone"}`)
|
|
testHandler.UpdateMe(w, req)
|
|
|
|
if w.Code != 400 {
|
|
t.Fatalf("expected 400, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
|
|
var stored *string
|
|
if err := testPool.QueryRow(context.Background(),
|
|
`SELECT timezone FROM "user" WHERE id = $1`, userID,
|
|
).Scan(&stored); err != nil {
|
|
t.Fatalf("lookup user: %v", err)
|
|
}
|
|
if stored != nil {
|
|
t.Fatalf("expected timezone unchanged (NULL), got %v", *stored)
|
|
}
|
|
}
|
|
|
|
// COALESCE semantics — omitting timezone must NOT clear an existing value.
|
|
func TestUpdateMePreservesTimezoneWhenNotProvided(t *testing.T) {
|
|
userID := newTimezoneTestUser(t, "tz-preserve@multica.ai")
|
|
|
|
if _, err := testPool.Exec(context.Background(),
|
|
`UPDATE "user" SET timezone = 'America/Los_Angeles' WHERE id = $1`, userID,
|
|
); err != nil {
|
|
t.Fatalf("preset timezone: %v", err)
|
|
}
|
|
|
|
w := httptest.NewRecorder()
|
|
req := newPatchMeRequest(userID, `{"name":"Updated Name"}`)
|
|
testHandler.UpdateMe(w, req)
|
|
|
|
if w.Code != 200 {
|
|
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
|
|
var stored *string
|
|
if err := testPool.QueryRow(context.Background(),
|
|
`SELECT timezone FROM "user" WHERE id = $1`, userID,
|
|
).Scan(&stored); err != nil {
|
|
t.Fatalf("lookup user: %v", err)
|
|
}
|
|
if stored == nil || *stored != "America/Los_Angeles" {
|
|
t.Fatalf("expected timezone preserved, got %v", stored)
|
|
}
|
|
}
|
|
|
|
// Explicit clear: `"timezone": ""` should NULL the column so the frontend
|
|
// falls back to the browser-detected tz again. Without the CASE branch in
|
|
// the UPDATE query this would either be a no-op (COALESCE) or a validation
|
|
// error.
|
|
func TestUpdateMeClearsTimezoneOnEmptyString(t *testing.T) {
|
|
userID := newTimezoneTestUser(t, "tz-clear@multica.ai")
|
|
|
|
if _, err := testPool.Exec(context.Background(),
|
|
`UPDATE "user" SET timezone = 'Asia/Shanghai' WHERE id = $1`, userID,
|
|
); err != nil {
|
|
t.Fatalf("preset timezone: %v", err)
|
|
}
|
|
|
|
w := httptest.NewRecorder()
|
|
req := newPatchMeRequest(userID, `{"timezone":""}`)
|
|
testHandler.UpdateMe(w, req)
|
|
|
|
if w.Code != 200 {
|
|
t.Fatalf("expected 200, got %d: %s", w.Code, w.Body.String())
|
|
}
|
|
|
|
var stored *string
|
|
if err := testPool.QueryRow(context.Background(),
|
|
`SELECT timezone FROM "user" WHERE id = $1`, userID,
|
|
).Scan(&stored); err != nil {
|
|
t.Fatalf("lookup user: %v", err)
|
|
}
|
|
if stored != nil {
|
|
t.Fatalf("expected timezone cleared to NULL, got %v", *stored)
|
|
}
|
|
|
|
var resp map[string]any
|
|
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
|
|
t.Fatalf("decode response: %v", err)
|
|
}
|
|
// JSON null marshals from *string nil — confirm the response reflects
|
|
// the cleared state, so the frontend can switch its picker back to
|
|
// "(browser)" without a refetch.
|
|
if resp["timezone"] != nil {
|
|
t.Fatalf("expected response timezone=null, got %v", resp["timezone"])
|
|
}
|
|
}
|