highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-11 21:20:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

fuzz: Fix assertion in txorphan

Browse Source 
EraseTx calls LimitOrphans, which may evict announcements from a peer
that didn't announce the erased transaction, causing that peer's usage
to decrease. Relax the assertion in the EraseTx branch that claimed
usage of a non-announcer peer is unchanged. Also, add assertions for
the other cases.
This commit is contained in:
marcofleon
2026-08-11 17:05:34 +01:00
parent dec68f997e
commit 01dde6b205
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/fuzz/txorphan.cpp
View File

@@ -173,11 +173,13 @@ FUZZ_TARGET(txorphan, .init = initialize_orphanage)
{
auto bytes_from_peer_before{orphanage->UsageByPeer(peer_id)};
Assert(have_tx == orphanage->EraseTx(tx->GetWitnessHash()));
// After EraseTx, the orphanage may trim itself, so all peers' usage may have gone up or down.
if (have_tx) {
if (!have_tx_and_peer) {
Assert(orphanage->UsageByPeer(peer_id) == bytes_from_peer_before);
}
// After EraseTx, the orphanage may trim itself, so any peer's usage may decrease.
if (!have_tx) {
Assert(orphanage->UsageByPeer(peer_id) == bytes_from_peer_before);
} else if (have_tx_and_peer) {
Assert(orphanage->UsageByPeer(peer_id) <= bytes_from_peer_before - tx_weight);
} else {
Assert(orphanage->UsageByPeer(peer_id) <= bytes_from_peer_before);
}
}
have_tx = orphanage->HaveTx(tx->GetWitnessHash());