highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-02 01:04:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: Fixes send_blocks_and_test docs

Browse Source 
It's not true that if success=False the tip doesn't advance. It doesn'test
advance to the provided tip, but it can advance to a competing one
This commit is contained in:
Sergi Delgado Segura
2025-06-20 10:56:26 -04:00
parent 09c95f21e7
commit 0465574c12
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/functional/test_framework/p2p.py
View File

@@ -866,8 +866,8 @@ class P2PDataStore(P2PInterface):
- the on_getheaders handler will ensure that any getheaders are responded to
- if force_send is False: wait for getdata for each of the blocks. The on_getdata handler will
ensure that any getdata messages are responded to. Otherwise send the full block unsolicited.
- if success is True: assert that the node's tip advances to the most recent block
- if success is False: assert that the node's tip doesn't advance
- if success is True: assert that the node's tip is the last block in blocks at the end of the operation.
- if success is False: assert that the node's tip isn't the last block in blocks at the end of the operation
- if reject_reason is set: assert that the correct reject message is logged"""
with p2p_lock: