mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-08-29 23:41:11 +02:00
test: Verify parent_desc in RPCs
getaddressinfo, listunspent, listtransactions, listsinceblock, and gettransaction all include parent_desc(s). Make sure that these are consistent with each other, as well as being in normalized form.
This commit is contained in:
@@ -9,6 +9,8 @@ try:
|
|||||||
except ImportError:
|
except ImportError:
|
||||||
pass
|
pass
|
||||||
|
|
||||||
|
import re
|
||||||
|
|
||||||
from test_framework.blocktools import COINBASE_MATURITY
|
from test_framework.blocktools import COINBASE_MATURITY
|
||||||
from test_framework.test_framework import BitcoinTestFramework
|
from test_framework.test_framework import BitcoinTestFramework
|
||||||
from test_framework.util import (
|
from test_framework.util import (
|
||||||
@@ -29,6 +31,54 @@ class WalletDescriptorTest(BitcoinTestFramework):
|
|||||||
self.skip_if_no_wallet()
|
self.skip_if_no_wallet()
|
||||||
self.skip_if_no_py_sqlite3()
|
self.skip_if_no_py_sqlite3()
|
||||||
|
|
||||||
|
def test_parent_descriptors(self):
|
||||||
|
self.log.info("Check that parent_descs is the same for all RPCs and is normalized")
|
||||||
|
self.nodes[0].createwallet(wallet_name="parent_descs")
|
||||||
|
wallet = self.nodes[0].get_wallet_rpc("parent_descs")
|
||||||
|
default_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
|
||||||
|
|
||||||
|
addr = wallet.getnewaddress()
|
||||||
|
parent_desc = wallet.getaddressinfo(addr)["parent_desc"]
|
||||||
|
|
||||||
|
# Verify that the parent descriptor is normalized
|
||||||
|
# First remove the checksum
|
||||||
|
desc_verify = parent_desc.split("#")[0]
|
||||||
|
# Next extract the xpub
|
||||||
|
desc_verify = re.sub(r"tpub\w+?(?=/)", "", desc_verify)
|
||||||
|
# Extract origin info
|
||||||
|
origin_match = re.search(r'\[([\da-fh/]+)\]', desc_verify)
|
||||||
|
origin_part = origin_match.group(1) if origin_match else ""
|
||||||
|
# Split on "]" for everything after the origin info
|
||||||
|
after_origin = desc_verify.split("]", maxsplit=1)[-1]
|
||||||
|
# Look for the hardened markers “h” inside each piece
|
||||||
|
# We don't need to check for aspostrophe as normalization will not output aspostrophe
|
||||||
|
found_hardened_in_origin = "h" in origin_part
|
||||||
|
found_hardened_after_origin = "h" in after_origin
|
||||||
|
assert_equal(found_hardened_in_origin, True)
|
||||||
|
assert_equal(found_hardened_after_origin, False)
|
||||||
|
|
||||||
|
# Send some coins so we can check listunspent, listtransactions, listunspent, and gettransaction
|
||||||
|
since_block = self.nodes[0].getbestblockhash()
|
||||||
|
txid = default_wallet.sendtoaddress(addr, 1)
|
||||||
|
self.generate(self.nodes[0], 1)
|
||||||
|
|
||||||
|
unspent = wallet.listunspent()
|
||||||
|
assert_equal(len(unspent), 1)
|
||||||
|
assert_equal(unspent[0]["parent_descs"], [parent_desc])
|
||||||
|
|
||||||
|
txs = wallet.listtransactions()
|
||||||
|
assert_equal(len(txs), 1)
|
||||||
|
assert_equal(txs[0]["parent_descs"], [parent_desc])
|
||||||
|
|
||||||
|
txs = wallet.listsinceblock(since_block)["transactions"]
|
||||||
|
assert_equal(len(txs), 1)
|
||||||
|
assert_equal(txs[0]["parent_descs"], [parent_desc])
|
||||||
|
|
||||||
|
tx = wallet.gettransaction(txid=txid, verbose=True)
|
||||||
|
assert_equal(tx["details"][0]["parent_descs"], [parent_desc])
|
||||||
|
|
||||||
|
wallet.unloadwallet()
|
||||||
|
|
||||||
def run_test(self):
|
def run_test(self):
|
||||||
self.generate(self.nodes[0], COINBASE_MATURITY + 1)
|
self.generate(self.nodes[0], COINBASE_MATURITY + 1)
|
||||||
|
|
||||||
@@ -218,6 +268,7 @@ class WalletDescriptorTest(BitcoinTestFramework):
|
|||||||
conn.close()
|
conn.close()
|
||||||
assert_raises_rpc_error(-4, "Unexpected legacy entry in descriptor wallet found.", self.nodes[0].loadwallet, "crashme")
|
assert_raises_rpc_error(-4, "Unexpected legacy entry in descriptor wallet found.", self.nodes[0].loadwallet, "crashme")
|
||||||
|
|
||||||
|
self.test_parent_descriptors()
|
||||||
|
|
||||||
if __name__ == '__main__':
|
if __name__ == '__main__':
|
||||||
WalletDescriptorTest(__file__).main()
|
WalletDescriptorTest(__file__).main()
|
||||||
|
Reference in New Issue
Block a user