highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-06 13:47:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#34891: doc: Note that generateblock does not collect transaction fees

Browse Source 
3136559923 doc: Note that generateblock does not collect transaction fees (HouseOfHufflepuff)

Pull request description:

  ## Summary

  - Add a note to the `generateblock` RPC help text clarifying that transaction fees are not collected in the block reward
  - This was suggested by maflcko in #31684 as a minimal doc fix

  refs #31684

  ## Test plan

  - [x] `./build/bin/test_bitcoin --run_test=rpc_tests` passes
  - [x] `cmake --build build --target bitcoind` compiles cleanly

ACKs for top commit:
  maflcko:
    lgtm ACK 3136559923
  sedited:
    ACK 3136559923

Tree-SHA512: 173e6ac2a08c5101794a21bf29ec01af834fe2ef177b46be9f46b0c545b8888a9deb816caed868ff917105cbd97e57152682dcd4d4fe47dd92ac14a83bbf5d03
This commit is contained in:
merge-script
2026-03-24 21:41:03 +01:00
parent 4ecf473c36 3136559923
commit 1ef7166029
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/rpc/mining.cpp
View File

@@ -305,7 +305,8 @@ static RPCHelpMan generatetoaddress()
static RPCHelpMan generateblock()
{
return RPCHelpMan{"generateblock",
"Mine a set of ordered transactions to a specified address or descriptor and return the block hash.",
"Mine a set of ordered transactions to a specified address or descriptor and return the block hash.\n"
"Transaction fees are not collected in the block reward.",
{
{"output", RPCArg::Type::STR, RPCArg::Optional::NO, "The address or descriptor to send the newly generated bitcoin to."},
{"transactions", RPCArg::Type::ARR, RPCArg::Optional::NO, "An array of hex strings which are either txids or raw transactions.\n"