highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-07-23 22:58:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

argsman: Prevent duplicate option registration across categories

Browse Source 
Added a validation in AddArg() preventing the same option name from
being registered across different categories, avoiding ambiguous option
resolution and make the distinction between global and command-specific
options explicit.
This commit is contained in:
Pablo Martin
2026-06-05 16:36:17 -03:00
parent 47da4f9b71
commit 32df86f1d8
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/args.cpp
View File

@@ -668,6 +668,11 @@ void ArgsManager::AddArg(const std::string& name, const std::string& help, unsig
std::string arg_name = name.substr(0, eq_index);
LOCK(cs_args);
for (const auto& arg_map : m_available_args) {
Assert(!arg_map.second.contains(arg_name));
}
std::map<std::string, Arg>& arg_map = m_available_args[cat];
auto ret = arg_map.emplace(arg_name, Arg{name.substr(eq_index, name.size() - eq_index), help, flags});
assert(ret.second); // Make sure an insertion actually happened