highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-07-23 22:58:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

fuzz: connman: add AddNode/RemoveAddedNode invariants

Browse Source 
Co-authored-by: frankomosh <frankomosh197@gmail.com>
This commit is contained in:
Bruno Garcia
2026-04-29 10:30:13 -03:00
parent a5859edef4
commit 4a6fce43ea
1 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/test/fuzz/connman.cpp
View File

@@ -107,6 +107,7 @@ FUZZ_TARGET(connman, .init = initialize_connman)
CSubNet random_subnet;
std::string random_string;
std::vector<NodeId> node_ids;
std::vector<std::string> node_addr_names;
LIMITED_WHILE(fuzzed_data_provider.ConsumeBool(), 100) {
CNode& p2p_node{*ConsumeNodeAsUniquePtr(fuzzed_data_provider).release()};
@@ -114,6 +115,7 @@ FUZZ_TARGET(connman, .init = initialize_connman)
p2p_node.fSuccessfullyConnected = true;
connman.AddTestNode(p2p_node);
node_ids.push_back(p2p_node.GetId());
node_addr_names.push_back(p2p_node.m_addr_name);
}
LIMITED_WHILE(fuzzed_data_provider.ConsumeBool(), 10000) {
@@ -132,7 +134,23 @@ FUZZ_TARGET(connman, .init = initialize_connman)
random_string = fuzzed_data_provider.ConsumeRandomLengthString(64);
},
[&] {
connman.AddNode({random_string, fuzzed_data_provider.ConsumeBool()});
const std::string& node_str = (!node_addr_names.empty() && fuzzed_data_provider.ConsumeBool())
? PickValue(fuzzed_data_provider, node_addr_names)
: random_string;
const auto added_node_info{connman.GetAddedNodeInfo(/*include_connected=*/true)};
const auto add_node{connman.AddNode({node_str, /*use_v2transport=*/fuzzed_data_provider.ConsumeBool()})};
if (add_node) {
assert(!connman.AddNode({node_str, /*use_v2transport=*/fuzzed_data_provider.ConsumeBool()}));
assert(added_node_info.size() < connman.GetAddedNodeInfo(/*include_connected=*/true).size());
const auto remove{fuzzed_data_provider.ConsumeBool()};
if (remove) {
assert(connman.RemoveAddedNode(node_str));
assert(added_node_info.size() == connman.GetAddedNodeInfo(/*include_connected=*/true).size());
}
}
},
[&] {
(void)connman.RemoveAddedNode(random_string);
},
[&] {
connman.CheckIncomingNonce(fuzzed_data_provider.ConsumeIntegral<uint64_t>());
@@ -186,9 +204,6 @@ FUZZ_TARGET(connman, .init = initialize_connman)
serialized_net_msg.data = ConsumeRandomLengthByteVector(fuzzed_data_provider);
connman.PushMessage(&random_node, std::move(serialized_net_msg));
},
[&] {
connman.RemoveAddedNode(random_string);
},
[&] {
const auto set_active{fuzzed_data_provider.ConsumeBool()};
connman.SetNetworkActive(set_active);
@@ -250,7 +265,7 @@ FUZZ_TARGET(connman, .init = initialize_connman)
(void)pnode->IsFullOutboundConn();
(void)pnode->ConnectionTypeAsString();
});
(void)connman.GetAddedNodeInfo(fuzzed_data_provider.ConsumeBool());
(void)connman.GetAddedNodeInfo(/*include_connected=*/false);
(void)connman.GetExtraFullOutboundCount();
assert(connman.GetLocalServices() == local_services);
assert(connman.GetMaxOutboundTarget() == max_outbound_limit);