Merge bitcoin/bitcoin#31836: contrib: Add deterministic-fuzz-coverage

fa3e409c9a084112fc2644a2bba9aa196bdb229d contrib: Add deterministic-fuzz-coverage (MarcoFalke)

Pull request description:

  The goal of this script is to detect and debug the remaining fuzz determinism and stability issues (https://github.com/bitcoin/bitcoin/issues/29018).

ACKs for top commit:
  marcofleon:
    Tested ACK fa3e409c9a084112fc2644a2bba9aa196bdb229d
  brunoerg:
    tested ACK fa3e409c9a084112fc2644a2bba9aa196bdb229d

Tree-SHA512: f336537d64188d6bc3c53880f4552a09cc498841c539cb7b4f14e622c9542531b970c1a6910981f7506e7bf659d2ce83471d58f5f51b0a411868f4c11eaf6b2a

contrib/devtools/README.md

@@ -2,6 +2,26 @@ Contents
 ========
 This directory contains tools for developers working on this repository.
 
+deterministic-fuzz-coverage
+===========================
+
+A tool to check for non-determinism in fuzz coverage. To get the help, run:
+
+```
+RUST_BACKTRACE=1 cargo run --manifest-path ./contrib/devtools/deterministic-fuzz-coverage/Cargo.toml -- --help
+```
+
+To execute the tool, compilation has to be done with the build options
+`-DCMAKE_C_COMPILER='clang' -DCMAKE_CXX_COMPILER='clang++'
+-DBUILD_FOR_FUZZING=ON -DCMAKE_CXX_FLAGS='-fPIC -fprofile-instr-generate
+-fcoverage-mapping'`. Both llvm-profdata and llvm-cov must be installed. Also,
+the qa-assets repository must have been cloned. Finally, a fuzz target has to
+be picked before running the tool:
+
+```
+RUST_BACKTRACE=1 cargo run --manifest-path ./contrib/devtools/deterministic-fuzz-coverage/Cargo.toml -- $PWD/build_dir $PWD/qa-assets/corpora-dir fuzz_target_name
+```
+
 clang-format-diff.py
 ===================
 

contrib/devtools/deterministic-fuzz-coverage/Cargo.toml

@@ -0,0 +1,6 @@
+[package]
+name = "deterministic-fuzz-coverage"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]

contrib/devtools/deterministic-fuzz-coverage/src/main.rs

@@ -0,0 +1,206 @@
+// Copyright (c) The Bitcoin Core developers
+// Distributed under the MIT software license, see the accompanying
+// file COPYING or https://opensource.org/license/mit/.
+
+use std::env;
+use std::fs::{read_dir, File};
+use std::path::Path;
+use std::process::{exit, Command, Stdio};
+use std::str;
+
+const LLVM_PROFDATA: &str = "llvm-profdata";
+const LLVM_COV: &str = "llvm-cov";
+const DIFF: &str = "diff";
+
+fn exit_help(err: &str) -> ! {
+    eprintln!("Error: {}", err);
+    eprintln!();
+    eprintln!("Usage: program ./build_dir ./qa-assets-corpora-dir fuzz_target");
+    eprintln!();
+    eprintln!("Refer to the devtools/README.md for more details.");
+    exit(1)
+}
+
+fn sanity_check(corpora_dir: &Path, fuzz_exe: &Path) {
+    for tool in [LLVM_PROFDATA, LLVM_COV, DIFF] {
+        let output = Command::new(tool).arg("--version").output();
+        match output {
+            Ok(output) if output.status.success() => {}
+            _ => {
+                exit_help(&format!("The tool {} is not installed", tool));
+            }
+        }
+    }
+    if !corpora_dir.is_dir() {
+        exit_help(&format!(
+            "Fuzz corpora path ({}) must be a directory",
+            corpora_dir.display()
+        ));
+    }
+    if !fuzz_exe.exists() {
+        exit_help(&format!(
+            "Fuzz executable ({}) not found",
+            fuzz_exe.display()
+        ));
+    }
+}
+
+fn main() {
+    // Parse args
+    let args = env::args().collect::<Vec<_>>();
+    let build_dir = args
+        .get(1)
+        .unwrap_or_else(|| exit_help("Must set build dir"));
+    if build_dir == "--help" {
+        exit_help("--help requested")
+    }
+    let corpora_dir = args
+        .get(2)
+        .unwrap_or_else(|| exit_help("Must set fuzz corpora dir"));
+    let fuzz_target = args
+        .get(3)
+        // Require fuzz target for now. In the future it could be optional and the tool could
+        // iterate over all compiled fuzz targets
+        .unwrap_or_else(|| exit_help("Must set fuzz target"));
+    if args.get(4).is_some() {
+        exit_help("Too many args")
+    }
+
+    let build_dir = Path::new(build_dir);
+    let corpora_dir = Path::new(corpora_dir);
+    let fuzz_exe = build_dir.join("src/test/fuzz/fuzz");
+
+    sanity_check(corpora_dir, &fuzz_exe);
+
+    deterministic_coverage(build_dir, corpora_dir, &fuzz_exe, fuzz_target);
+}
+
+fn using_libfuzzer(fuzz_exe: &Path) -> bool {
+    println!("Check if using libFuzzer ...");
+    let stderr = Command::new(fuzz_exe)
+        .arg("-help=1") // Will be interpreted as option (libfuzzer) or as input file
+        .env("FUZZ", "addition_overflow") // Any valid target
+        .output()
+        .expect("fuzz failed")
+        .stderr;
+    let help_output = str::from_utf8(&stderr).expect("The -help=1 output must be valid text");
+    help_output.contains("libFuzzer")
+}
+
+fn deterministic_coverage(
+    build_dir: &Path,
+    corpora_dir: &Path,
+    fuzz_exe: &Path,
+    fuzz_target: &str,
+) {
+    let using_libfuzzer = using_libfuzzer(fuzz_exe);
+    let profraw_file = build_dir.join("fuzz_det_cov.profraw");
+    let profdata_file = build_dir.join("fuzz_det_cov.profdata");
+    let corpus_dir = corpora_dir.join(fuzz_target);
+    let mut entries = read_dir(&corpus_dir)
+        .unwrap_or_else(|err| {
+            exit_help(&format!(
+                "The fuzz target's input directory must exist! ({}; {})",
+                corpus_dir.display(),
+                err
+            ))
+        })
+        .map(|entry| entry.expect("IO error"))
+        .collect::<Vec<_>>();
+    entries.sort_by_key(|entry| entry.file_name());
+    let run_single = |run_id: u8, entry: &Path| {
+        let cov_txt_path = build_dir.join(format!("fuzz_det_cov.show.{run_id}.txt"));
+        assert!({
+            {
+                let mut cmd = Command::new(fuzz_exe);
+                if using_libfuzzer {
+                    cmd.arg("-runs=1");
+                }
+                cmd
+            }
+            .env("LLVM_PROFILE_FILE", &profraw_file)
+            .env("FUZZ", fuzz_target)
+            .arg(entry)
+            .status()
+            .expect("fuzz failed")
+            .success()
+        });
+        assert!(Command::new(LLVM_PROFDATA)
+            .arg("merge")
+            .arg("--sparse")
+            .arg(&profraw_file)
+            .arg("-o")
+            .arg(&profdata_file)
+            .status()
+            .expect("merge failed")
+            .success());
+        let cov_file = File::create(&cov_txt_path).expect("Failed to create coverage txt file");
+        let passed = Command::new(LLVM_COV)
+            .args([
+                "show",
+                "--show-line-counts-or-regions",
+                "--show-branches=count",
+                "--show-expansions",
+                &format!("--instr-profile={}", profdata_file.display()),
+            ])
+            .arg(fuzz_exe)
+            .stdout(Stdio::from(cov_file))
+            .spawn()
+            .expect("Failed to execute llvm-cov")
+            .wait()
+            .expect("Failed to execute llvm-cov")
+            .success();
+        if !passed {
+            panic!("Failed to execute llvm-profdata")
+        }
+        cov_txt_path
+    };
+    let check_diff = |a: &Path, b: &Path, err: &str| {
+        let same = Command::new(DIFF)
+            .arg("--unified")
+            .arg(a)
+            .arg(b)
+            .status()
+            .expect("Failed to execute diff command")
+            .success();
+        if !same {
+            eprintln!();
+            eprintln!("The coverage was not determinstic between runs.");
+            eprintln!("{}", err);
+            eprintln!("Exiting.");
+            exit(1);
+        }
+    };
+    // First, check that each fuzz input is determinisic running by itself in a process.
+    //
+    // This can catch issues and isolate where a single fuzz input triggers non-determinism, but
+    // all other fuzz inputs are deterministic.
+    //
+    // Also, This can catch issues where several fuzz inputs are non-deterministic, but the sum of
+    // their overall coverage trace remains the same across runs and thus remains undetected.
+    for entry in entries {
+        let entry = entry.path();
+        assert!(entry.is_file());
+        let cov_txt_base = run_single(0, &entry);
+        let cov_txt_repeat = run_single(1, &entry);
+        check_diff(
+            &cov_txt_base,
+            &cov_txt_repeat,
+            &format!("The fuzz target input was {}.", entry.display()),
+        );
+    }
+    // Finally, check that running over all fuzz inputs in one process is deterministic as well.
+    // This can catch issues where mutable global state is leaked from one fuzz input execution to
+    // the next.
+    {
+        assert!(corpus_dir.is_dir());
+        let cov_txt_base = run_single(0, &corpus_dir);
+        let cov_txt_repeat = run_single(1, &corpus_dir);
+        check_diff(
+            &cov_txt_base,
+            &cov_txt_repeat,
+            &format!("All fuzz inputs in {} were used.", corpus_dir.display()),
+        );
+    }
+    println!("Coverage test passed for {fuzz_target}.");
+}