mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-11-25 05:20:01 +01:00
Merge bitcoin/bitcoin#32187: refactor: Remove spurious virtual from final ~CZMQNotificationInterface
fa69c42fdfrefactor: Remove spurious virtual from final ~CZMQNotificationInterface (MarcoFalke) Pull request description: `virtual` does not make sense here, because: * The class is `final`, thus the destructor isn't overridden in a derived class * The destructor also isn't overriding the destructor of the base, clarified in commit2b3ea39de4* Clang 21 may warn about this ``` src/zmq/zmqnotificationinterface.h:25:13: error: virtual method '~CZMQNotificationInterface' is inside a 'final' class and can never be overridden [-Werror,-Wunnecessary-virtual-specifier] 25 | virtual ~CZMQNotificationInterface(); | ^ ``` Fix all issues by removing it. ACKs for top commit: davidgumberg: crACKfa69c42fdfjanb84: ACK [fa69c42](fa69c42fdf) TheCharlatan: ACKfa69c42fdfTree-SHA512: 26ea977f31fe24c116d68dea6c583de7c6fc480877e1baefcde11db4ac191e352027d492ee6ad69a60fe4ff537e0841c638b3a3e81356d9e00c60030845fc96e
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
// Copyright (c) 2015-2022 The Bitcoin Core developers
|
||||
// Copyright (c) 2015-present The Bitcoin Core developers
|
||||
// Distributed under the MIT software license, see the accompanying
|
||||
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||
|
||||
@@ -22,7 +22,7 @@ struct NewMempoolTransactionInfo;
|
||||
class CZMQNotificationInterface final : public CValidationInterface
|
||||
{
|
||||
public:
|
||||
virtual ~CZMQNotificationInterface();
|
||||
~CZMQNotificationInterface();
|
||||
|
||||
std::list<const CZMQAbstractNotifier*> GetActiveNotifiers() const;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user