highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-11 21:20:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: cover legacy sigops count CHECKMULTISIG inaccurately

Browse Source
This commit is contained in:
ViniciusCestarii
2026-08-25 09:42:48 -03:00
parent a5fc82e2b1
commit 5ce3a0b4aa
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/test/transaction_tests.cpp
View File

@@ -1129,6 +1129,22 @@ BOOST_AUTO_TEST_CASE(max_standard_legacy_sigops)
}
}
BOOST_AUTO_TEST_CASE(getlegacysigopcount_inaccurate_test)
{
// Legacy sigops are counted inaccurately in both the scriptSig and the
// scriptPubKey: a CHECKMULTISIG counts as MAX_PUBKEYS_PER_MULTISIG even when the
// preceding OP_N says it takes fewer keys. Counting it accurately would
// undercount, letting a block over the sigop limit through.
const CScript multisig{CScript() << OP_1 << OP_CHECKMULTISIG};
CMutableTransaction mtx;
mtx.vin.emplace_back(COutPoint{}, multisig);
BOOST_CHECK_EQUAL(GetLegacySigOpCount(CTransaction{mtx}), MAX_PUBKEYS_PER_MULTISIG);
mtx.vout.emplace_back(0, multisig);
BOOST_CHECK_EQUAL(GetLegacySigOpCount(CTransaction{mtx}), 2 * MAX_PUBKEYS_PER_MULTISIG);
}
BOOST_AUTO_TEST_CASE(checktxinputs_invalid_transactions_test)
{
auto check_invalid{[](CAmount input_value, CAmount output_value, bool coinbase, int spend_height, TxValidationResult expected_result, std::string_view expected_reason) {