highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-02 09:15:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

lint: switch to ruff for formatting and linting

Browse Source 
- use dedicated ruff.toml for configuration
- download via docker image layer at build time
This commit is contained in:
will
2026-02-04 10:45:24 +00:00
parent a53b81ce4e
commit 5f4d3383da
4 changed files with 47 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ci/lint/01_install.sh
View File

@@ -32,8 +32,7 @@ python3 --version
uv pip install --python /python_env \
lief==0.17.5 \
mypy==1.19.1 \
pyzmq==27.1.0 \
ruff==0.15.5
pyzmq==27.1.0
SHELLCHECK_VERSION=v0.11.0
curl --fail -L "https://github.com/koalaman/shellcheck/releases/download/${SHELLCHECK_VERSION}/shellcheck-${SHELLCHECK_VERSION}.linux.$(uname --machine).tar.xz" | \

4
ci/lint_imagefile
View File

@@ -6,9 +6,11 @@
FROM mirror.gcr.io/ubuntu:24.04
# Pin uv to minor version to avoid breaking changes:
# Pin uv and ruff to minor version to avoid breaking changes
# https://docs.astral.sh/uv/reference/policies/versioning/
# https://docs.astral.sh/ruff/versioning/
COPY --from=ghcr.io/astral-sh/uv:0.10 /uv /uvx /bin/
COPY --from=ghcr.io/astral-sh/ruff:0.15 /ruff /bin/
COPY ./ci/retry/retry /ci_retry
COPY ./.python-version /.python-version

42
ruff.toml Normal file
View File

@@ -0,0 +1,42 @@
[lint]
select = [
"B006", # mutable-argument-default
"B008", # function-call-in-default-argument
"E101", # indentation contains mixed spaces and tabs
"E401", # multiple imports on one line
"E402", # module level import not at top of file
"E701", # multiple statements on one line (colon)
"E702", # multiple statements on one line (semicolon)
"E703", # statement ends with a semicolon
"E711", # comparison to None should be 'if cond is None:'
"E713", # test for membership should be "not in"
"E714", # test for object identity should be "is not"
"E721", # do not compare types, use "isinstance()"
"E722", # do not use bare 'except'
"E742", # do not define classes named "l", "O", or "I"
"E743", # do not define functions named "l", "O", or "I"
"F401", # module imported but unused
"F402", # import module from line N shadowed by loop variable
"F403", # 'from foo_module import *' used; unable to detect undefined names
"F404", # future import(s) name after other statements
"F405", # foo_function may be undefined, or defined from star imports: bar_module
"F406", # "from module import *" only allowed at module level
"F407", # an undefined __future__ feature name was imported
"F541", # f-string without any placeholders
"F601", # dictionary key name repeated with different values
"F602", # dictionary key variable name repeated with different values
"F621", # too many expressions in an assignment with star-unpacking
"F631", # assertion test is a tuple, which are always True
"F632", # use ==/!= to compare str, bytes, and int literals
"F811", # redefinition of unused name from line N
"F821", # undefined name 'Foo'
"F822", # undefined name name in __all__
"F823", # local variable name referenced before assignment
"F841", # local variable 'foo' is assigned to but never used
"PLE", # Pylint errors
"W191", # indentation contains tabs
"W291", # trailing whitespace
"W292", # no newline at end of file
"W293", # blank line contains whitespace
"W605", # invalid escape sequence "x"
]

47
test/lint/test_runner/src/lint_py.rs
View File

@@ -9,51 +9,6 @@ use crate::util::{check_output, get_pathspecs_default_excludes, git, LintResult}
pub fn lint_py_lint() -> LintResult {
let bin_name = "ruff";
let checks = format!(
"--select={}",
[
"B006", // mutable-argument-default
"B008", // function-call-in-default-argument
"E101", // indentation contains mixed spaces and tabs
"E401", // multiple imports on one line
"E402", // module level import not at top of file
"E701", // multiple statements on one line (colon)
"E702", // multiple statements on one line (semicolon)
"E703", // statement ends with a semicolon
"E711", // comparison to None should be 'if cond is None:'
"E713", // test for membership should be "not in"
"E714", // test for object identity should be "is not"
"E721", // do not compare types, use "isinstance()"
"E722", // do not use bare 'except'
"E742", // do not define classes named "l", "O", or "I"
"E743", // do not define functions named "l", "O", or "I"
"F401", // module imported but unused
"F402", // import module from line N shadowed by loop variable
"F403", // 'from foo_module import *' used; unable to detect undefined names
"F404", // future import(s) name after other statements
"F405", // foo_function may be undefined, or defined from star imports: bar_module
"F406", // "from module import *" only allowed at module level
"F407", // an undefined __future__ feature name was imported
"F541", // f-string without any placeholders
"F601", // dictionary key name repeated with different values
"F602", // dictionary key variable name repeated with different values
"F621", // too many expressions in an assignment with star-unpacking
"F631", // assertion test is a tuple, which are always True
"F632", // use ==/!= to compare str, bytes, and int literals
"F811", // redefinition of unused name from line N
"F821", // undefined name 'Foo'
"F822", // undefined name name in __all__
"F823", // local variable name … referenced before assignment
"F841", // local variable 'foo' is assigned to but never used
"PLE", // Pylint errors
"W191", // indentation contains tabs
"W291", // trailing whitespace
"W292", // no newline at end of file
"W293", // blank line contains whitespace
"W605", // invalid escape sequence "x"
]
.join(",")
);
let files = check_output(
git()
.args(["ls-files", "--", "*.py"])
@@ -61,7 +16,7 @@ pub fn lint_py_lint() -> LintResult {
)?;
let mut cmd = Command::new(bin_name);
cmd.args(["check", &checks]).args(files.lines());
cmd.arg("check").args(files.lines());
match cmd.status() {
Ok(status) if status.success() => Ok(()),