highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-16 18:39:59 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#32746: test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py

Browse Source 
206bc05e62 test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py (Sebastian Falbesoner)

Pull request description:

  The mentioned bug (issue #26245) has been fixed in PR #30666, so the workaround is not needed anymore.

ACKs for top commit:
  fjahr:
    ACK 206bc05e62
  janb84:
    ACK 206bc05e62
  mzumsande:
    utACK 206bc05e62

Tree-SHA512: 92ad6c09c80318a02e00d8c2a4ca1ec8a6caa6aa310916ff705871c91fe5c960c15ed394ead8ce9c7466b592dba176aa87a635b3228ddc93f57082124f04613f
This commit is contained in:
merge-script
2025-06-13 15:56:00 +01:00
parent 3e81684426 206bc05e62
commit 65b26507b8
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/functional/feature_assumeutxo.py
View File

@@ -484,12 +484,6 @@ class AssumeutxoTest(BitcoinTestFramework):
dump_output5 = n0.dumptxoutset('utxos5.dat', rollback=prev_snap_hash)
assert_equal(sha256sum_file(dump_output4['path']), sha256sum_file(dump_output5['path']))
# TODO: This is a hack to set m_best_header to the correct value after
# dumptxoutset/reconsiderblock. Otherwise the wrong error messages are
# returned in following tests. It can be removed once this bug is
# fixed. See also https://github.com/bitcoin/bitcoin/issues/26245
self.restart_node(0, ["-reindex"])
# Ensure n0 is back at the tip
assert_equal(n0.getblockchaininfo()["blocks"], FINAL_HEIGHT)