highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-03-28 02:32:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#24735: ci: use DWARF-4 for Valgrind jobs

Browse Source 
15893a07811e022bf9e774b831f8386df7ac52e5 supp: remove Boost Valgrind suppression (fanquake)
b0740fdcb84120b76b201e6d17859e9a398f93b4 ci: use DWARF-4 for Valgrind CI job (fanquake)

Pull request description:

  [clang-14 defaults to using DWARF-5](https://releases.llvm.org/14.0.0/tools/clang/docs/ReleaseNotes.html#dwarf-support-in-clang), which breaks vlagrinds (3.18) ability
  to parse debug info. Valgrind [claims to support DWARF-5](https://valgrind.org/docs/manual/dist.news.html) from version
  3.18 onwards, but maybe that only works when compiling with GCC.

  Explicitly use DWARF-4 for now. Note that from 11.0 [GCC also defaults to
  using DWARF-5](https://www.gnu.org/software/gcc/gcc-11/changes.html).

  Also remove a Boost related suppression.

Top commit has no ACKs.

Tree-SHA512: e4f476170ac5ccbb43d26e990b24753bda3985b2ac5c8a32e74d2d1d64d1b3a2d80a90fbab345f0a9e404eac7fbd783c20147379208e615d526657e8a57890ca
This commit is contained in:
MarcoFalke 2022-04-04 12:03:35 +02:00
commit 67dc002aae
No known key found for this signature in database
GPG Key ID: CE2B75697E69A548
3 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ci/test/00_setup_env_native_fuzz_with_valgrind.sh
View File

@ -15,5 +15,6 @@ export RUN_FUNCTIONAL_TESTS=false
export RUN_FUZZ_TESTS=true
export FUZZ_TESTS_CONFIG="--valgrind"
export GOAL="install"
export BITCOIN_CONFIG="--enable-fuzz --with-sanitizers=fuzzer CC=clang CXX=clang++"
# Temporarily pin dwarf 4, until valgrind can understand clang's dwarf 5
export BITCOIN_CONFIG="--enable-fuzz --with-sanitizers=fuzzer CC=clang CXX=clang++ CXXFLAGS='-fdebug-default-version=4'"
export CCACHE_SIZE=200M

3
ci/test/00_setup_env_native_valgrind.sh
View File

@ -13,4 +13,5 @@ export USE_VALGRIND=1
export NO_DEPENDS=1
export TEST_RUNNER_EXTRA="--nosandbox --exclude feature_init,rpc_bind,feature_bind_extra" # Excluded for now, see https://github.com/bitcoin/bitcoin/issues/17765#issuecomment-602068547
export GOAL="install"
export BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --with-gui=no CC=clang CXX=clang++" # TODO enable GUI
# Temporarily pin dwarf 4, until valgrind can understand clang's dwarf 5
export BITCOIN_CONFIG="--enable-zmq --with-incompatible-bdb --with-gui=no CC=clang CXX=clang++ CXXFLAGS='-fdebug-default-version=4'" # TODO enable GUI

10
contrib/valgrind.supp
View File

@ -112,16 +112,6 @@
...
fun:GetCoin
}
{
Suppress boost warning
Memcheck:Leak
fun:_Znwm
...
fun:_ZN5boost9unit_test9framework5state17execute_test_treeEmjPKNS2_23random_generator_helperE
fun:_ZN5boost9unit_test9framework3runEmb
fun:_ZN5boost9unit_test14unit_test_mainEPFbvEiPPc
fun:main
}
{
Suppress LogInstance still reachable memory warning
Memcheck:Leak