highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-04 10:12:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

coinselection: Track whether BnB completed

Browse Source 
BnB may not be able to exhaustively search all potentially interesting
combinations for large UTXO pools, so we keep track of whether the
search was terminated by the iteration limit.
This commit is contained in:
Murch
2025-03-26 17:18:18 -07:00
parent 3ca0f36164
commit 7ecea1dc5d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/wallet/coinselection.cpp
View File

@@ -131,6 +131,7 @@ util::Result<SelectionResult> SelectCoinsBnB(std::vector<OutputGroup>& utxo_pool
};
size_t curr_try = 0;
SelectionResult result(selection_target, SelectionAlgorithm::BNB);
while (true) {
bool should_shift{false}, should_cut{false};
// Select `next_utxo`
@@ -166,6 +167,7 @@ util::Result<SelectionResult> SelectCoinsBnB(std::vector<OutputGroup>& utxo_pool
if (curr_try >= TOTAL_TRIES) {
// Solution is not guaranteed to be optimal if `curr_try` hit TOTAL_TRIES
result.SetAlgoCompleted(false);
break;
}
@@ -185,6 +187,7 @@ util::Result<SelectionResult> SelectCoinsBnB(std::vector<OutputGroup>& utxo_pool
if (should_shift) {
if (curr_selection.empty()) {
// Exhausted search space before running into attempt limit
result.SetAlgoCompleted(true);
break;
}
// Set `next_utxo` to one after last selected, then deselect last selected UTXO
@@ -193,7 +196,6 @@ util::Result<SelectionResult> SelectCoinsBnB(std::vector<OutputGroup>& utxo_pool
}
}
SelectionResult result(selection_target, SelectionAlgorithm::BNB);
result.SetSelectionsEvaluated(curr_try);
if (best_selection.empty()) {