highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-05-28 14:55:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#35277: ci: Enable ruff ambiguous-unicode-character checks

Browse Source 
fa9c919678 refactor: Use ignore-list over verbose select-list (MarcoFalke)
fa9b01adec ci: Enable ruff ambiguous-unicode-character checks (MarcoFalke)

Pull request description:

  Ambiguous unicode chars are unused and confusing. Worst, they can lead to bugs.

  So enable the ruff checks to catch them. Can be tested via:

  ```
  echo 'ZGlmZiAtLWdpdCBhL3Rlc3QvZnVuY3Rpb25hbC93YWxsZXRfZGlzYWJsZS5weSBiL3Rlc3QvZnVu
  Y3Rpb25hbC93YWxsZXRfZGlzYWJsZS5weQppbmRleCBkYmNjY2Q0Li4wYjhjNDQ2IDEwMDc1NQot
  LS0gYS90ZXN0L2Z1bmN0aW9uYWwvd2FsbGV0X2Rpc2FibGUucHkKKysrIGIvdGVzdC9mdW5jdGlv
  bmFsL3dhbGxldF9kaXNhYmxlLnB5CkBAIC0yMSwzICsyMSw4IEBAIGNsYXNzIERpc2FibGVXYWxs
  ZXRUZXN0IChCaXRjb2luVGVzdEZyYW1ld29yayk6CiAgICAgZGVmIHJ1bl90ZXN0IChzZWxmKToK
  KyAgICAgICAgIiIiQSBsb3ZlbHkgZG9jc3RyaW5nICh3aXRoIGEgYFUrRkYwOWAgcGFyZW50aGVz
  aXPvvIkuIiIiCiAgICAgICAgICMgTWFrZSBzdXJlIHdhbGxldCBpcyByZWFsbHkgZGlzYWJsZWQK
  KyAgICAgICAgIyBu0L5xYSAgIzwtIGlzIEN5cmlsbGljIChgVSswNDNFYCkKKyAgICAgICAgcHJp
  bnQoIs6XZWxsbywgd29ybGQhIikgICMgPC0gaXMgdGhlIEdyZWVrIGV0YSAoYFUrMDM5N2ApLgor
  ICAgICAgICBleGFtcGxlID0gInjigI8iICogMTAwICAjICAgICLigI94IiBpcyBhc3NpZ25lZAor
  ICAgICAgICBleGFtcGxlPU5vbmUjbm9xYQogICAgICAgICBhc3NlcnRfcmFpc2VzX3JwY19lcnJv
  cigtMzI2MDEsICdNZXRob2Qgbm90IGZvdW5kJywgc2VsZi5ub2Rlc1swXS5nZXR3YWxsZXRpbmZv
  KQo=' | base64 --decode | git apply

  git diff

  ruff check ./test/functional/*.py
  ```

  It should print 4 error types.

ACKs for top commit:
  stickies-v:
    ACK fa9c919678
  willcl-ark:
    ACK fa9c919678

Tree-SHA512: de226ec2feaf65a0a8b15606708cc390296be4492f41221f8a49f034b16e8fb62125342c6993f9d5c76bd4ae2db7343851b252a1b9140e27d6777f19a0b1605e
This commit is contained in:
merge-script
2026-05-13 12:19:16 +01:00
parent fe2bb43e43 fa9c919678
commit 82733e61de
1 changed files with 12 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
ruff.toml
View File

@@ -2,41 +2,17 @@
select = [
"B006", # mutable-argument-default
"B008", # function-call-in-default-argument
"E101", # indentation contains mixed spaces and tabs
"E401", # multiple imports on one line
"E402", # module level import not at top of file
"E701", # multiple statements on one line (colon)
"E702", # multiple statements on one line (semicolon)
"E703", # statement ends with a semicolon
"E711", # comparison to None should be 'if cond is None:'
"E713", # test for membership should be "not in"
"E714", # test for object identity should be "is not"
"E721", # do not compare types, use "isinstance()"
"E722", # do not use bare 'except'
"E742", # do not define classes named "l", "O", or "I"
"E743", # do not define functions named "l", "O", or "I"
"F401", # module imported but unused
"F402", # import module from line N shadowed by loop variable
"F403", # 'from foo_module import *' used; unable to detect undefined names
"F404", # future import(s) name after other statements
"F405", # foo_function may be undefined, or defined from star imports: bar_module
"F406", # "from module import *" only allowed at module level
"F407", # an undefined __future__ feature name was imported
"F541", # f-string without any placeholders
"F601", # dictionary key name repeated with different values
"F602", # dictionary key variable name repeated with different values
"F621", # too many expressions in an assignment with star-unpacking
"F631", # assertion test is a tuple, which are always True
"F632", # use ==/!= to compare str, bytes, and int literals
"F811", # redefinition of unused name from line N
"F821", # undefined name 'Foo'
"F822", # undefined name name in __all__
"F823", # local variable name referenced before assignment
"F841", # local variable 'foo' is assigned to but never used
"E", # pycodestyle errors
"F", # pyflakes errors
"PLE", # Pylint errors
"W191", # indentation contains tabs
"W291", # trailing whitespace
"W292", # no newline at end of file
"W293", # blank line contains whitespace
"W605", # invalid escape sequence "x"
"RUF001", # ambiguous-unicode-character-string
"RUF002", # ambiguous-unicode-character-docstring
"RUF003", # ambiguous-unicode-character-comment
"W", # pycodestyle warnings
]
ignore = [
"E501", # line too long
"E712", # true-false comparison
"E731", # lambda assignment
"E741", # ambiguous-variable-name
]