highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-08-03 23:35:47 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: Watchonly wallets should estimate larger size

Browse Source 
Test that when a watchonly wallet and the wallet with private keys fund
the same tx, the watchonly wallet should use a higher fee since it
should be estimating the size to be larger as it assumes the signer
cannot grind the R value.
This commit is contained in:
Ava Chow
2025-05-26 12:21:38 -07:00
parent b1821d8dd3
commit 9991f49c38
1 changed files with 24 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
test/functional/wallet_fundrawtransaction.py
View File

@@ -152,6 +152,7 @@ class RawTransactionsTest(BitcoinTestFramework):
self.test_feerate_rounding()
self.test_input_confs_control()
self.test_duplicate_outputs()
self.test_watchonly_cannot_grind_r()
def test_duplicate_outputs(self):
self.log.info("Test deserializing and funding a transaction with duplicate outputs")
@@ -1516,5 +1517,28 @@ class RawTransactionsTest(BitcoinTestFramework):
wallet.unloadwallet()
def test_watchonly_cannot_grind_r(self):
self.log.info("Test that a watchonly wallet will estimate higher fees for a tx than the wallet with private keys")
self.nodes[0].createwallet("grind")
wallet = self.nodes[0].get_wallet_rpc("grind")
default_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
self.nodes[0].createwallet(wallet_name="grind_watchonly", disable_private_keys=True)
watchonly = self.nodes[0].get_wallet_rpc("grind_watchonly")
assert_equal(watchonly.importdescriptors(wallet.listdescriptors()["descriptors"])[0]["success"], True)
# Send to legacy address type so that we will have an ecdsa signature with a measurable effect on the feerate
default_wallet.sendtoaddress(wallet.getnewaddress(address_type="legacy"), 10)
self.generate(self.nodes[0], 1)
assert_equal(wallet.listunspent(), watchonly.listunspent())
ret_addr = default_wallet.getnewaddress()
tx = wallet.createrawtransaction([], [{ret_addr: 5}])
funded = wallet.fundrawtransaction(hexstring=tx, fee_rate=10)
watchonly_funded = watchonly.fundrawtransaction(hexstring=tx, fee_rate=10)
assert_greater_than(watchonly_funded["fee"], funded["fee"])
if __name__ == '__main__':
RawTransactionsTest(__file__).main()