highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-04-11 08:07:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

signals: remove boost::signals2 mentions in linters and docs

Browse Source 
The documented example is no longer relevant, so remove it rather than updating
it to mention btcsignals.
This commit is contained in:
Cory Fields
2026-01-30 20:11:03 +00:00
parent 375397ebd9
commit a4b1607983
2 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
doc/developer-notes.md
View File

@@ -1411,9 +1411,9 @@ communication:
using TipChangedFn = std::function<void(int block_height, int64_t block_time)>;
virtual std::unique_ptr<interfaces::Handler> handleTipChanged(TipChangedFn fn) = 0;
// Bad: returns boost connection specific to local process
// Bad: returns btcsignals connection specific to local process
using TipChangedFn = std::function<void(int block_height, int64_t block_time)>;
virtual boost::signals2::scoped_connection connectTipChanged(TipChangedFn fn) = 0;
virtual btcsignals::scoped_connection connectTipChanged(TipChangedFn fn) = 0;
```
- Interface methods should not be overloaded.

3
test/lint/lint-includes.py
View File

@@ -30,9 +30,6 @@ EXPECTED_BOOST_INCLUDES = [
"boost/multi_index/tag.hpp",
"boost/multi_index_container.hpp",
"boost/operators.hpp",
"boost/signals2/connection.hpp",
"boost/signals2/optional_last_value.hpp",
"boost/signals2/signal.hpp",
"boost/test/included/unit_test.hpp",
"boost/test/unit_test.hpp",
"boost/tuple/tuple.hpp",