highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-06-10 14:48:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#35145: validation: fix misleading VerifyDB summary log

Browse Source 
1d66963749 log: clarify VerifyDB summary log (ViniciusCestarii)

Pull request description:

  The final `LogInfo` message about "No coin database inconsistencies" was printed unconditionally, even for check levels 0-2 where no coin DB verification runs and `nGoodTransactions` stays 0. Split into an always-on completion line and a coin-DB result line gated on `nCheckLevel >= 3 && !skipped_l3_checks`.

  Before (checklevel=1):
  `Verification: No coin database inconsistencies in last 6 blocks (0 transactions)`

  After (checklevel=1):
  `Verification: checked last 6 blocks at level 1`

ACKs for top commit:
  sedited:
    ACK 1d66963749

Tree-SHA512: a6c6689cff2f1942a44764a914a1ee01c92efa51489d72f456fccaa1f9ee0640449b55600d43e7dc89d622414854d53e8dfc7e8c87fe454b06e44f76075db267
This commit is contained in:
merge-script
2026-05-26 13:36:57 +02:00
parent 9767e80b21 1d66963749
commit ac9424fdc6
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/validation.cpp
View File

@@ -4727,7 +4727,10 @@ VerifyDBResult CVerifyDB::VerifyDB(
}
}
LogInfo("Verification: No coin database inconsistencies in last %i blocks (%i transactions)", block_count, nGoodTransactions);
LogInfo("Verification: checked last %i blocks at level %i", block_count, nCheckLevel);
if (nCheckLevel >= 3 && !skipped_l3_checks) {
LogInfo("Verification: no coin database inconsistencies (%i transactions)", nGoodTransactions);
}
if (skipped_l3_checks) {
return VerifyDBResult::SKIPPED_L3_CHECKS;