highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-03 09:30:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#31150: util: Treat Assume as Assert when evaluating at compile-time

Browse Source 
fa69a5f4b76a4e2a02db6c32d9c3311ce5fe29bd util: Treat Assume as Assert when evaluating at compile-time (MarcoFalke)

Pull request description:

  There is no downside or cost of treating an `Assume` at compile-time as an `Assert` and it may even help to find bugs while compiling without `ABORT_ON_FAILED_ASSUME`.

  This is also required for https://github.com/bitcoin/bitcoin/pull/31093

ACKs for top commit:
  dergoegge:
    ACK fa69a5f4b76a4e2a02db6c32d9c3311ce5fe29bd
  brunoerg:
    ACK fa69a5f4b76a4e2a02db6c32d9c3311ce5fe29bd
  marcofleon:
    ACK fa69a5f4b76a4e2a02db6c32d9c3311ce5fe29bd

Tree-SHA512: 17604403f841343a6d5b6e5d777e1760d38e0c27dc1fd4479e3741894fba40cdb1fb659cf24519a51d051bd5884a75992d1227ec9fa40fbf53bc619fbfb304ad
This commit is contained in:
merge-script 2024-10-25 13:10:19 +01:00
commit b95adf057a
No known key found for this signature in database
GPG Key ID: 2EEB9F5CC09526C1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/util/check.h
View File

@ -42,9 +42,9 @@ void assertion_fail(std::string_view file, int line, std::string_view func, std:
template <bool IS_ASSERT, typename T>
constexpr T&& inline_assertion_check(LIFETIMEBOUND T&& val, [[maybe_unused]] const char* file, [[maybe_unused]] int line, [[maybe_unused]] const char* func, [[maybe_unused]] const char* assertion)
{
if constexpr (IS_ASSERT
if (IS_ASSERT || std::is_constant_evaluated()
#ifdef ABORT_ON_FAILED_ASSUME
|| true
|| true
#endif
) {
if (!val) {