highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-12 05:32:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: cover IsFinalTx requires every input to be SEQUENCE_FINAL

Browse Source
This commit is contained in:
ViniciusCestarii
2026-08-25 08:55:13 -03:00
parent 994c17d6c0
commit bba1d4150e
1 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
src/test/transaction_tests.cpp
View File

@@ -1167,6 +1167,29 @@ BOOST_AUTO_TEST_CASE(checktxinputs_invalid_transactions_test)
TxValidationResult::TX_PREMATURE_SPEND, /*expected_reason=*/"bad-txns-premature-spend-of-coinbase");
}
BOOST_AUTO_TEST_CASE(isfinaltx_sequences_test)
{
constexpr int height{100};
// Every transaction here has the same unsatisfied nLockTime, so only the
// sequences decide the outcome.
auto check_final{[](const std::vector<uint32_t>& sequences, bool expected_final) {
CMutableTransaction mtx;
mtx.nLockTime = height;
for (const uint32_t sequence : sequences) {
mtx.vin.emplace_back(COutPoint{}, CScript{}, sequence);
}
BOOST_CHECK_EQUAL(IsFinalTx(CTransaction{mtx}, /*nBlockHeight=*/height, /*nBlockTime=*/0), expected_final);
}};
check_final(/*sequences=*/{CTxIn::SEQUENCE_FINAL, CTxIn::SEQUENCE_FINAL}, /*expected_final=*/true);
// nLockTime is only ignored when every input is SEQUENCE_FINAL
check_final(/*sequences=*/{CTxIn::SEQUENCE_FINAL, CTxIn::MAX_SEQUENCE_NONFINAL}, /*expected_final=*/false);
check_final(/*sequences=*/{CTxIn::MAX_SEQUENCE_NONFINAL, CTxIn::SEQUENCE_FINAL}, /*expected_final=*/false);
}
BOOST_AUTO_TEST_CASE(getvalueout_out_of_range_throws)
{
CMutableTransaction mtx;