highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-30 18:35:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge bitcoin/bitcoin#33825: refactor: Add missing include in bitcoinkernel_wrapper.h

Browse Source 
fa1e8d8bad refactor: Add missing include in bitcoinkernel_wrapper.h (MarcoFalke)

Pull request description:

  Otherwise, the compilation may fail with:

  ```
  /home/admin/actions-runner/_work/_temp/src/kernel/bitcoinkernel_wrapper.h:271:14: error: no type named 'exception_ptr' in namespace 'std'; did you mean 'exception'?
    271 |         std::exception_ptr exception;
        |         ~~~~~^~~~~~~~~~~~~
        |              exception
  /cxx_build/include/c++/v1/__exception/exception.h:72:33: note: 'exception' declared here
     72 | class _LIBCPP_EXPORTED_FROM_ABI exception {
        |                                 ^
  In file included from /home/admin/actions-runner/_work/_temp/src/bitcoin-chainstate.cpp:1:
  /home/admin/actions-runner/_work/_temp/src/kernel/bitcoinkernel_wrapper.h:284:35: error: no member named 'current_exception' in namespace 'std'
    284 |             data.exception = std::current_exception();
        |                                   ^~~~~~~~~~~~~~~~~
  /home/admin/actions-runner/_work/_temp/src/kernel/bitcoinkernel_wrapper.h:290:14: error: no member named 'rethrow_exception' in namespace 'std'
    290 |         std::rethrow_exception(user_data.exception);
        |              ^~~~~~~~~~~~~~~~~
  /home/admin/actions-runner/_work/_temp/src/kernel/bitcoinkernel_wrapper.h:273:65: error: no viable conversion from 'std::nullptr_t' to 'std::exception'
    273 |     UserData user_data = UserData{.bytes = &bytes, .exception = nullptr};
        |                                                                 ^~~~~~~
  /home/admin/actions-runner/_work/_temp/src/kernel/bitcoinkernel_wrapper.h:733:16: note: in instantiation of function template specialization 'btck::write_bytes<btck_Block>' requested here
    733 |         return write_bytes(get(), btck_block_to_bytes);
        |                ^
  /cxx_build/include/c++/v1/__exception/exception.h:75:25: note: candidate constructor not viable: no known conversion from 'std::nullptr_t' to 'const exception &' for 1st argument
     75 |   _LIBCPP_HIDE_FROM_ABI exception(const exception&) _NOEXCEPT            = default;
        |                         ^         ~~~~~~~~~~~~~~~~
  4 errors generated.

ACKs for top commit:
  TheCharlatan:
    ACK fa1e8d8bad
  hebasto:
    ACK fa1e8d8bad.
  yuvicc:
    ACK fa1e8d8bad

Tree-SHA512: c0127678db5913402c92b7602d159faae26539dc33f6159abd909b33746dd4626b8cbb6a86d8ccd3c9c83e06956fe55fb721a034480498d0cd87349aceea51f9
This commit is contained in:
Hennadii Stepanov
2025-11-08 14:44:23 +00:00
parent 513a0da2e0 fa1e8d8bad
commit ca1ce52a0f
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/kernel/bitcoinkernel_wrapper.h
View File

@@ -8,6 +8,7 @@
#include <kernel/bitcoinkernel.h>
#include <array>
#include <exception>
#include <functional>
#include <memory>
#include <optional>