highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-05-23 20:35:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

wallet: check BDB last page LSN

Browse Source 
The BDB metadata field `last_page` stores the last valid page number, not the number of pages.
The read-only wallet migration parser currently checks reset LSNs with a half-open loop, so it skips the final page and may accept a database whose last page still depends on BDB log files.
This commit is contained in:
Lőrinc
2026-05-06 12:34:20 +02:00
parent aa1d0d7cd7
commit e2b0984f99
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/wallet/migrate.cpp
View File

@@ -567,7 +567,7 @@ void BerkeleyRODatabase::Open()
// Check all Log Sequence Numbers (LSN) point to file 0 and offset 1 which indicates that the LSNs were
// reset and that the log files are not necessary to get all of the data in the database.
for (uint32_t i = 0; i < outer_meta.last_page; ++i) {
for (uint32_t i = 0; i <= outer_meta.last_page; ++i) {
// The LSN is composed of 2 32-bit ints, the first is a file id, the second an offset
// It will always be the first 8 bytes of a page, so we deserialize it directly for every page
uint32_t file;