highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-14 23:37:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Use std::visit in ApplyArgFallback

Browse Source 
This is more explicit and comes with compile-time checks to ensure all default types are covered.
This commit is contained in:
MarcoFalke
2026-07-29 13:11:31 +02:00
parent 27b6b5a458
commit fa1242dcc0
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/rpc/server.cpp
View File

@@ -15,6 +15,7 @@
#include <rpc/server_util.h>
#include <rpc/util.h>
#include <sync.h>
#include <util/overloaded.h>
#include <util/signalinterrupt.h>
#include <util/strencodings.h>
#include <util/string.h>
@@ -28,8 +29,8 @@
#include <mutex>
#include <span>
#include <string_view>
#include <unordered_set>
#include <unordered_map>
#include <unordered_set>
#include <variant>
using util::SplitString;
@@ -318,11 +319,12 @@ void ApplyTypeStrOverride(UniValue& schema, const RPCArg& arg)
void ApplyArgFallback(UniValue& schema, const RPCArg& arg)
{
if (const auto* def = std::get_if<RPCArg::Default>(&arg.m_fallback)) {
schema.pushKV("default", *def);
} else if (const auto* hint = std::get_if<RPCArg::DefaultHint>(&arg.m_fallback)) {
schema.pushKV("x-bitcoin-default-hint", *hint);
}
std::visit(util::Overloaded{
[&](const RPCArg::Default& def) { schema.pushKV("default", def); },
[&](const RPCArg::DefaultHint& hint) { schema.pushKV("x-bitcoin-default-hint", hint); },
[](const RPCArg::Optional&) {},
},
arg.m_fallback);
}
// NOLINTNEXTLINE(misc-no-recursion)