Commit Graph

4090 Commits

Author SHA1 Message Date
Wladimir J. van der Laan
9d11aba4c4 Merge #5765: Implement BIP66 (0.8) v0.8-final 2015-02-17 10:04:23 +01:00
Pieter Wuille
6690ef7fea Backport of some of BIP66's tests 2015-02-06 11:17:29 -08:00
Pieter Wuille
534e6dac47 Raise version of created blocks, and enforce DERSIG in mempool 2015-02-06 11:17:29 -08:00
Pieter Wuille
da7ba593d7 Implement BIP 66 validation rules and switchover logic 2015-02-06 11:17:29 -08:00
Wladimir J. van der Laan
f19dded6e4 Improve robustness of DER recoding code
Add some defensive programming on top of #5634.

This copies the respective OpenSSL code in ECDSA_verify in
OpenSSL pre-1.0.1k (e.g. https://github.com/openssl/openssl/blob/OpenSSL_1_0_1j/crypto/ecdsa/ecs_vrf.c#L89)
more closely.

As reported by @sergiodemianlerner.

Github-Pull: #5640
Rebased-From: c6b7b29f23
2015-01-12 11:05:04 +01:00
Cory Fields
91e1332011 fail immediately on an empty signature
Github-Pull: #5634
Rebased-From: 8dccba6a45
2015-01-10 09:14:17 +01:00
Cory Fields
f4134ee301 consensus: guard against openssl's new strict DER checks
New versions of OpenSSL will reject non-canonical DER signatures. However,
it'll happily decode them. Decode then re-encode before verification in order
to ensure that it is properly consumed.

Github-Pull: #5634
Rebased-From: 488ed32f2a
2015-01-10 09:13:53 +01:00
Wladimir J. van der Laan
03a7d67387 Release notes for 0.8.6 v0.8.6 v0.8.6rc1 2013-12-05 13:11:26 +01:00
theuni
d3381e71a1 leveldb: Use native Darwin memory barriers 2013-12-05 13:10:24 +01:00
Warren Togami
77f7bcb352 LevelDB: use PosixWriteableFile only on MacOS X
mmap is proven on the other platforms, we are not changing it at
the last moment before release.
2013-12-05 13:10:24 +01:00
Patrick Strateman
5f553f8422 dont use mmap in leveldb, this is a marginal performance hit
fail on short writes

Ensure new files referred to by the manifest are in the filesystem.
2013-12-05 13:10:24 +01:00
Wladimir J. van der Laan
1eb11e32e8 Prevent empty transactions from being added to vtxPrev
CWalletTx::AddSupportingTransactions() was adding empty transaction
to vtxPrev in some cases. Skip over these.

Part one of the solution to #3190. This prevents invalid vtxPrev from
entering the wallet, but not current ones being transmitted.
2013-12-05 11:05:14 +01:00
Wladimir J. van der Laan
ec93d0aa43 Refuse to retransmit transactions without vins
Versions of bitcoin before 0.8.6 have a bug that inserted
empty transactions into the vtxPrev in the wallet, which will cause the node to be
banned when retransmitted, hence add a check for !tx.vin.empty()
before RelayTransaction.
2013-12-05 11:05:14 +01:00
Wladimir J. van der Laan
8c3ba8be01 qt: use deleteLater to remove send entries
Use deleteLater() instead of delete, as it is not allowed
to delete widgets directly in an event handler.
Should solve the MacOSX random crashes on send with coincontrol.

Rebased-From: 6c98cca9e4
2013-12-05 09:16:48 +01:00
Wladimir J. van der Laan
a0a5b20156 release notes: add warning about 32-bit systems 2013-12-05 09:16:48 +01:00
Gavin Andresen
22db46cf11 Fix typo: make default maxblocksize 350k (not 300) 2013-12-05 09:16:48 +01:00
Philip Kaufmann
bfb0856986 Bitcoin-Qt: Fix display of window when bitcoin: URI is opened
WalletView:
- add new signal showNormalIfMinimized()
- emit the new signal in handleURI() to fix a bug, preventing the main
  window to show up when using bitcoin: URIs

Upstream: dbc0a6aba2
2013-12-05 09:15:41 +01:00
Timothy Stranex
3b8868dca4 Fix typo in a comment: it's base58, not base48. 2013-12-05 09:15:41 +01:00
Robert Backhaus
df0f6d020a Don't attempt to resize vector to negative size. 2013-12-05 09:15:41 +01:00
Daniel Larimer
27e35bf840 fix memory leak in CKey::SetCompactSignature() 2013-12-05 09:15:41 +01:00
Daniel Larimer
6f21e7317e Fix memory leak on exception in Key::SignCompact 2013-12-05 09:15:41 +01:00
Micha
daf9e4627f Made the build/release process completable verbatim as listed in
release-process.md

Conflicts:
	doc/release-process.md
2013-12-05 09:15:40 +01:00
Wladimir J. van der Laan
138705a173 Create parent directories if needed in GetDataDir
One-line change. Fixes #2752.
2013-12-05 09:15:40 +01:00
Warren Togami
96896a0ece Add wtogami to gitian download scripts. 2013-12-05 09:15:40 +01:00
Cozz Lovan
901ae4bffd fix comment about dust logic
Conflicts:
	src/core.h
2013-12-05 09:15:40 +01:00
Michael Ford
c9c67b00df Update HomeBrew osx makefile patch to account for recent changes to makefile 2013-12-05 09:15:40 +01:00
Gregory Maxwell
d3fe7c44f7 Make the rand tests determinstic. (fixes #2714)
This avoids spurious errors with the old tests but still tests
 enough that if the rng is replaced with a totally broken one
 it should still fail.
2013-12-05 09:15:40 +01:00
Mark Friedenbach
98289bbe25 Fix typo in README.md 2013-12-05 09:15:40 +01:00
Han Lin Yap
9f7fc8b332 fix typo in README.md 2013-12-05 09:15:40 +01:00
Philip Kaufmann
1b350f25a6 fix invalid conversion error with MinGW 4.8.1 in net.cpp
- fixes src\net.cpp:1601: Error:invalid conversion from 'void*' to
  'const char*' [-fpermissive] in a setsockopt() call on Win32 that was
  found by using MinGW 4.8.1 compiler suite
2013-12-05 09:15:39 +01:00
Luke Dashjr
89c2ea0891 Bugfix: Move boost/version include from db.cpp to walletdb.cpp where BOOST_VERSION is used 2013-12-05 09:15:39 +01:00
Roman Mindalev
df238b1975 Add missing 0x prefix in chainparams.cpp
Conflicts:
	src/chainparams.cpp
2013-12-05 09:15:39 +01:00
Robert Backhaus
187f8a5675 Explictly cast calculation to int, to allow std::max to work. 2013-12-05 09:15:39 +01:00
Gavin Andresen
9612e4c0d9 Lower maximum size for free transaction creation
Changes the maximum size of a free transaction that will be created
from 10,000 bytes to 1,000 bytes.

The idea behind this change is to make the free transaction area
available to a greater number of people; with the default 27K-per-block,
just three very-large very-high-priority transactions could fill the space.
2013-11-28 07:59:54 +01:00
Gavin Andresen
1ca8a75cb4 Remove CENT-output free transaction rule when relaying
Remove the (relay/mempool) rule that all outputs of free transactions
must be greater than 0.01 XBT. Dust spam is now taken care of by making
dusty outputs non-standard.
2013-11-28 07:59:54 +01:00
Gavin Andresen
5c029630f9 Increase default -blockmaxsize/prioritysize to 300K/30K 2013-11-28 07:59:53 +01:00
Mike Hearn
7120d76dc6 Store and use a sanitized subVer
Rebased-from: a946aa8d3e
2013-11-28 11:03:33 +10:00
Mike Hearn
1c53d0a4fb Add some additional logging to give extra network insight. 2013-11-28 11:03:33 +10:00
Philip Kaufmann
3779de9d89 special case DoS value == 0 in ProcessMessage()
- prevents unneeded log messages, which could make users think something
  bad was happening

Squashed: style-police code cleanup
2013-11-28 11:03:33 +10:00
Gavin Andresen
56ce843314 Refactor: pull alert string sanitization into util
Rebased-from: 17faf56262
2013-11-28 11:03:33 +10:00
Warren Togami
e564297156 Silence useless warning in src/json/json_spirit_writer_template.h to make important warnings easier to see.
warning: typedef ‘Char_type’ locally defined but not used [-Wunused-local-typedefs]
2013-11-28 11:03:33 +10:00
Wladimir J. van der Laan
83efc9104f Squashed 'src/leveldb/' changes from be1b0ff..be91006
936b461 Merge upstream LevelDB 1.13.
748539c LevelDB 1.13

git-subtree-dir: src/leveldb
git-subtree-split: be9100673b05cec1662a54d0b7a59e4317fdda86
2013-11-28 11:03:32 +10:00
Wladimir J. van der Laan
e4be09cfae Bump version numbers for 0.8.6 release 2013-11-26 14:00:48 +01:00
Cory Fields
068996daa5 osx: fix bitcoin-qt startup crash when clicking dock icon
Crash probably introduced by 4d17a1b0.
Inialize the window to NULL and verify it before use.

Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
2013-11-26 14:00:48 +01:00
Pieter Wuille
99f73bd2fd Fix build date for from-tarball builds 2013-11-26 14:00:48 +01:00
Philip Kaufmann
f607729b26 exclude CreatePidFile() function on WIN32 as it is unused 2013-11-26 14:00:48 +01:00
phelixbtc
e88eb41b6c Porting MinGW multithreading bugfix to makefile.mingw
Original fix:
https://github.com/bitcoin/bitcoin/commit
/8864019f6d88b13d3442843d9e6ebeb8dd938831
2013-11-26 14:00:48 +01:00
David Hill
0119e0c592 Hurricane Electric uses block 2001:470::, not 2011:470:: 2013-11-26 14:00:48 +01:00
Gregory Maxwell
f46f128b9a More fixes for blockchain corruption on OSX.
As we'd previously learned, OSX's fsync is a data eating lie.

Since 0.8.4 we're still getting some reports of disk corruption on
 OSX but now all of it looks like the block files have gotten out of
 sync with the database. It turns out that we were still using fsync()
 on the block files, so this isn't surprising.
2013-11-26 14:00:47 +01:00
Philip Kaufmann
05ea79052c make -logtimestamps default on and rework help-message
Rebased-By: Wladimir J. van der Laan <laanwj@gmail.com>
Rebased-From: 959e62f
2013-11-26 14:00:47 +01:00