highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-03 22:03:01 +01:00
Code Issues Packages Projects Releases Wiki Activity
2,219 Commits 8 Branches 347 Tags
c43a9ea77db06b9d101f0551df373d417e5028af
Commit Graph

2219 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dwayne C. Litzenberger
c43a9ea77d Fix bugs on 'unsigned char' platforms. 
In ISO C++, the signedness of 'char' is undefined.  On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86).  This is indicated by compiler warnings like this:

 bignum.h: In constructor 'CBigNum::CBigNum(char)':
 bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]

 util.cpp: In function 'bool IsHex(const string&)':
 util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]

In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.

Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
 2012-04-22 09:38:37 -04:00
Dwayne C. Litzenberger
8104274701 Fix phexdigits[255] is undefined. 2012-04-22 09:26:30 -04:00
Jeff Garzik
2abd083ea4 Fix sign-compare warnings: netbase's Lookup* max-solutions may be unsigned 2012-04-17 15:00:15 -04:00
Jeff Garzik
0c3aa881e2 Fix loop index var types, fixing many minor sign comparison warnings 
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
 2012-04-17 14:59:32 -04:00
Luke Dashjr
3374c3ef09 Merge branch '0.5.x' into 0.6.0.x 
Conflicts:
	src/qt/bitcoin.cpp
	src/qt/bitcoingui.cpp
	src/qt/guiutil.cpp
	src/qt/guiutil.h
	src/qt/sendcoinsdialog.cpp
	src/qt/sendcoinsdialog.h
	src/util.cpp
 2012-04-15 21:15:48 -04:00
Luke Dashjr
e73b792b1a Merge branch '0.5.0.x' into 0.5.x 2012-04-15 21:06:10 -04:00
Luke Dashjr
79fc752b61 Merge branch '0.4.x' into 0.5.0.x 
Conflicts:
	src/keystore.h
 2012-04-15 21:05:54 -04:00
Wladimir J. van der Laan
1bdfa94a01 fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses] 2012-04-15 19:43:45 -04:00
Wladimir J. van der Laan
8460185dec fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses] 2012-04-15 19:43:41 -04:00
Wladimir J. van der Laan
9c236a945c fix warnings: '&&' within '||' [-Wlogical-op-parentheses] 2012-04-15 19:42:40 -04:00
Wladimir J. van der Laan
678a319888 fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] 2012-04-15 19:42:19 -04:00
Wladimir J. van der Laan
0aa0bb1ead fix warnings: unused variable 'XX' [-Wunused-variable] 2012-04-15 19:40:58 -04:00
Wladimir J. van der Laan
fdcafa3535 fix warnings: unused variable 'XX' [-Wunused-variable] 2012-04-15 19:37:34 -04:00
Wladimir J. van der Laan
5f4fee559e fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum] 2012-04-15 19:28:48 -04:00
Wladimir J. van der Laan
c4381587a6 fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags] 2012-04-15 19:28:34 -04:00
Wladimir J. van der Laan
85e975f379 fix warnings: array subscript is of type 'char' [-Wchar-subscripts] 2012-04-15 19:28:09 -04:00
Wladimir J. van der Laan
f650d62fc6 fix warnings: array subscript is of type 'char' [-Wchar-subscripts] 2012-04-15 19:28:00 -04:00
Wladimir J. van der Laan
401db6d96b work around issue in boost::program_options that prevents from compiling in clang 2012-04-15 19:23:01 -04:00
Chris Moore
7c3db2129e CBitcoinSecret::SetString() now calls IsValid() to make sure it was passed something with the correct version. 2012-04-15 13:31:50 -04:00
Wladimir J. van der Laan
cb1035a008 Show a message box when runaway exception happens 
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
 2012-04-15 13:25:35 -04:00
Luke Dashjr
79940a6793 Merge commit 'e962c7f' into 0.5.0.x 2012-04-15 13:23:43 -04:00
Luke Dashjr
e962c7f532 Bugfix: nTotalBlocks wasn't in 0.5.0, so need to replace it with equivalent function call in backport 2012-04-15 13:23:34 -04:00
Luke Dashjr
b7566fe29c Bump version to 0.6.0.7 
Skipping 0.6.0.1 through 0.6.0.6 since the internal version for 0.6.0[.0] was in fact 0.6.0.6
 2012-04-15 13:08:21 -04:00
Luke Dashjr
b557c17a37 Bugfix: Check that QRcode_encodeString didn't return NULL (error) 
Without this, any error will segfault Bitcoin-Qt
 2012-04-15 12:59:11 -04:00
Luke Dashjr
02a38ac22b Add symlink to scripts/qt/make_windows_icon.sh from old file name, just in case 2012-04-14 15:38:26 -04:00
Wladimir J. van der Laan
f2862f1a49 Rename make_windows_icon.py to .sh as it is a shell script (fixes #1099) 2012-04-14 15:38:05 -04:00
Wladimir J. van der Laan
a558054709 Do not show green tick unless all known blocks are downloaded (fixes #921) 2012-04-14 15:33:24 -04:00
Wladimir J. van der Laan
1f91797535 Add missing tooltip and key shortcut in settings dialog (#1088 without line break part) 2012-04-14 15:33:03 -04:00
Gavin Andresen
e88b6b341d Bug fix listtransactions from/count handling. 2012-04-14 15:29:43 -04:00
Luke Dashjr
278074eb23 Display an error, rather than crashing, if encoding a QR Code failed. 
(master workaround in b1a99c3a1f + 7261945eb5)
 2012-04-14 15:28:07 -04:00
Philip Kaufmann
760d9480ed removed (no label) string if we have NO label 
(partial of 9e0dba8c17)
 2012-04-14 15:11:28 -04:00
Wladimir J. van der Laan
1f56046fd5 Show error message instead of exception crash when unable to bind RPC port 
Fixes issue #875
 2012-04-11 15:54:30 -04:00
cardpuncher
06de079091 Added comment lines in French & Turkish which basically mean "Bitcoin, virtual P2P cryptocurrency". 2012-04-11 15:20:59 -04:00
Luke Dashjr
9bf1140b90 Merge branch '0.5.0.x' into 0.5.x 2012-04-06 17:45:20 -04:00
Luke Dashjr
527b512cf7 Bugfix: Windows lacks sleep(), so need to use Sleep() from util.h 2012-04-06 17:44:48 -04:00
Luke Dashjr
892fcaf291 Merge branch '0.5.0.x' into 0.5.x 
Conflicts:
	src/qt/notificator.h
 2012-04-06 16:34:34 -04:00
p2k
bf1f995c4c Proper support for Growl 1.3 notifications 2012-04-06 16:31:09 -04:00
Luke Dashjr
ce33356094 Bugfix: Replace "URL" with "URI" where we aren't actually working with URLs 2012-04-06 14:46:30 -04:00
Luke Dashjr
d652709aba Bugfix: Replace "URL" with "URI" where we aren't actually working with URLs 2012-04-06 14:30:10 -04:00
graingert
8ae76e0f5d Change sign message bitcoin address tooltip to "The address to sign the message with" Closes #1050 2012-04-05 22:24:44 -04:00
Luke Dashjr
a93bb51604 Merge branch 'strlcpy_attribute' into 0.5.0.x 2012-04-05 19:43:06 -04:00
Luke Dashjr
7993454a92 Document strlcpy.h in assets-attribution.txt since it isn't MIT-licensed 2012-04-05 18:58:20 -04:00
Luke Dashjr
3e0e10add3 Merge branch '0.5.x' into 0.6.0.x 
Conflicts:
	src/keystore.cpp
 2012-04-05 18:22:47 -04:00
Luke Dashjr
0d10cb7a1f Merge branch '0.5.0.x' into 0.5.x 2012-04-05 18:21:01 -04:00
Luke Dashjr
0af2f2d856 Merge branch '0.4.x' into 0.5.0.x 2012-04-05 18:20:18 -04:00
Pieter Wuille
c7057326ea Verify status of encrypt/decrypt calls to detect failed padding 2012-04-05 18:03:48 -04:00
Wladimir J. van der Laan
53e596512c Increase time ago of last block for "up to date" status from 30 to 90 minutes 
It was too hyperactive.
gmaxwell: I mean that right now when the block gap goes over an hour it starts showing synchronizing. Increasing that to 90 minutes or so would make it only happen about 6.4 times per year
 2012-04-04 16:00:04 -04:00
Matt Corallo
d02833c76a Add laanwj to gitian download scripts. 2012-04-04 15:58:15 -04:00
Matt Corallo
bf754cfd01 Add laanwj to gitian download scripts. 2012-04-04 15:58:02 -04:00
Luke Dashjr
fe1725a141 Merge branch '0.5.x' into 0.6.0.x 
Conflicts:
	src/bitcoinrpc.cpp
 2012-04-04 15:43:29 -04:00