44e6dda745 doc: update manpages for v28.4rc2 (Ava Chow)
46ff3698f8 doc: Update release notes for v28.4rc2 (Ava Chow)
6cf3d8226d build: bump version to v28.4rc2 (Ava Chow)
931f12dcf7 doc: Update Guix install for Debian/Ubuntu (MarcoFalke)
242b9ae3f3 QA: tool_wallet: Check that db.log is deleted with a lone legacy wallet, but not with a shared db environment (Luke Dashjr)
c5d9f75c4b Bugfix: Wallet/Migration: Move backup into wallet directory when migrating from non-directory (Luke Dashjr)
6494072295 Wallet/Migration: Skip moving the backup file back and forth for no reason (Luke Dashjr)
619480bd78 Wallet/Migration: If loading the new watchonly or solvables wallet fails, log the correct wallet name in error message (Luke Dashjr)
29abedc97b Wallet/bdb: Safely and correctly list files only used by the single wallet (Luke Dashjr)
Pull request description:
Backports:
* #34370
* #34671
And the rc2 release process things
ACKs for top commit:
willcl-ark:
ACK 44e6dda745
Tree-SHA512: beb478a057b14c3ad9f1ce049f304fa1a5ff948c3492efbd39c51b9bb73a695a5382292513ee53f9ee64ecbbe6370cbbf2781bee01cf3dc262623be4110eacd8
Since we no longer delete the wallet directory, there's no need to vacate it
The moving only served to risk errors by crossing filesystem boundaries (which fs::rename can't handle)
Github-Pull: 34370
Rebased-From: cef01d0be5
If any other files exist in the directory, we cannot assume the sharable files are exclusively for this wallet.
But if they are, this also cleans up other log.* files
Github-Pull: #34370
Rebased-From: 7475d134f6
f60bfe777d doc: update manual pages for v28.4rc1 (fanquake)
fb5fdbfe72 build: bump version to v28.4rc1 (fanquake)
72ff93ec0c doc: update release notes for v28.4rc1 (fanquake)
Pull request description:
Final changes for a `28.4rc1`.
ACKs for top commit:
willcl-ark:
ACK f60bfe777d
Tree-SHA512: f9519dca53f87023ed04a0f3ec6bea354ee810ff189d052009ddfccf11d3894bf8d5b09a03f8aa189fbe060426fabe7c0b6d8643d3083bbf06044c0118a3d2d0
f6e5ec5d81 doc: update release notes for v28.x (fanquake)
5879b5a172 chore: Update outdated GitHub Actions versions (Padraic Slattery)
4fca124c0b ci: remove 3rd party js from windows dll gha job (Max Edwards)
4d4e3600af ci: use macos-14 image (fanquake)
6b5a536c05 doc: update copyright year (fanquake)
Pull request description:
Contains one change to switch the macOS runners to a version that still works (13 -> 14):
* 4d4e3600af
Also backports:
* #32513 (partial backport)
* #34174
* #34344
ACKs for top commit:
marcofleon:
ACK f6e5ec5d81
Tree-SHA512: 63e4b08779852984c48aaf555f6ce9a7afd12bad65b8062dcc6351b39f6a3a355efd0e0277e8a62400588613db86c45f196efc1ac7b91317821d69301badebcf
We can use vswhere.exe directly to create a vs developer
prompt and so can remove this third party dependency.
Co-authored-by: David Gumberg <davidzgumberg@gmail.com>
Github-Pull: #32513
Rebased-From: 7ae0497eef
Refactor a common way to perform the failed migration test that exists
for default wallets, and add relative-path wallets and absolute-path
wallets.
Github-Pull: 34226
Rebased-From: eeaf28dbe0
Because the default wallet has no name, the watch-only and solvables
wallets created during migration end up having no name either.
This fixes it by applying the same prefix name we use for the backup
file for an unnamed default wallet.
Before: watch-only wallet named "_watchonly"
After: watch-only wallet named "default_wallet_watchonly"
Github-Pull: bitcoin/bitcoin#34156
Rebased-From: 82caa8193a
Right now, after migration the last message users see is "migration completed",
but the migration isn't actually finished yet. We still need to load the new wallets
to ensure consistency, and if that fails, the migration will be rolled back. This
can be confusing for users.
This change logs the post-migration loading step and if a wallet fails to load and
the migration will be rolled back.
Github-Pull: bitcoin/bitcoin#34156
Rebased-From: d70b159c42
The first test verifies that restoring into an existing empty directory
or a directory with no .dat db files succeeds, while restoring into a
dir with a .dat file fails.
The second test covers restoring into the default unnamed wallet
(wallet.dat), which also implicitly exercises the recovery path used
after a failed migration.
The third test covers failure during restore on a prune node. When
the wallet last sync was beyond the pruning height.
Github-Pull: bitcoin/bitcoin#34156
Rebased-From: f011e0f068
Verifies that a failed migration of the unnamed (default) wallet
does not erase the main /wallets/ directory, and also that the
backup file exists.
Github-Pull: bitcoin/bitcoin#34156
Rebased-From: 36093bde63
When migrating any legacy unnamed wallet, a failed migration would
cause the cleanup logic to remove its parent directory. Since this
type of legacy wallet lives directly in the main '/wallets/' folder,
this resulted in unintentionally erasing all wallets, including the
backup file.
To be fully safe, we will no longer call `fs::remove_all`. Instead,
we only erase the individual db files we have created, leaving
everything else intact. The created wallets parent directories are
erased only if they are empty.
As part of this last change, `RestoreWallet` was modified to allow
an existing directory as the destination, since we no longer remove
the original wallet directory (we only remove the files we created
inside it). This also fixes the restore of top-level default wallets
during failures, which were failing due to the directory existence
check that always returns true for the /wallets/ directory.
This bug started after:
f6ee59b6e2
Previously, the `fs::copy_file` call was failing for top-level wallets,
which prevented the `fs::remove_all` call from being reached.
Github-Pull: bitcoin/bitcoin#34156
Rebased-From: f4c7e28e80
Track what RestoreWallet creates so only those files and directories
are removed during a failure and nothing else. Preexisting paths
must be left untouched.
Note:
Using fs::remove_all() instead of fs::remove() in RestoreWallet does
not cause any problems currently, but the change is necessary for the
next commit which extends RestoreWallet to work with existing directories,
which may contain files that must not be deleted.
Github-Pull: bitcoin/bitcoin#34156
Rebased-From: 4ed0693a3f
$FILE_ENV has a full relative path already, prepending with ci/test/
results in a non-existent path which means that DEPENDS_HASH was not
actually committing to the test's environment file.
Github-Pull: #33581
Rebased-From: ceeb53adcd
44d05b2fb2 doc: update release notes for 28.x (fanquake)
201221b750 doc: update manual pages for v28.3rc2 (fanquake)
e2e1138350 build: bump version to 28.3rc2 (fanquake)
9c911f7e2d build: fix depends Qt download link (fanquake)
ae8605825f contrib: fix using macdploy script without translations. (amisha)
Pull request description:
Backports:
* #33482
* #33563
Plus final changes for a `28.3rc2`.
ACKs for top commit:
marcofleon:
Nice, re ACK 44d05b2fb2
stickies-v:
re-ACK 44d05b2fb2
Tree-SHA512: 63d46b93fcc2201071328a0708d32ef7b9ce80348455ec059c11edf238003a6f0ec7bd018a76bf0d7ba90ab99dae5176dfa387f9ea1b791e1f8ef785d7c2f1f2
QT translations are optional, but the script would error when
'translations_dir' falls back to its default value NULL.
This PR fixes it by moving the set-up of QT translations under
the check for 'translations_dir' presence.
Github-Pull: #33482
Rebased-From: 7b5261f7ef
