mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-28 10:56:50 +01:00
Compare commits
5 Commits
v0.13.2
...
v0.13-fina
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
b654842029 | ||
|
|
8adf75e6a1 | ||
|
|
c6811c1bd3 | ||
|
|
59c37ae55a | ||
|
|
77eaadb6c9 |
@@ -1,8 +1,8 @@
|
||||
package=miniupnpc
|
||||
$(package)_version=2.0
|
||||
$(package)_version=2.0.20170509
|
||||
$(package)_download_path=http://miniupnp.free.fr/files
|
||||
$(package)_file_name=$(package)-$($(package)_version).tar.gz
|
||||
$(package)_sha256_hash=d434ceb8986efbe199c5ca53f90ed53eab290b1e6d0530b717eb6fa49d61f93b
|
||||
$(package)_sha256_hash=d3c368627f5cdfb66d3ebd64ca39ba54d6ff14a61966dbecb8dd296b7039f16a
|
||||
|
||||
define $(package)_set_vars
|
||||
$(package)_build_opts=CC="$($(package)_cc)"
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
Bitcoin Core version 0.13.2 is now available from:
|
||||
Bitcoin Core version 0.13.x is now available from:
|
||||
|
||||
<https://bitcoin.org/bin/bitcoin-core-0.13.2/>
|
||||
<https://bitcoin.org/bin/bitcoin-core-0.13.x/>
|
||||
|
||||
This is a new minor version release, including various bugfixes and
|
||||
performance improvements, as well as updated translations.
|
||||
@@ -42,25 +42,10 @@ but severe issues with the libc++ version on 10.7.x keep it from running reliabl
|
||||
Notable changes
|
||||
===============
|
||||
|
||||
Change to wallet handling of mempool rejection
|
||||
Example item
|
||||
-----------------------------------------------
|
||||
|
||||
When a newly created transaction failed to enter the mempool due to
|
||||
the limits on chains of unconfirmed transactions the sending RPC
|
||||
calls would return an error. The transaction would still be queued
|
||||
in the wallet and, once some of the parent transactions were
|
||||
confirmed, broadcast after the software was restarted.
|
||||
|
||||
This behavior has been changed to return success and to reattempt
|
||||
mempool insertion at the same time transaction rebroadcast is
|
||||
attempted, avoiding a need for a restart.
|
||||
|
||||
Transactions in the wallet which cannot be accepted into the mempool
|
||||
can be abandoned with the previously existing abandontransaction RPC
|
||||
(or in the GUI via a context menu on the transaction).
|
||||
|
||||
|
||||
0.13.2 Change log
|
||||
0.13.x Change log
|
||||
=================
|
||||
|
||||
Detailed release notes follow. This overview includes changes that affect
|
||||
@@ -68,111 +53,13 @@ behavior, not code moves, refactors and string updates. For convenience in locat
|
||||
the code changes and accompanying discussion, both the pull request and
|
||||
git merge commit are mentioned.
|
||||
|
||||
### Consensus
|
||||
- #9293 `e591c10` [0.13 Backport #9053] IBD using chainwork instead of height and not using header timestamp (gmaxwell)
|
||||
- #9053 `5b93eee` IBD using chainwork instead of height and not using header timestamps (gmaxwell)
|
||||
|
||||
### RPC and other APIs
|
||||
- #8845 `1d048b9` Don't return the address of a P2SH of a P2SH (jnewbery)
|
||||
- #9041 `87fbced` keypoololdest denote Unix epoch, not GMT (s-matthew-english)
|
||||
- #9122 `f82c81b` fix getnettotals RPC description about timemillis (visvirial)
|
||||
- #9042 `5bcb05d` [rpc] ParseHash: Fail when length is not 64 (MarcoFalke)
|
||||
- #9194 `f26dab7` Add option to return non-segwit serialization via rpc (instagibbs)
|
||||
- #9347 `b711390` [0.13.2] wallet/rpc backports (MarcoFalke)
|
||||
- #9292 `c365556` Complain when unknown rpcserialversion is specified (sipa)
|
||||
- #9322 `49a612f` [qa] Don't set unknown rpcserialversion (MarcoFalke)
|
||||
|
||||
### Block and transaction handling
|
||||
- #8357 `ce0d817` [mempool] Fix relaypriority calculation error (maiiz)
|
||||
- #9267 `0a4aa87` [0.13 backport #9239] Disable fee estimates for a confirm target of 1 block (morcos)
|
||||
- #9196 `0c09d9f` Send tip change notification from invalidateblock (ryanofsky)
|
||||
|
||||
### P2P protocol and network code
|
||||
- #8995 `9ef3875` Add missing cs_main lock to ::GETBLOCKTXN processing (TheBlueMatt)
|
||||
- #9234 `94531b5` torcontrol: Explicitly request RSA1024 private key (laanwj)
|
||||
- #8637 `2cad5db` Compact Block Tweaks (rebase of #8235) (sipa)
|
||||
- #9058 `286e548` Fixes for p2p-compactblocks.py test timeouts on travis (#8842) (ryanofsky)
|
||||
- #8865 `4c71fc4` Decouple peer-processing-logic from block-connection-logic (TheBlueMatt)
|
||||
- #9117 `6fe3981` net: don't send feefilter messages before the version handshake is complete (theuni)
|
||||
- #9188 `ca1fd75` Make orphan parent fetching ask for witnesses (gmaxwell)
|
||||
- #9052 `3a3bcbf` Use RelevantServices instead of node_network in AttemptToEvict (gmaxwell)
|
||||
- #9048 `9460771` [0.13 backport #9026] Fix handling of invalid compact blocks (sdaftuar)
|
||||
- #9357 `03b6f62` [0.13 backport #9352] Attempt reconstruction from all compact block announcements (sdaftuar)
|
||||
- #9189 `b96a8f7` Always add default_witness_commitment with GBT client support (sipa)
|
||||
- #9253 `28d0f22` Fix calculation of number of bound sockets to use (TheBlueMatt)
|
||||
- #9199 `da5a16b` Always drop the least preferred HB peer when adding a new one (gmaxwell)
|
||||
|
||||
### Build system
|
||||
- #9169 `d1b4da9` build: fix qt5.7 build under macOS (theuni)
|
||||
- #9326 `a0f7ece` Update for OpenSSL 1.1 API (gmaxwell)
|
||||
- #9224 `396c405` Prevent FD_SETSIZE error building on OpenBSD (ivdsangen)
|
||||
|
||||
### GUI
|
||||
- #8972 `6f86b53` Make warnings label selectable (jonasschnelli) (MarcoFalke)
|
||||
- #9185 `6d70a73` Fix coincontrol sort issue (jonasschnelli)
|
||||
- #9094 `5f3a12c` Use correct conversion function for boost::path datadir (laanwj)
|
||||
- #8908 `4a974b2` Update bitcoin-qt.desktop (s-matthew-english)
|
||||
- #9190 `dc46b10` Plug many memory leaks (laanwj)
|
||||
|
||||
### Wallet
|
||||
- #9290 `35174a0` Make RelayWalletTransaction attempt to AcceptToMemoryPool (gmaxwell)
|
||||
- #9295 `43bcfca` Bugfix: Fundrawtransaction: don't terminate when keypool is empty (jonasschnelli)
|
||||
- #9302 `f5d606e` Return txid even if ATMP fails for new transaction (sipa)
|
||||
- #9262 `fe39f26` Prefer coins that have fewer ancestors, sanity check txn before ATMP (instagibbs)
|
||||
|
||||
### Tests and QA
|
||||
- #9159 `eca9b46` Wait for specific block announcement in p2p-compactblocks (ryanofsky)
|
||||
- #9186 `dccdc3a` Fix use-after-free in scheduler tests (laanwj)
|
||||
- #9168 `3107280` Add assert_raises_message to check specific error message (mrbandrews)
|
||||
- #9191 `29435db` 0.13.2 Backports (MarcoFalke)
|
||||
- #9077 `1d4c884` Increase wallet-dump RPC timeout (ryanofsky)
|
||||
- #9098 `ecd7db5` Handle zombies and cluttered tmpdirs (MarcoFalke)
|
||||
- #8927 `387ec9d` Add script tests for FindAndDelete in pre-segwit and segwit scripts (jl2012)
|
||||
- #9200 `eebc699` bench: Fix subtle counting issue when rescaling iteration count (laanwj)
|
||||
|
||||
### Miscellaneous
|
||||
- #8838 `094848b` Calculate size and weight of block correctly in CreateNewBlock() (jnewbery)
|
||||
- #8920 `40169dc` Set minimum required Boost to 1.47.0 (fanquake)
|
||||
- #9251 `a710a43` Improvement of documentation of command line parameter 'whitelist' (wodry)
|
||||
- #8932 `106da69` Allow bitcoin-tx to create v2 transactions (btcdrak)
|
||||
- #8929 `12428b4` add software-properties-common (sigwo)
|
||||
- #9120 `08d1c90` bug: Missed one "return false" in recent refactoring in #9067 (UdjinM6)
|
||||
- #9067 `f85ee01` Fix exit codes (UdjinM6)
|
||||
- #9340 `fb987b3` [0.13] Update secp256k1 subtree (MarcoFalke)
|
||||
- #9229 `b172377` Remove calls to getaddrinfo_a (TheBlueMatt)
|
||||
[to be filled in at release]
|
||||
|
||||
Credits
|
||||
=======
|
||||
|
||||
Thanks to everyone who directly contributed to this release:
|
||||
|
||||
- Alex Morcos
|
||||
- BtcDrak
|
||||
- Cory Fields
|
||||
- fanquake
|
||||
- Gregory Maxwell
|
||||
- Gregory Sanders
|
||||
- instagibbs
|
||||
- Ivo van der Sangen
|
||||
- jnewbery
|
||||
- Johnson Lau
|
||||
- Jonas Schnelli
|
||||
- Luke Dashjr
|
||||
- maiiz
|
||||
- MarcoFalke
|
||||
- Masahiko Hyuga
|
||||
- Matt Corallo
|
||||
- matthias
|
||||
- mrbandrews
|
||||
- Pavel Janík
|
||||
- Pieter Wuille
|
||||
- randy-waterhouse
|
||||
- Russell Yanofsky
|
||||
- S. Matthew English
|
||||
- Steven
|
||||
- Suhas Daftuar
|
||||
- UdjinM6
|
||||
- Wladimir J. van der Laan
|
||||
- wodry
|
||||
[to be filled in at release]
|
||||
|
||||
As well as everyone that helped translating on [Transifex](https://www.transifex.com/projects/p/bitcoin/).
|
||||
|
||||
178
doc/release-notes/release-notes-0.13.2.md
Normal file
178
doc/release-notes/release-notes-0.13.2.md
Normal file
@@ -0,0 +1,178 @@
|
||||
Bitcoin Core version 0.13.2 is now available from:
|
||||
|
||||
<https://bitcoin.org/bin/bitcoin-core-0.13.2/>
|
||||
|
||||
This is a new minor version release, including various bugfixes and
|
||||
performance improvements, as well as updated translations.
|
||||
|
||||
Please report bugs using the issue tracker at github:
|
||||
|
||||
<https://github.com/bitcoin/bitcoin/issues>
|
||||
|
||||
To receive security and update notifications, please subscribe to:
|
||||
|
||||
<https://bitcoincore.org/en/list/announcements/join/>
|
||||
|
||||
Compatibility
|
||||
==============
|
||||
|
||||
Microsoft ended support for Windows XP on [April 8th, 2014](https://www.microsoft.com/en-us/WindowsForBusiness/end-of-xp-support),
|
||||
an OS initially released in 2001. This means that not even critical security
|
||||
updates will be released anymore. Without security updates, using a bitcoin
|
||||
wallet on a XP machine is irresponsible at least.
|
||||
|
||||
In addition to that, with 0.12.x there have been varied reports of Bitcoin Core
|
||||
randomly crashing on Windows XP. It is [not clear](https://github.com/bitcoin/bitcoin/issues/7681#issuecomment-217439891)
|
||||
what the source of these crashes is, but it is likely that upstream
|
||||
libraries such as Qt are no longer being tested on XP.
|
||||
|
||||
We do not have time nor resources to provide support for an OS that is
|
||||
end-of-life. From 0.13.0 on, Windows XP is no longer supported. Users are
|
||||
suggested to upgrade to a newer version of Windows, or install an alternative OS
|
||||
that is supported.
|
||||
|
||||
No attempt is made to prevent installing or running the software on Windows XP,
|
||||
you can still do so at your own risk, but do not expect it to work: do not
|
||||
report issues about Windows XP to the issue tracker.
|
||||
|
||||
From 0.13.1 onwards OS X 10.7 is no longer supported. 0.13.0 was intended to work on 10.7+,
|
||||
but severe issues with the libc++ version on 10.7.x keep it from running reliably.
|
||||
0.13.1 now requires 10.8+, and will communicate that to 10.7 users, rather than crashing unexpectedly.
|
||||
|
||||
Notable changes
|
||||
===============
|
||||
|
||||
Change to wallet handling of mempool rejection
|
||||
-----------------------------------------------
|
||||
|
||||
When a newly created transaction failed to enter the mempool due to
|
||||
the limits on chains of unconfirmed transactions the sending RPC
|
||||
calls would return an error. The transaction would still be queued
|
||||
in the wallet and, once some of the parent transactions were
|
||||
confirmed, broadcast after the software was restarted.
|
||||
|
||||
This behavior has been changed to return success and to reattempt
|
||||
mempool insertion at the same time transaction rebroadcast is
|
||||
attempted, avoiding a need for a restart.
|
||||
|
||||
Transactions in the wallet which cannot be accepted into the mempool
|
||||
can be abandoned with the previously existing abandontransaction RPC
|
||||
(or in the GUI via a context menu on the transaction).
|
||||
|
||||
|
||||
0.13.2 Change log
|
||||
=================
|
||||
|
||||
Detailed release notes follow. This overview includes changes that affect
|
||||
behavior, not code moves, refactors and string updates. For convenience in locating
|
||||
the code changes and accompanying discussion, both the pull request and
|
||||
git merge commit are mentioned.
|
||||
|
||||
### Consensus
|
||||
- #9293 `e591c10` [0.13 Backport #9053] IBD using chainwork instead of height and not using header timestamp (gmaxwell)
|
||||
- #9053 `5b93eee` IBD using chainwork instead of height and not using header timestamps (gmaxwell)
|
||||
|
||||
### RPC and other APIs
|
||||
- #8845 `1d048b9` Don't return the address of a P2SH of a P2SH (jnewbery)
|
||||
- #9041 `87fbced` keypoololdest denote Unix epoch, not GMT (s-matthew-english)
|
||||
- #9122 `f82c81b` fix getnettotals RPC description about timemillis (visvirial)
|
||||
- #9042 `5bcb05d` [rpc] ParseHash: Fail when length is not 64 (MarcoFalke)
|
||||
- #9194 `f26dab7` Add option to return non-segwit serialization via rpc (instagibbs)
|
||||
- #9347 `b711390` [0.13.2] wallet/rpc backports (MarcoFalke)
|
||||
- #9292 `c365556` Complain when unknown rpcserialversion is specified (sipa)
|
||||
- #9322 `49a612f` [qa] Don't set unknown rpcserialversion (MarcoFalke)
|
||||
|
||||
### Block and transaction handling
|
||||
- #8357 `ce0d817` [mempool] Fix relaypriority calculation error (maiiz)
|
||||
- #9267 `0a4aa87` [0.13 backport #9239] Disable fee estimates for a confirm target of 1 block (morcos)
|
||||
- #9196 `0c09d9f` Send tip change notification from invalidateblock (ryanofsky)
|
||||
|
||||
### P2P protocol and network code
|
||||
- #8995 `9ef3875` Add missing cs_main lock to ::GETBLOCKTXN processing (TheBlueMatt)
|
||||
- #9234 `94531b5` torcontrol: Explicitly request RSA1024 private key (laanwj)
|
||||
- #8637 `2cad5db` Compact Block Tweaks (rebase of #8235) (sipa)
|
||||
- #9058 `286e548` Fixes for p2p-compactblocks.py test timeouts on travis (#8842) (ryanofsky)
|
||||
- #8865 `4c71fc4` Decouple peer-processing-logic from block-connection-logic (TheBlueMatt)
|
||||
- #9117 `6fe3981` net: don't send feefilter messages before the version handshake is complete (theuni)
|
||||
- #9188 `ca1fd75` Make orphan parent fetching ask for witnesses (gmaxwell)
|
||||
- #9052 `3a3bcbf` Use RelevantServices instead of node_network in AttemptToEvict (gmaxwell)
|
||||
- #9048 `9460771` [0.13 backport #9026] Fix handling of invalid compact blocks (sdaftuar)
|
||||
- #9357 `03b6f62` [0.13 backport #9352] Attempt reconstruction from all compact block announcements (sdaftuar)
|
||||
- #9189 `b96a8f7` Always add default_witness_commitment with GBT client support (sipa)
|
||||
- #9253 `28d0f22` Fix calculation of number of bound sockets to use (TheBlueMatt)
|
||||
- #9199 `da5a16b` Always drop the least preferred HB peer when adding a new one (gmaxwell)
|
||||
|
||||
### Build system
|
||||
- #9169 `d1b4da9` build: fix qt5.7 build under macOS (theuni)
|
||||
- #9326 `a0f7ece` Update for OpenSSL 1.1 API (gmaxwell)
|
||||
- #9224 `396c405` Prevent FD_SETSIZE error building on OpenBSD (ivdsangen)
|
||||
|
||||
### GUI
|
||||
- #8972 `6f86b53` Make warnings label selectable (jonasschnelli) (MarcoFalke)
|
||||
- #9185 `6d70a73` Fix coincontrol sort issue (jonasschnelli)
|
||||
- #9094 `5f3a12c` Use correct conversion function for boost::path datadir (laanwj)
|
||||
- #8908 `4a974b2` Update bitcoin-qt.desktop (s-matthew-english)
|
||||
- #9190 `dc46b10` Plug many memory leaks (laanwj)
|
||||
|
||||
### Wallet
|
||||
- #9290 `35174a0` Make RelayWalletTransaction attempt to AcceptToMemoryPool (gmaxwell)
|
||||
- #9295 `43bcfca` Bugfix: Fundrawtransaction: don't terminate when keypool is empty (jonasschnelli)
|
||||
- #9302 `f5d606e` Return txid even if ATMP fails for new transaction (sipa)
|
||||
- #9262 `fe39f26` Prefer coins that have fewer ancestors, sanity check txn before ATMP (instagibbs)
|
||||
|
||||
### Tests and QA
|
||||
- #9159 `eca9b46` Wait for specific block announcement in p2p-compactblocks (ryanofsky)
|
||||
- #9186 `dccdc3a` Fix use-after-free in scheduler tests (laanwj)
|
||||
- #9168 `3107280` Add assert_raises_message to check specific error message (mrbandrews)
|
||||
- #9191 `29435db` 0.13.2 Backports (MarcoFalke)
|
||||
- #9077 `1d4c884` Increase wallet-dump RPC timeout (ryanofsky)
|
||||
- #9098 `ecd7db5` Handle zombies and cluttered tmpdirs (MarcoFalke)
|
||||
- #8927 `387ec9d` Add script tests for FindAndDelete in pre-segwit and segwit scripts (jl2012)
|
||||
- #9200 `eebc699` bench: Fix subtle counting issue when rescaling iteration count (laanwj)
|
||||
|
||||
### Miscellaneous
|
||||
- #8838 `094848b` Calculate size and weight of block correctly in CreateNewBlock() (jnewbery)
|
||||
- #8920 `40169dc` Set minimum required Boost to 1.47.0 (fanquake)
|
||||
- #9251 `a710a43` Improvement of documentation of command line parameter 'whitelist' (wodry)
|
||||
- #8932 `106da69` Allow bitcoin-tx to create v2 transactions (btcdrak)
|
||||
- #8929 `12428b4` add software-properties-common (sigwo)
|
||||
- #9120 `08d1c90` bug: Missed one "return false" in recent refactoring in #9067 (UdjinM6)
|
||||
- #9067 `f85ee01` Fix exit codes (UdjinM6)
|
||||
- #9340 `fb987b3` [0.13] Update secp256k1 subtree (MarcoFalke)
|
||||
- #9229 `b172377` Remove calls to getaddrinfo_a (TheBlueMatt)
|
||||
|
||||
Credits
|
||||
=======
|
||||
|
||||
Thanks to everyone who directly contributed to this release:
|
||||
|
||||
- Alex Morcos
|
||||
- BtcDrak
|
||||
- Cory Fields
|
||||
- fanquake
|
||||
- Gregory Maxwell
|
||||
- Gregory Sanders
|
||||
- instagibbs
|
||||
- Ivo van der Sangen
|
||||
- jnewbery
|
||||
- Johnson Lau
|
||||
- Jonas Schnelli
|
||||
- Luke Dashjr
|
||||
- maiiz
|
||||
- MarcoFalke
|
||||
- Masahiko Hyuga
|
||||
- Matt Corallo
|
||||
- matthias
|
||||
- mrbandrews
|
||||
- Pavel Janík
|
||||
- Pieter Wuille
|
||||
- randy-waterhouse
|
||||
- Russell Yanofsky
|
||||
- S. Matthew English
|
||||
- Steven
|
||||
- Suhas Daftuar
|
||||
- UdjinM6
|
||||
- Wladimir J. van der Laan
|
||||
- wodry
|
||||
|
||||
As well as everyone that helped translating on [Transifex](https://www.transifex.com/projects/p/bitcoin/).
|
||||
@@ -5,13 +5,16 @@
|
||||
bin_PROGRAMS += qt/test/test_bitcoin-qt
|
||||
TESTS += qt/test/test_bitcoin-qt
|
||||
|
||||
TEST_QT_MOC_CPP = qt/test/moc_uritests.cpp
|
||||
TEST_QT_MOC_CPP = \
|
||||
qt/test/moc_compattests.cpp \
|
||||
qt/test/moc_uritests.cpp
|
||||
|
||||
if ENABLE_WALLET
|
||||
TEST_QT_MOC_CPP += qt/test/moc_paymentservertests.cpp
|
||||
endif
|
||||
|
||||
TEST_QT_H = \
|
||||
qt/test/compattests.h \
|
||||
qt/test/uritests.h \
|
||||
qt/test/paymentrequestdata.h \
|
||||
qt/test/paymentservertests.h
|
||||
@@ -20,6 +23,7 @@ qt_test_test_bitcoin_qt_CPPFLAGS = $(AM_CPPFLAGS) $(BITCOIN_INCLUDES) $(BITCOIN_
|
||||
$(QT_INCLUDES) $(QT_TEST_INCLUDES) $(PROTOBUF_CFLAGS)
|
||||
|
||||
qt_test_test_bitcoin_qt_SOURCES = \
|
||||
qt/test/compattests.cpp \
|
||||
qt/test/test_main.cpp \
|
||||
qt/test/uritests.cpp \
|
||||
$(TEST_QT_H)
|
||||
|
||||
@@ -50,6 +50,7 @@ BITCOIN_TESTS =\
|
||||
test/bip32_tests.cpp \
|
||||
test/blockencodings_tests.cpp \
|
||||
test/bloom_tests.cpp \
|
||||
test/bswap_tests.cpp \
|
||||
test/coins_tests.cpp \
|
||||
test/compress_tests.cpp \
|
||||
test/crypto_tests.cpp \
|
||||
|
||||
@@ -15,6 +15,23 @@
|
||||
#include <byteswap.h>
|
||||
#endif
|
||||
|
||||
#if defined(__APPLE__)
|
||||
|
||||
#if !defined(bswap_16)
|
||||
|
||||
// Mac OS X / Darwin features; we include a check for bswap_16 because if it is already defined, protobuf has
|
||||
// defined these macros for us already; if it isn't, we do it ourselves. In either case, we get the exact same
|
||||
// result regardless which path was taken
|
||||
#include <libkern/OSByteOrder.h>
|
||||
#define bswap_16(x) OSSwapInt16(x)
|
||||
#define bswap_32(x) OSSwapInt32(x)
|
||||
#define bswap_64(x) OSSwapInt64(x)
|
||||
|
||||
#endif // !defined(bswap_16)
|
||||
|
||||
#else
|
||||
// Non-Mac OS X / non-Darwin
|
||||
|
||||
#if HAVE_DECL_BSWAP_16 == 0
|
||||
inline uint16_t bswap_16(uint16_t x)
|
||||
{
|
||||
@@ -44,4 +61,6 @@ inline uint64_t bswap_64(uint64_t x)
|
||||
}
|
||||
#endif // HAVE_DECL_BSWAP64
|
||||
|
||||
#endif // defined(__APPLE__)
|
||||
|
||||
#endif // BITCOIN_COMPAT_BYTESWAP_H
|
||||
|
||||
@@ -179,7 +179,7 @@ static std::vector<CAddress> convertSeed6(const std::vector<SeedSpec6> &vSeedsIn
|
||||
// one by discovery.
|
||||
CAddress GetLocalAddress(const CNetAddr *paddrPeer)
|
||||
{
|
||||
CAddress ret(CService("0.0.0.0",GetListenPort()), NODE_NONE);
|
||||
CAddress ret(CService("0.0.0.0",GetListenPort()), nLocalServices);
|
||||
CService addr;
|
||||
if (GetLocal(addr, paddrPeer))
|
||||
{
|
||||
|
||||
@@ -499,7 +499,10 @@ void BitcoinGUI::setClientModel(ClientModel *clientModel)
|
||||
// Propagate cleared model to child objects
|
||||
rpcConsole->setClientModel(nullptr);
|
||||
#ifdef ENABLE_WALLET
|
||||
walletFrame->setClientModel(nullptr);
|
||||
if (walletFrame)
|
||||
{
|
||||
walletFrame->setClientModel(nullptr);
|
||||
}
|
||||
#endif // ENABLE_WALLET
|
||||
unitDisplayControl->setOptionsModel(nullptr);
|
||||
}
|
||||
|
||||
23
src/qt/test/compattests.cpp
Normal file
23
src/qt/test/compattests.cpp
Normal file
@@ -0,0 +1,23 @@
|
||||
// Copyright (c) 2016 The Bitcoin Core developers
|
||||
// Distributed under the MIT software license, see the accompanying
|
||||
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||
|
||||
#include "paymentrequestplus.h" // this includes protobuf's port.h which defines its own bswap macos
|
||||
|
||||
#include "compattests.h"
|
||||
|
||||
#include "compat/byteswap.h"
|
||||
|
||||
void CompatTests::bswapTests()
|
||||
{
|
||||
// Sibling in bitcoin/src/test/bswap_tests.cpp
|
||||
uint16_t u1 = 0x1234;
|
||||
uint32_t u2 = 0x56789abc;
|
||||
uint64_t u3 = 0xdef0123456789abc;
|
||||
uint16_t e1 = 0x3412;
|
||||
uint32_t e2 = 0xbc9a7856;
|
||||
uint64_t e3 = 0xbc9a78563412f0de;
|
||||
QVERIFY(bswap_16(u1) == e1);
|
||||
QVERIFY(bswap_32(u2) == e2);
|
||||
QVERIFY(bswap_64(u3) == e3);
|
||||
}
|
||||
19
src/qt/test/compattests.h
Normal file
19
src/qt/test/compattests.h
Normal file
@@ -0,0 +1,19 @@
|
||||
// Copyright (c) 2009-2015 The Bitcoin Core developers
|
||||
// Distributed under the MIT software license, see the accompanying
|
||||
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||
|
||||
#ifndef BITCOIN_QT_TEST_COMPATTESTS_H
|
||||
#define BITCOIN_QT_TEST_COMPATTESTS_H
|
||||
|
||||
#include <QObject>
|
||||
#include <QTest>
|
||||
|
||||
class CompatTests : public QObject
|
||||
{
|
||||
Q_OBJECT
|
||||
|
||||
private Q_SLOTS:
|
||||
void bswapTests();
|
||||
};
|
||||
|
||||
#endif // BITCOIN_QT_TEST_COMPATTESTS_H
|
||||
@@ -8,6 +8,7 @@
|
||||
|
||||
#include "util.h"
|
||||
#include "uritests.h"
|
||||
#include "compattests.h"
|
||||
|
||||
#ifdef ENABLE_WALLET
|
||||
#include "paymentservertests.h"
|
||||
@@ -48,6 +49,9 @@ int main(int argc, char *argv[])
|
||||
if (QTest::qExec(&test2) != 0)
|
||||
fInvalid = true;
|
||||
#endif
|
||||
CompatTests test4;
|
||||
if (QTest::qExec(&test4) != 0)
|
||||
fInvalid = true;
|
||||
|
||||
return fInvalid;
|
||||
}
|
||||
|
||||
26
src/test/bswap_tests.cpp
Normal file
26
src/test/bswap_tests.cpp
Normal file
@@ -0,0 +1,26 @@
|
||||
// Copyright (c) 2016 The Bitcoin Core developers
|
||||
// Distributed under the MIT software license, see the accompanying
|
||||
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
||||
|
||||
#include "compat/byteswap.h"
|
||||
#include "test/test_bitcoin.h"
|
||||
|
||||
#include <boost/test/unit_test.hpp>
|
||||
|
||||
BOOST_FIXTURE_TEST_SUITE(bswap_tests, BasicTestingSetup)
|
||||
|
||||
BOOST_AUTO_TEST_CASE(bswap_tests)
|
||||
{
|
||||
// Sibling in bitcoin/src/qt/test/compattests.cpp
|
||||
uint16_t u1 = 0x1234;
|
||||
uint32_t u2 = 0x56789abc;
|
||||
uint64_t u3 = 0xdef0123456789abc;
|
||||
uint16_t e1 = 0x3412;
|
||||
uint32_t e2 = 0xbc9a7856;
|
||||
uint64_t e3 = 0xbc9a78563412f0de;
|
||||
BOOST_CHECK(bswap_16(u1) == e1);
|
||||
BOOST_CHECK(bswap_32(u2) == e2);
|
||||
BOOST_CHECK(bswap_64(u3) == e3);
|
||||
}
|
||||
|
||||
BOOST_AUTO_TEST_SUITE_END()
|
||||
Reference in New Issue
Block a user