Merge bitcoin/bitcoin#34270: [28.x] Backports

514cf39533 doc: update release notes for v28.x (fanquake)
3dd011ee34 guix: Fix `osslsigncode` tests (Hennadii Stepanov)
38d338dbcc Remove unreliable seed from chainparams.cpp, and the associated README (SatsAndSports)

Pull request description:

  Backports:
  * #33723
  * #34227

ACKs for top commit:
  willcl-ark:
    ACK 514cf39533
  marcofleon:
    crACK 514cf39533

Tree-SHA512: b736192b842d70c84e6a5530b1bca2d095d60fcc265e52c8cdc61d81cfdbd6b6dd3d658f2ee9c27f3ae76a3c7bc79e8d0191242b357dba19e019acb31d7756dd

.github/actions/configure-environment/action.yml

@@ -17,7 +17,7 @@ runs:
     - name: Set cache hashes
       shell: bash
       run: |
-        echo "DEPENDS_HASH=$(git ls-tree HEAD depends "ci/test/$FILE_ENV" | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
+        echo "DEPENDS_HASH=$(git ls-tree HEAD depends "$FILE_ENV" | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
         echo "PREVIOUS_RELEASES_HASH=$(git ls-tree HEAD test/get_previous_releases.py | sha256sum | cut -d' ' -f1)" >> $GITHUB_ENV
 
     - name: Get container name

configure.ac

@@ -2,7 +2,7 @@ AC_PREREQ([2.69])
 define(_CLIENT_VERSION_MAJOR, 28)
 define(_CLIENT_VERSION_MINOR, 3)
 define(_CLIENT_VERSION_BUILD, 0)
-define(_CLIENT_VERSION_RC, 2)
+define(_CLIENT_VERSION_RC, 0)
 define(_CLIENT_VERSION_IS_RELEASE, true)
 define(_COPYRIGHT_YEAR, 2025)
 define(_COPYRIGHT_HOLDERS,[The %s developers])

contrib/guix/manifest.scm

@@ -3,6 +3,7 @@
              ((gnu packages bash) #:select (bash-minimal))
              (gnu packages bison)
              ((gnu packages certs) #:select (nss-certs))
+             ((gnu packages check) #:select (libfaketime))
              ((gnu packages cmake) #:select (cmake-minimal))
              (gnu packages commencement)
              (gnu packages compression)
@@ -221,7 +222,17 @@ and abstract ELF, PE and MachO formats.")
                (base32
                 "1j47vwq4caxfv0xw68kw5yh00qcpbd56d7rq6c483ma3y7s96yyz"))))
     (build-system cmake-build-system)
-    (inputs (list openssl))
+    (arguments
+     (list
+      #:phases
+      #~(modify-phases %standard-phases
+          (replace 'check
+            (lambda* (#:key tests? #:allow-other-keys)
+              (if tests?
+                  (invoke "faketime" "-f" "@2025-01-01 00:00:00" ;; Tests fail after 2025.
+                          "ctest" "--output-on-failure" "--no-tests=error")
+                  (format #t "test suite not run~%")))))))
+    (inputs (list libfaketime openssl))
     (home-page "https://github.com/mtrojnar/osslsigncode")
     (synopsis "Authenticode signing and timestamping tool")
     (description "osslsigncode is a small tool that implements part of the

contrib/seeds/README.md

@@ -8,7 +8,7 @@ and remove old versions as necessary (at a minimum when SeedsServiceFlags()
 changes its default return value, as those are the services which seeds are added
 to addrman with).
 
-The seeds compiled into the release are created from sipa's, achow101's and luke-jr's
+The seeds compiled into the release are created from sipa's and achow101's
 DNS seed, virtu's crawler, and fjahr's community AS map data. Run the following commands
 from the `/contrib/seeds` directory:
 
@@ -16,7 +16,6 @@ from the `/contrib/seeds` directory:
 curl https://bitcoin.sipa.be/seeds.txt.gz | gzip -dc > seeds_main.txt
 curl https://mainnet.achownodes.xyz/seeds.txt.gz | gzip -dc >> seeds_main.txt
 curl https://21.ninja/seeds.txt.gz | gzip -dc >> seeds_main.txt
-curl https://luke.dashjr.org/programs/bitcoin/files/charts/seeds.txt >> seeds_main.txt
 curl https://testnet.achownodes.xyz/seeds.txt.gz | gzip -dc > seeds_test.txt
 curl https://raw.githubusercontent.com/fjahr/asmap-data/main/latest_asmap.dat > asmap-filled.dat
 python3 makeseeds.py -a asmap-filled.dat -s seeds_main.txt > nodes_main.txt

doc/man/bitcoin-cli.1

@@ -1,7 +1,7 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH BITCOIN-CLI "1" "October 2025" "bitcoin-cli v28.3.0rc2" "User Commands"
+.TH BITCOIN-CLI "1" "October 2025" "bitcoin-cli v28.3.0" "User Commands"
 .SH NAME
-bitcoin-cli \- manual page for bitcoin-cli v28.3.0rc2
+bitcoin-cli \- manual page for bitcoin-cli v28.3.0
 .SH SYNOPSIS
 .B bitcoin-cli
 [\fI\,options\/\fR] \fI\,<command> \/\fR[\fI\,params\/\fR]  \fI\,Send command to Bitcoin Core\/\fR
@@ -15,7 +15,7 @@ bitcoin-cli \- manual page for bitcoin-cli v28.3.0rc2
 .B bitcoin-cli
 [\fI\,options\/\fR] \fI\,help <command>      Get help for a command\/\fR
 .SH DESCRIPTION
-Bitcoin Core RPC client version v28.3.0rc2
+Bitcoin Core RPC client version v28.3.0
 .SH OPTIONS
 .HP
 \-?

doc/man/bitcoin-qt.1

@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH BITCOIN-QT "1" "October 2025" "bitcoin-qt v28.3.0rc2" "User Commands"
+.TH BITCOIN-QT "1" "October 2025" "bitcoin-qt v28.3.0" "User Commands"
 .SH NAME
-bitcoin-qt \- manual page for bitcoin-qt v28.3.0rc2
+bitcoin-qt \- manual page for bitcoin-qt v28.3.0
 .SH SYNOPSIS
 .B bitcoin-qt
 [\fI\,command-line options\/\fR] [\fI\,URI\/\fR]
 .SH DESCRIPTION
-Bitcoin Core version v28.3.0rc2
+Bitcoin Core version v28.3.0
 .PP
 Optional URI is a Bitcoin address in BIP21 URI format.
 .SH OPTIONS

doc/man/bitcoin-tx.1

@@ -1,7 +1,7 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH BITCOIN-TX "1" "October 2025" "bitcoin-tx v28.3.0rc2" "User Commands"
+.TH BITCOIN-TX "1" "October 2025" "bitcoin-tx v28.3.0" "User Commands"
 .SH NAME
-bitcoin-tx \- manual page for bitcoin-tx v28.3.0rc2
+bitcoin-tx \- manual page for bitcoin-tx v28.3.0
 .SH SYNOPSIS
 .B bitcoin-tx
 [\fI\,options\/\fR] \fI\,<hex-tx> \/\fR[\fI\,commands\/\fR]  \fI\,Update hex-encoded bitcoin transaction\/\fR
@@ -9,7 +9,7 @@ bitcoin-tx \- manual page for bitcoin-tx v28.3.0rc2
 .B bitcoin-tx
 [\fI\,options\/\fR] \fI\,-create \/\fR[\fI\,commands\/\fR]   \fI\,Create hex-encoded bitcoin transaction\/\fR
 .SH DESCRIPTION
-Bitcoin Core bitcoin\-tx utility version v28.3.0rc2
+Bitcoin Core bitcoin\-tx utility version v28.3.0
 .SH OPTIONS
 .HP
 \-?

doc/man/bitcoin-util.1

@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH BITCOIN-UTIL "1" "October 2025" "bitcoin-util v28.3.0rc2" "User Commands"
+.TH BITCOIN-UTIL "1" "October 2025" "bitcoin-util v28.3.0" "User Commands"
 .SH NAME
-bitcoin-util \- manual page for bitcoin-util v28.3.0rc2
+bitcoin-util \- manual page for bitcoin-util v28.3.0
 .SH SYNOPSIS
 .B bitcoin-util
 [\fI\,options\/\fR] [\fI\,commands\/\fR]  \fI\,Do stuff\/\fR
 .SH DESCRIPTION
-Bitcoin Core bitcoin\-util utility version v28.3.0rc2
+Bitcoin Core bitcoin\-util utility version v28.3.0
 .SH OPTIONS
 .HP
 \-?

doc/man/bitcoin-wallet.1

@@ -1,9 +1,9 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH BITCOIN-WALLET "1" "October 2025" "bitcoin-wallet v28.3.0rc2" "User Commands"
+.TH BITCOIN-WALLET "1" "October 2025" "bitcoin-wallet v28.3.0" "User Commands"
 .SH NAME
-bitcoin-wallet \- manual page for bitcoin-wallet v28.3.0rc2
+bitcoin-wallet \- manual page for bitcoin-wallet v28.3.0
 .SH DESCRIPTION
-Bitcoin Core bitcoin\-wallet version v28.3.0rc2
+Bitcoin Core bitcoin\-wallet version v28.3.0
 .PP
 bitcoin\-wallet is an offline tool for creating and interacting with Bitcoin Core wallet files.
 By default bitcoin\-wallet will act on wallets in the default mainnet wallet directory in the datadir.

doc/man/bitcoind.1

@@ -1,12 +1,12 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH BITCOIND "1" "October 2025" "bitcoind v28.3.0rc2" "User Commands"
+.TH BITCOIND "1" "October 2025" "bitcoind v28.3.0" "User Commands"
 .SH NAME
-bitcoind \- manual page for bitcoind v28.3.0rc2
+bitcoind \- manual page for bitcoind v28.3.0
 .SH SYNOPSIS
 .B bitcoind
 [\fI\,options\/\fR]                     \fI\,Start Bitcoin Core\/\fR
 .SH DESCRIPTION
-Bitcoin Core version v28.3.0rc2
+Bitcoin Core version v28.3.0
 .SH OPTIONS
 .HP
 \-?

doc/release-notes.md

@@ -1,6 +1,6 @@
-Bitcoin Core version 28.3rc2 is now available from:
+Bitcoin Core version 28.x is now available from:
 
-  <https://bitcoincore.org/bin/bitcoin-core-28.3/test.rc2/>
+  <https://bitcoincore.org/bin/bitcoin-core-28.x/>
 
 This release includes various bug fixes and performance
 improvements, as well as updated translations.
@@ -37,72 +37,21 @@ unsupported systems.
 Notable changes
 ===============
 
-### Mempool & Policy
-
- The minimum block feerate (`-blockmintxfee`) has been changed to 1 satoshi per kvB. It can still be changed using the
-configuration option.
-
-- The default minimum relay feerate (`-minrelaytxfee`) and incremental relay feerate (`-incrementalrelayfee`) have been
-changed to 100 satoshis per kvB. They can still be changed using their respective configuration options, but it is
-recommended to change both together if you decide to do so.
-  - Other minimum feerates (e.g. the dust feerate, the minimum returned by the fee estimator, and all feerates used by
-  the wallet) remain unchanged. The mempool minimum feerate still changes in response to high volume.
-  - Note that unless these lower defaults are widely adopted across the network, transactions created with lower fee
-  rates are not guaranteed to propagate or confirm. The wallet feerates remain unchanged; `-mintxfee` must be changed
-  before attempting to create transactions with lower feerates using the wallet.
-
-- #33106 policy: lower the default blockmintxfee, incrementalrelayfee, minrelaytxfee
-- #33504 mempool: Do not enforce TRUC checks on reorg
-
 ### P2P
 
-- #33395 net: do not apply whitelist permissions to onion inbounds
-
-### Test
-
-- #32765 test: Fix list index out of range error in feature_bip68_sequence.py
-- #33001 test: Do not pass tests on unhandled exceptions
-- #30125 test: improve BDB parser (handle internal/overflow pages, support all page sizes)
-- #30948 test: Add missing sync_mempools() to fill_mempool()
-- #30784 test: add BulkTransaction helper to unit test transaction utils
+- #33723 chainparams: remove dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us
 
 ### Build
 
-- #32678 guix: warn and abort when SOURCE_DATE_EPOCH is set
-- #32943 depends: Force CMAKE_EXPORT_NO_PACKAGE_REGISTRY=TRUE
-- #33073 guix: warn SOURCE_DATE_EPOCH set in guix-codesign
-- #33563 build: fix depends Qt download link
-
-### Doc
-
-- #32776 doc: taproot became always active in v24.0
-- #32777 doc: fix Transifex 404s
-- #33070 doc/zmq: fix unix socket path example
-- #33133 rpc: fix getpeerinfo ping duration unit docs
-- #33236 doc: Remove wrong and redundant doxygen tag
-
-### Misc
-
-- #33340 Fix benchmark CSV output
-- #33482 contrib: fix macOS deployment with no translations
+- #34227 guix: Fix `osslsigncode` tests
 
 Credits
 =======
 
 Thanks to everyone who directly contributed to this release:
-- 0xB10C
-- amisha
-- fanquake
-- glozow
+
 - Hennadii Stepanov
-- MarcoFalke
-- Martin Zumsande
-- romanz
-- Sjors Provoost
-- theStack
-- Vasil Dimov
-- willcl-ark
-- zaidmstrr
+- SatsAndSports
 
 As well as to everyone that helped with translations on
 [Transifex](https://explore.transifex.com/bitcoin/bitcoin/).

src/kernel/chainparams.cpp

@@ -144,7 +144,6 @@ public:
         // release ASAP to avoid it where possible.
         vSeeds.emplace_back("seed.bitcoin.sipa.be."); // Pieter Wuille, only supports x1, x5, x9, and xd
         vSeeds.emplace_back("dnsseed.bluematt.me."); // Matt Corallo, only supports x9
-        vSeeds.emplace_back("dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us."); // Luke Dashjr
         vSeeds.emplace_back("seed.bitcoin.jonasschnelli.ch."); // Jonas Schnelli, only supports x1, x5, x9, and xd
         vSeeds.emplace_back("seed.btc.petertodd.net."); // Peter Todd, only supports x1, x5, x9, and xd
         vSeeds.emplace_back("seed.bitcoin.sprovoost.nl."); // Sjors Provoost