highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-30 01:30:07 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
fanquake 143ace65db
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion 
fa46cc22bc696e6845915ae91d6b68e36bf4c242 Remove deprecated -rpcserialversion (MarcoFalke)

Pull request description:

  The flag is problematic for many reasons:

  * It is deprecated
  * It is a global flag, requiring a restart to change, as opposed to a flag that can be set on each RPC invocation
  * It may be hidden in config files by accident, hard to debug, causing LND crashes and bugs, see https://github.com/bitcoin/bitcoin/issues/28730#issuecomment-1780940868
  * It makes performance improvements harder to implement: https://github.com/bitcoin/bitcoin/pull/17529#issuecomment-556082818

  Fix all issues by removing it.

  If there is a use-case, likely a per-RPC flag can be added, if needed.

ACKs for top commit:
  ajtowns:
    crACK fa46cc22bc696e6845915ae91d6b68e36bf4c242
  TheCharlatan:
    lgtm ACK fa46cc22bc696e6845915ae91d6b68e36bf4c242

Tree-SHA512: 96ba1c60356ce93954fe5c2a59045771c6d1516ad0d9dc436ef1800a1f1b0153f0d5fb78ca99d53ad54ba25fbce36962bdf1d4325aceedfc8154a61347a6a915
2024-01-05 10:42:10 +00:00
..
abort.cpp
refactor: Remove calls to StartShutdown from KernelNotifications
2023-12-04 15:39:15 -04:00
abort.h
refactor: Remove calls to StartShutdown from KernelNotifications
2023-12-04 15:39:15 -04:00
blockmanager_args.cpp
refactor: Move stopafterblockimport handling out of blockstorage
2023-07-11 12:00:57 +02:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
refactor: Use reference instead of pointer in IsBlockPruned
2023-12-07 12:02:54 +01:00
blockstorage.h
refactor: Use reference instead of pointer in IsBlockPruned
2023-12-07 12:02:54 +01:00
caches.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
caches.h
…
chainstate.cpp
refactor: Remove call to ShutdownRequested from chainstate init
2023-12-04 15:39:15 -04:00
chainstate.h
refactor: Remove call to ShutdownRequested from chainstate init
2023-12-04 15:39:15 -04:00
chainstatemanager_args.cpp
refactor: Move {MAX,DEFAULT}_SCRIPTCHECK_THREADS constants
2023-10-03 10:52:17 +01:00
chainstatemanager_args.h
refactor: Move {MAX,DEFAULT}_SCRIPTCHECK_THREADS constants
2023-10-03 10:52:17 +01:00
coin.cpp
…
coin.h
…
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
…
connection_types.cpp
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
connection_types.h
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
context.cpp
kernel: Add notification interface
2023-05-20 12:03:22 +02:00
context.h
refactor: Add NodeContext::shutdown member
2023-12-04 15:39:15 -04:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
…
eviction.cpp
…
eviction.h
…
interface_ui.cpp
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interface_ui.h
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interfaces.cpp
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
2024-01-05 10:42:10 +00:00
kernel_notifications.cpp
refactor: Remove calls to StartShutdown from KernelNotifications
2023-12-04 15:39:15 -04:00
kernel_notifications.h
refactor: Remove calls to StartShutdown from KernelNotifications
2023-12-04 15:39:15 -04:00
mempool_args.cpp
mempool: persist with XOR
2023-11-09 19:44:50 +01:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
miner.cpp
[refactor] rewrite BlockAssembler inBlock and failedTx as sets of txids
2023-11-10 16:44:45 +01:00
miner.h
[refactor] rewrite BlockAssembler inBlock and failedTx as sets of txids
2023-11-10 16:44:45 +01:00
mini_miner.cpp
[refactor] Miniminer var cached_descendants to descendants
2023-11-07 08:56:43 -06:00
mini_miner.h
[refactor] updating miniminer comments to be more accurate
2023-11-08 14:45:18 -06:00
minisketchwrapper.cpp
Use steady clock in SeedStrengthen and FindBestImplementation
2023-03-02 14:48:28 +01:00
minisketchwrapper.h
…
peerman_args.cpp
Merge bitcoin/bitcoin#28149: net processing: clamp PeerManager::Options user input
2023-08-09 14:26:03 +02:00
peerman_args.h
[net processing] Introduce PeerManager options
2023-07-24 18:30:59 +02:00
protocol_version.h
Rename version.h to node/protocol_version.h
2023-11-30 11:28:31 +01:00
psbt.cpp
…
psbt.h
…
README.md
…
transaction.cpp
Use Txid in COutpoint
2023-11-21 13:15:44 +00:00
transaction.h
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
txreconciliation.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
txreconciliation.h
[net processing] Move -txreconciliation to PeerManager::Options
2023-07-24 18:35:28 +02:00
utxo_snapshot.cpp
lint: remove /* Continued */ markers from codebase
2023-08-03 17:52:24 +01:00
utxo_snapshot.h
refactor: Remove unused nchaintx from SnapshotMetadata constructor
2023-10-12 11:14:32 +02:00
validation_cache_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
validation_cache_args.h
…

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.