highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-07-30 23:07:42 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
0997019e7681efb00847a7246c15ac8f235128d8
bitcoin/src/node
History
Wladimir J. van der Laan 8d82eddee6 Merge #19145: Add hash_type MUHASH for gettxoutsetinfo 
e987ae5a55 test: Add test for deterministic UTXO set hash results (Fabian Jahr)
6ccc8fc067 test: Add test for gettxoutsetinfo RPC with MuHash (Fabian Jahr)
0d3b2f643d rpc: Add hash_type MUHASH to gettxoutsetinfo (Fabian Jahr)
2474645f3b refactor: Separate hash and stats calculation in coinstats (Fabian Jahr)
a1fcceac69 refactor: Improve encapsulation between MuHash3072 and Num3072 (Fabian Jahr)

Pull request description:

  This is another Pr in the series PRs for Coinstatsindex (see overview in #18000). This PR adds the `hash_type` option `muhash` to `gettxoutsetinfo` through which the user can calculate the serialized muhash of the utxo set. This PR does not use the index yet.

ACKs for top commit:
  Sjors:
    tACK e987ae5
  achow101:
    ACK e987ae5a55
  jonatack:
    Tested re-ACK e987ae5a55 per `git diff 3506d90 e987ae5`, reviewed diff, debug built, ran gettxoutsetinfo -signet and help on this branch vs master, at height 23127 both returned `hash_serialized_2` of `2b72d65f3b6efb2311f58374ea2b939abf49684d44f4bafda45faa3b5452a454` and this branch returned `muhash` of `c9f1ff12d345ccf9939c6bbf087e6f7399b6115adee1569287e9c5c43dbb475c`
  ryanofsky:
    Code review ACK e987ae5a55. Looks very good. I left one suggestion to simplify code, but feel free to ignore it here and maybe consider it for later since PR has already had a lot of review.

Tree-SHA512: 9a739ce375e73749fa69a467262b60d3e5314ef384e2d7150b3bbc8e4125cd9fd1db95306623bb9a632fcbaf5d9d2bf2f5cc43bf717d4ff5e2c9c4b52dd9296c
2021-02-12 10:47:41 +01:00
..
coin.cpp
…
coin.h
…
coinstats.cpp
Merge #19145: Add hash_type MUHASH for gettxoutsetinfo
2021-02-12 10:47:41 +01:00
coinstats.h
rpc: Add hash_type MUHASH to gettxoutsetinfo
2021-01-30 17:38:21 +01:00
context.cpp
Remove the remaining fee estimation globals
2020-12-03 12:56:37 +01:00
context.h
Remove the remaining fee estimation globals
2020-12-03 12:56:37 +01:00
interfaces.cpp
validation: Move FindForkInGlobalIndex to BlockManager
2021-01-28 14:15:26 -05:00
psbt.cpp
…
psbt.h
…
README.md
…
transaction.cpp
[refactor] return MempoolAcceptResult
2021-02-09 07:01:52 -08:00
transaction.h
scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
2020-11-26 09:05:59 +00:00
ui_interface.cpp
…
ui_interface.h
…
utxo_snapshot.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

The src/node/ directory is a new directory introduced in #14978 and at the moment is sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.