merge-script c20a5ce106 Merge bitcoin/bitcoin#31901: contrib: Add deterministic-unittest-coverage ...

fa99c3b544 test: Exclude SeedStartup from coverage counts (MarcoFalke)
fa579d663d contrib: Add deterministic-unittest-coverage (MarcoFalke)
fa3940b1cb contrib: deterministic-fuzz-coverage fixups (MarcoFalke)
faf905b9b6 doc: Remove unused -fPIC (MarcoFalke)
fa1e0a7228 gitignore: target/ (MarcoFalke)

Pull request description:

  The `contrib/devtools/test_deterministic_coverage.sh` script is problematic:

  * It is written in bash. This can lead to issues when running with the ancient bash version shipped by macOS by default, or can lead to other compatibility issues, such as https://github.com/bitcoin/bitcoin/pull/31588#discussion_r1946784827. Also, pipefail isn't set, so IO errors may be silently ignored.
  * It is based on gcov. This can lead to issues, such as https://github.com/bitcoin/bitcoin/pull/31588#pullrequestreview-2602169248 (possibly due to prefix-map), or https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2646395385 (gcovr processing error), or https://github.com/bitcoin/bitcoin/pull/31588#pullrequestreview-2605954001 (gcovr assertion error).
  * The script is severely outdated, with the last update to `NON_DETERMINISTIC_TESTS` being in the prior decade.

  Instead of patching around all issues one-by-one, just provide a fresh rewrite, based on the recently added `deterministic-fuzz-coverage` tool based on clang, llvm-cov, and llvm-profdata. (Initial feedback indicates that this is a more promising attempt: https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2649356408 and https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2649354598).

  The new tool also sets `RANDOM_CTX_SEED=21` as suggested by hodlinator in https://github.com/bitcoin/bitcoin/pull/31588#issuecomment-2650784726.

ACKs for top commit:
  Prabhat1308:
    Concept ACK [`fa99c3b`](fa99c3b544)
  hodlinator:
    re-ACK fa99c3b544
  brunoerg:
    light ACK fa99c3b544
  dergoegge:
    tACK fa99c3b544
  janb84:
    Concept ACK [fa99c3b](fa99c3b544)

Tree-SHA512: 491d5e6413d929395a5c7caea54817bdc1a0e00562c9728a374d4e92f2e2017dba4a770ecdb2e7317e049df9fdeb390d83c90dff9aa5709f97aa3f6a0e70cdb4

2025-03-13 12:30:32 +08:00

..

util

fuzz: in FuzzedSock::GetSockName(), return a random-length name

2025-02-12 11:39:37 -05:00

addition_overflow.cpp

build, msvc: Build fuzz.exe binary

2024-04-18 10:27:25 +01:00

addrman.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

streams: remove AutoFile::Get() entirely

2024-09-13 21:59:29 -04:00

banman.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

base_encode_decode.cpp

fuzz: Add fuzzing for max_ret_len in DecodeBase58/DecodeBase58Check

2025-01-04 13:18:29 +01:00

bech32.cpp

Fuzz HRP of bech32 as well

2024-10-19 19:16:04 +02:00

bip324.cpp

refactor: Remove Span operator==, Use std::ranges::equal

2024-08-13 07:44:31 +02:00

bitdeque.cpp

fuzz: Avoid timeout in bitdeque

2023-12-06 15:44:38 +01:00

bitset.cpp

random: convert XoRoShiRo128PlusPlus into full RNG

2024-07-01 10:26:46 -04:00

block_header.cpp

refactor: Hand-replace some uint256S -> uint256

2024-08-05 14:51:47 +02:00

block_index.cpp

qa: a fuzz target for the block index database

2024-05-29 18:55:04 +02:00

block.cpp

fuzz: Drop unused version from fuzz input format

2023-11-30 11:27:21 +01:00

blockfilter.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

bloom_filter.cpp

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

buffered_file.cpp

fuzz: make FuzzedDataProvider usage deterministic

2023-12-09 19:31:06 +01:00

chain.cpp

…

checkqueue.cpp

[checkqueue] support user-defined return type through std::optional

2024-12-02 16:25:13 -05:00

cluster_linearize.cpp

clusterlin: merge two DepGraph fuzz tests into simulation test

2024-10-07 13:49:36 -04:00

CMakeLists.txt

fuzz: implement targets for PCP and NAT-PMP port mapping requests

2025-02-12 11:39:37 -05:00

coins_view.cpp

coins, refactor: Split up AddFlags to remove invalid states

2024-12-02 13:48:04 +01:00

coinscache_sim.cpp

refactor: Rely on returned value of GetCoin instead of parameter

2024-09-18 20:03:47 +02:00

connman.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20.cpp

Merge bitcoin/bitcoin#29043: fuzz: make FuzzedDataProvider usage deterministic

2024-09-04 15:04:53 -04:00

crypto_chacha20poly1305.cpp

fuzz: reduce number of iterations in crypto_aeadchacha20poly1305 target

2024-09-05 17:56:54 -03:00

crypto_common.cpp

crypto: Add missing WriteBE16 function

2024-09-21 12:37:36 +02:00

crypto_diff_fuzz_chacha20.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

fuzz: make FuzzedDataProvider usage deterministic

2023-12-09 19:31:06 +01:00

cuckoocache.cpp

fuzz: make FuzzedDataProvider usage deterministic

2023-12-09 19:31:06 +01:00

decode_tx.cpp

…

descriptor_parse.cpp

Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string

2024-08-28 15:56:15 +01:00

deserialize.cpp

scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}

2024-10-26 23:44:15 +02:00

eval_script.cpp

…

fee_rate.cpp

…

feefrac.cpp

Add fuzz test for FeeFrac

2024-03-18 10:32:00 -04:00

feeratediagram.cpp

Avoid explicitly computing diagram; compare based on chunks

2024-04-22 09:36:36 -04:00

fees.cpp

util: move fees.h and error.h to common/messages.h

2024-05-16 10:16:08 -05:00

flatfile.cpp

…

float.cpp

refactor: Avoid GCC false positive error

2025-01-20 17:43:58 +01:00

fuzz.cpp

test: Exclude SeedStartup from coverage counts

2025-02-25 10:15:00 +01:00

fuzz.h

fuzz: Use std::span in FuzzBufferType

2024-06-12 15:21:31 +02:00

FuzzedDataProvider.h

fuzz: add cstdlib to FuzzedDataProvider

2024-12-09 17:01:10 +00:00

golomb_rice.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

headerssync.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

hex.cpp

Merge bitcoin/bitcoin#30618: test: support std::optional in BOOST_CHECK_* and increase FromUserHex fuzz feature coverage

2024-09-12 12:36:37 -04:00

http_request.cpp

refactor: Remove call to ShutdownRequested from HTTPRequest

2023-12-04 15:39:15 -04:00

i2p.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

integer.cpp

Merge bitcoin/bitcoin#30661: fuzz: Test headers pre-sync through p2p

2024-09-16 13:59:22 -04:00

key_io.cpp

test: Use ECC_Context helper in bench and fuzz tests

2024-05-09 15:56:04 +02:00

key.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

kitchen_sink.cpp

rpc: clarify ALREADY_IN_CHAIN rpc errors

2024-08-05 15:45:58 +01:00

load_external_block_file.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

locale.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

merkleblock.cpp

refactor: Use Txid in CMerkleBlock

2023-11-28 17:49:41 +01:00

message.cpp

Merge bitcoin/bitcoin#29043: fuzz: make FuzzedDataProvider usage deterministic

2024-09-04 15:04:53 -04:00

mini_miner.cpp

miner: bugfix: fix duplicate weight reservation in block assembler

2025-02-04 11:53:03 -05:00

miniscript.cpp

refactor: Drop deprecated space in operator""_mst

2024-11-11 12:14:08 +01:00

minisketch.cpp

[fuzz] Improve fuzzing stability for minisketch harness

2023-12-14 20:10:21 +00:00

muhash.cpp

Add a fuzz test for Num3072 multiplication and inversion

2025-01-09 10:11:46 -05:00

multiplication_overflow.cpp

build, msvc: Build fuzz.exe binary

2024-04-18 10:27:25 +01:00

net_permissions.cpp

Merge bitcoin/bitcoin#27114: p2p: Allow whitelisting manual connections

2024-03-12 12:59:02 -04:00

net.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

netaddress.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

overflow.cpp

fuzz: Add fuzz test for checked and saturating add and left shift

2025-01-15 15:44:03 +01:00

p2p_handshake.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

p2p_headers_presync.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

p2p_transport_serialization.cpp

scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}

2024-10-26 23:44:15 +02:00

package_eval.cpp

Merge bitcoin/bitcoin#31486: fuzz: Abort when using global PRNG without re-seed

2024-12-17 12:55:38 -05:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

Remove wallet::ParseISO8601DateTime, use ParseISO8601DateTime instead

2024-12-02 15:09:31 +01:00

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

fuzz: Limit parse_univalue input length

2024-07-19 15:39:02 +02:00

partially_downloaded_block.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

pcp.cpp

fuzz: implement targets for PCP and NAT-PMP port mapping requests

2025-02-12 11:39:37 -05:00

policy_estimator_io.cpp

fuzz: Remove FuzzedAutoFileProvider

2023-11-14 17:41:26 +01:00

policy_estimator.cpp

Merge bitcoin/bitcoin#29043: fuzz: make FuzzedDataProvider usage deterministic

2024-09-04 15:04:53 -04:00

poolresource.cpp

refactor: Remove Span operator==, Use std::ranges::equal

2024-08-13 07:44:31 +02:00

pow.cpp

Add FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in PoW check

2024-09-02 15:43:33 +01:00

prevector.cpp

Merge bitcoin/bitcoin#29043: fuzz: make FuzzedDataProvider usage deterministic

2024-09-04 15:04:53 -04:00

primitives_transaction.cpp

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

process_message.cpp

Merge bitcoin/bitcoin#31486: fuzz: Abort when using global PRNG without re-seed

2024-12-17 12:55:38 -05:00

process_messages.cpp

Merge bitcoin/bitcoin#31486: fuzz: Abort when using global PRNG without re-seed

2024-12-17 12:55:38 -05:00

protocol.cpp

scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}

2024-10-26 23:44:15 +02:00

psbt.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

random.cpp

random: drop ad-hoc Shuffle in favor of std::shuffle

2024-07-06 09:06:36 -04:00

rbf.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

rolling_bloom_filter.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

rpc.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

script_assets_test_minimizer.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

script_descriptor_cache.cpp

…

script_flags.cpp

Fix IWYU for the script_flags fuzz target

2023-11-23 17:57:53 +01:00

script_format.cpp

fuzz: make FuzzedDataProvider usage deterministic

2023-12-09 19:31:06 +01:00

script_interpreter.cpp

fuzz: make FuzzedDataProvider usage deterministic

2023-12-09 19:31:06 +01:00

script_ops.cpp

…

script_parsing.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

script_sigcache.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

script_sign.cpp

Merge bitcoin/bitcoin#30561: refactor: move SignSignature helpers to test utils

2024-09-20 16:05:28 +01:00

script.cpp

[test]: remove ExtractDestination false assertion for ANCHOR script

2024-08-09 11:18:45 +01:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

test: replace deprecated secp256k1 context flags usage

2024-08-21 00:41:56 +02:00

secp256k1_ecdsa_signature_parse_der_lax.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

signature_checker.cpp

…

signet.cpp

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

socks5.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

span.cpp

refactor: Remove Span operator==, Use std::ranges::equal

2024-08-13 07:44:31 +02:00

string.cpp

util: Catch translation string errors at compile time

2024-07-10 09:40:47 +02:00

strprintf.cpp

refactor: Introduce struct to hold a runtime format string

2025-01-15 12:16:08 +01:00

system.cpp

multiprocess: Add -ipcbind option to bitcoin-node

2024-09-06 09:08:10 -04:00

timeoffsets.cpp

refactor: remove warnings globals

2024-06-13 11:20:49 +01:00

torcontrol.cpp

…

transaction.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

tx_in.cpp

Remove unused version.h include

2023-11-30 11:28:19 +01:00

tx_out.cpp

Remove unused version.h include

2023-11-30 11:28:19 +01:00

tx_pool.cpp

Merge bitcoin/bitcoin#31486: fuzz: Abort when using global PRNG without re-seed

2024-12-17 12:55:38 -05:00

txdownloadman.cpp

[fuzz] TxOrphanage::SanityCheck accounting

2025-02-07 13:55:57 -05:00

txorphan.cpp

fuzz: add basic TxOrphanage::EraseForBlock cov

2025-02-20 14:00:21 -05:00

txrequest.cpp

[fuzz] GetCandidatePeers

2025-01-29 18:05:16 -05:00

util.cpp

util: Implement ParseISO8601DateTime based on C++20

2024-12-02 08:21:32 +01:00

util.h

refactor: Reserve vectors in fuzz tests

2024-11-25 20:09:44 +01:00

utxo_snapshot.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

utxo_total_supply.cpp

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

validation_load_mempool.cpp

fuzz: Add missing SeedRandomStateForTest(SeedRand::ZEROS)

2024-12-13 14:22:25 +01:00

vecdeque.cpp

random: convert XoRoShiRo128PlusPlus into full RNG

2024-07-01 10:26:46 -04:00

versionbits.cpp

…