highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
23e15d40b96a23112fba24cece5fe513ae1a2877
bitcoin/src/node
History
merge-script 23e15d40b9 Merge bitcoin/bitcoin#32631: refactor: Convert GenTxid to std::variant 
a60f863d3e scripted-diff: Replace GenTxidVariant with GenTxid (marcofleon)
c8ba199598 Remove old GenTxid class (marcofleon)
072a198ea4 Convert remaining instances of GenTxid to GenTxidVariant (marcofleon)
1b528391c7 Convert `txrequest` to GenTxidVariant (marcofleon)
bde4579b07 Convert `txdownloadman_impl` to GenTxidVariant (marcofleon)
c876a892ec Replace GenTxid with Txid/Wtxid overloads in `txmempool` (marcofleon)
de858ce2be move-only: make GetInfo a private CTxMemPool member (stickies-v)
eee473d9f3 Convert `CompareInvMempoolOrder` to GenTxidVariant (marcofleon)
243553d590 refactor: replace get_iter_from_wtxid with GetIter(const Wtxid&) (stickies-v)
fcf92fd640 refactor: make CTxMemPool::GetIter strongly typed (marcofleon)
11d28f21bb Implement GenTxid as a variant (marcofleon)

Pull request description:

  Part of the [type safety refactor](https://github.com/bitcoin/bitcoin/pull/32189).

  This PR changes the GenTxid class to a variant, which holds both Txids and Wtxids. This provides compile-time type safety and eliminates the manual type check (bool m_is_wtxid). Variables that can be either a Txid or a Wtxid are now using the new GenTxid variant, instead of uint256.

ACKs for top commit:
  w0xlt:
    ACK a60f863d3e
  dergoegge:
    Code review ACK a60f863d3e
  maflcko:
    review ACK a60f863d3e 🎽
  theStack:
    Code-review ACK a60f863d3e

Tree-SHA512: da9b73b7bdffee2eb9281a409205519ac330d3336094d17681896703fbca8099608782c9c85801e388e4d90af5af8abf1f34931f57bbbe6e9674d802d6066047
2025-07-11 13:47:19 -04:00
..
abort.cpp
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
abort.h
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
blockmanager_args.cpp
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
Merge bitcoin/bitcoin#29307: util: explicitly close all AutoFiles that have been written
2025-07-03 15:37:44 -07:00
blockstorage.h
Merge bitcoin/bitcoin#32638: blocks: force hash validations on disk read
2025-06-27 13:28:26 -07:00
caches.cpp
node: cap -dbcache to 1GiB on 32-bit architectures
2025-05-19 16:39:58 -04:00
caches.h
init: Use size_t consistently for cache sizes
2025-01-15 15:44:56 +01:00
chainstate.cpp
kernel: Move block tree db open to BlockManager constructor
2025-01-20 21:27:50 +01:00
chainstate.h
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
chainstatemanager_args.cpp
Remove checkpoints
2025-03-13 11:13:13 +00:00
chainstatemanager_args.h
refactor: Clamp worker threads in ChainstateManager constructor
2024-11-18 11:13:20 +01:00
coin.cpp
refactor: Rely on returned value of GetCoin instead of parameter
2024-09-18 20:03:47 +02:00
coin.h
…
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
…
connection_types.cpp
net: expose transport types/session IDs of connections in RPC and logs
2023-10-02 18:11:11 -04:00
connection_types.h
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
context.cpp
Introduce Mining interface
2024-06-18 18:47:51 +02:00
context.h
refactor: Split up NodeContext shutdown_signal and shutdown_request
2024-10-01 09:10:54 +02:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
…
eviction.cpp
…
eviction.h
…
interface_ui.cpp
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
interface_ui.h
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
interfaces.cpp
Merge bitcoin/bitcoin#32631: refactor: Convert GenTxid to std::variant
2025-07-11 13:47:19 -04:00
kernel_notifications.cpp
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
kernel_notifications.h
refactor: Pass verification_progress into block tip notifications
2025-05-24 13:49:32 +02:00
mempool_args.cpp
init: cap -maxmempool to 500 MB on 32-bit systems
2025-05-19 16:39:58 -04:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
…
mempool_persist.cpp
Merge bitcoin/bitcoin#32631: refactor: Convert GenTxid to std::variant
2025-07-11 13:47:19 -04:00
mempool_persist.h
mempool: move LoadMempool/DumpMempool to node
2024-06-26 22:47:09 +00:00
miner.cpp
validation: refactor TestBlockValidity
2025-06-14 14:32:45 +02:00
miner.h
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
mini_miner.cpp
Replace GenTxid with Txid/Wtxid overloads in txmempool
2025-07-08 19:31:02 +01:00
mini_miner.h
refactor: Sort includes of touched source files
2025-06-03 19:56:55 +02:00
minisketchwrapper.cpp
…
minisketchwrapper.h
…
peerman_args.cpp
doc: add & amend copyright headers
2025-05-20 09:43:21 +01:00
peerman_args.h
doc: add & amend copyright headers
2025-05-20 09:43:21 +01:00
protocol_version.h
Rename version.h to node/protocol_version.h
2023-11-30 11:28:31 +01:00
psbt.cpp
psbt: Check sighash types in SignPSBTInput and take sighash as optional
2025-05-14 14:00:43 -07:00
psbt.h
…
README.md
…
timeoffsets.cpp
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00
timeoffsets.h
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00
transaction.cpp
Convert CompareInvMempoolOrder to GenTxidVariant
2025-07-08 16:03:05 +01:00
transaction.h
util: move fees.h and error.h to common/messages.h
2024-05-16 10:16:08 -05:00
txdownloadman_impl.cpp
scripted-diff: Replace GenTxidVariant with GenTxid
2025-07-08 20:00:51 +01:00
txdownloadman_impl.h
scripted-diff: Replace GenTxidVariant with GenTxid
2025-07-08 20:00:51 +01:00
txdownloadman.h
scripted-diff: Replace GenTxidVariant with GenTxid
2025-07-08 20:00:51 +01:00
txreconciliation.cpp
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
txreconciliation.h
[net processing] Move -txreconciliation to PeerManager::Options
2023-07-24 18:35:28 +02:00
types.h
Add checkBlock to Mining interface
2025-06-14 14:32:45 +02:00
utxo_snapshot.cpp
streams: remove unused code
2024-09-19 07:33:02 -04:00
utxo_snapshot.h
assumeutxo: Drop block height from metadata
2024-08-08 23:55:06 +02:00
warnings.cpp
scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h
2024-10-10 12:22:12 +02:00
warnings.h
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.

Reference in New Issue View Git Blame Copy Permalink