highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-22 01:40:48 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
fanquake 1326092e6c
Merge #17156: psbt: check that various indexes and amounts are within bounds 
deaa6dd144f5650b385658a0c4f9a014aff8dde2 psbt: check output index is within bounds before accessing (Andrew Chow)
f1ef7f0aa46338f4cd8de79696027a1bf868f359 Don't calculate tx fees for PSBTs with invalid money values (Andrew Chow)

Pull request description:

  Fixes #17149

  Two classes of issues were found by the psbt fuzzer: values out of range and causing overflows, and prevout indexes being out of range. This PR fixes both.

  When accessing a specific output using the index given in the tx, check that it is actually a possible output before trying to access the output.

  When summing and checking amounts for `decodepsbt` and `analyzepsbt`, make sure that the values are actually valid money values.. Otherwise, stop summing and don't show the fee. For `analyzepsbt`, return that the next role is the Creator since the Creator needs to remake the transaction to be valid.

ACKs for top commit:
  practicalswift:
    ACK deaa6dd144f5650b385658a0c4f9a014aff8dde2 -- only change since last ACK was the addition of tests
  gwillen:
    tested ACK deaa6dd, would also like to see this merged!

Tree-SHA512: 06c36720bbb5a7ab1c29f7d15878bf9f0d3e5760c06bff479d412e1bf07bb3e0e9ab6cca820a4bfedaab71bfd7af813807e87cbcdf0af25cc3f66a53a06dbcfd
2020-01-29 19:39:50 +08:00
..
coin.cpp
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coin.h
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coinstats.cpp
Merge #17382: rpc: Remove unused boost::this_thread::interruption_point
2019-11-06 00:04:38 +01:00
coinstats.h
coinstats: add coins_count
2019-11-05 10:54:00 -05:00
context.cpp
scripted-diff: Remove g_connman, g_banman globals
2019-10-28 10:30:51 -04:00
context.h
node: Add reference to mempool in NodeContext
2019-11-15 13:40:00 -05:00
psbt.cpp
Merge #17156: psbt: check that various indexes and amounts are within bounds
2020-01-29 19:39:50 +08:00
psbt.h
Have a PSBTAnalysis state that indicates invalid PSBT
2019-11-19 14:54:08 -05:00
README.md
[docs] Document src subdirectories and different libraries
2019-04-09 17:53:08 -04:00
transaction.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
transaction.h
Fix doxygen errors
2020-01-16 18:25:11 -08:00
utxo_snapshot.h
add unused SnapshotMetadata class
2019-10-29 13:55:10 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

The src/node/ directory is a new directory introduced in #14978 and at the moment is sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.