mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-16 18:39:59 +01:00

Files

MarcoFalke 85883a9f8e Merge #16443 : refactor: have CCoins* data managed under CChainState

582d2cd747 Cover UTXO set access with lock annotations (James O'Beirne)
5693530685 refactor: have CCoins* data managed under CChainState (James O'Beirne)
fae6ab6aed refactor: pcoinsTip -> CChainState::CoinsTip() (James O'Beirne)

Pull request description:

  This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11):

  Parent PR: #15606
  Issue: #15605
  Specification: https://github.com/jamesob/assumeutxo-docs/tree/2019-04-proposal/proposal

  ---

  This change encapsulates UTXO set data within CChainState instances, removing global data `pcoinsTip` and `pcoinsviewdb`. This is necessary if we want to maintain multiple chainstates with their own rendering of the UTXO set.

  We introduce a class CoinsViews which consolidates the construction of a CCoins* hierarchy.

  This commit could be broken into smaller pieces, but it would require more ephemeral diffs to, e.g., temporarily change CCoinsViewDB's constructor invocations.

ACKs for top commit:
  Sjors:
    reACK 582d2cd747
  MarcoFalke:
    ACK 582d2cd747

Tree-SHA512: ec9d904fe5dca8cd2dc4b7916daa5d8bab30856dd4645987300f905e0a19f9919fce4f9d1ff03eda982943ca73e6e9a746be6cf53b46510de36e8c81a1eafba1

2019-08-15 12:47:15 -04:00

coin.cpp

refactor: pcoinsTip -> CChainState::CoinsTip()

2019-08-06 13:13:06 -04:00

coin.h

Remove use of CCoinsViewMemPool::GetCoin in wallet code

2019-03-05 10:20:00 -04:00

psbt.cpp

[build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp

2019-04-09 17:53:08 -04:00

psbt.h

[build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp

2019-04-09 17:53:08 -04:00

README.md

[docs] Document src subdirectories and different libraries

2019-04-09 17:53:08 -04:00

transaction.cpp

Merge #16443 : refactor: have CCoins* data managed under CChainState

2019-08-15 12:47:15 -04:00

transaction.h

Tidy up BroadcastTransaction()

2019-08-01 13:43:29 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

The src/node/ directory is a new directory introduced in #14978 and at the moment is sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.