b847626562test: refresh MiniWallet after node restart (Sjors Provoost)f4e643cb15test: merge mining options in package feerate check (Sjors Provoost)280ce6a0aeminer: ensure block_max_weight is flattened before limit checks (Sjors Provoost)65bd3164fbmining: clarify test_block_validity comment (Sjors Provoost)978e7216e6test: use shared default_ipc_timeout (Sjors Provoost) Pull request description: This implement the suggested followups from #33966. Each commit links to the original comment. The most important change is the extra asserts added in `miner: ensure block_max_weight is flattened before limit checks`. ACKs for top commit: achow101: ACKb847626562enirox001: tACKb847626562sedited: ACKb847626562w0xlt: ACKb847626562Tree-SHA512: 47678eaed604228269bd892ccf8ff58804745bbc7675b4a93528da9a9292a2eb1e0562cdb8341edac77178563420885b48282bb9e5c2b997b28f2fc64ceeff3d
src/node/
The src/node/ directory contains code that needs to access node state
(state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar
classes).
Code in src/node/ is meant to be segregated from code in
src/wallet/ and src/qt/, to ensure wallet and GUI
code changes don't interfere with node operation, to allow wallet and GUI code
to run in separate processes, and to perhaps eventually allow wallet and GUI
code to be maintained in separate source repositories.
As a rule of thumb, code in one of the src/node/,
src/wallet/, or src/qt/ directories should avoid
calling code in the other directories directly, and only invoke it indirectly
through the more limited src/interfaces/ classes.
This directory is at the moment
sparsely populated. Eventually more substantial files like
src/validation.cpp and
src/txmempool.cpp might be moved there.