mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00

Files

MarcoFalke a063647413 Merge bitcoin/bitcoin#23280 : init: Coalesce Chainstate loading sequence between {,non-}unittest codepaths

7f15eff2dd style-only: Remove redundant scope in *Chainstate (Carl Dong)
89bec827fd Collapse the 2 cs_main locks in LoadChainstate (Carl Dong)
3b1584b794 Remove all #include // for * comments (Carl Dong)
9a5a5a3d08 test/setup: Use LoadChainstate (Carl Dong)
c541da0d62 node/chainstate: Add options for in-memory DBs (Carl Dong)
ceb9790341 node/caches: Remove intermediate variables (Carl Dong)
ac4bf138b8 node/caches: Extract cache calculation logic (Carl Dong)
15f2e33bb3 validation: VerifyDB only needs Consensus::Params (Carl Dong)
4da9c076d1 node/chainstate: Decouple from ShutdownRequested (Carl Dong)
05441c2dc5 node/chainstate: Decouple from GetTime (Carl Dong)
2414ebc18b init: Delay RPC block notif until warmup finished (Carl Dong)
8d466a8504 Move -checkblocks LogPrintf to AppInitMain (Carl Dong)
aad8d59789 node/chainstate: Reduce coupling of LogPrintf (Carl Dong)
b345979a2b node/chainstate: Decouple from concept of uiInterface (Carl Dong)
ca7c0b934d Split off VerifyLoadedChainstate (Carl Dong)
adf4912d77 node/chainstate: Remove do/while loop (Carl Dong)
975235ca0a Move init logistics message for BAD_GENESIS_BLOCK to init.cpp (Carl Dong)
8715658983 Move mempool nullptr Assert out of LoadChainstate (Carl Dong)
9162a4f93e node/chainstate: Decouple from concept of NodeContext (Carl Dong)
c7a5c46e6f node/chainstate: Decouple from ArgsManager (Carl Dong)
ae9121f958 node/chainstate: Decouple from stringy errors (Carl Dong)
cbac28b72f node/chainstate: Decouple from GetTimeMillis (Carl Dong)
cb64af9635 node: Extract chainstate loading sequence (Carl Dong)

Pull request description:

  This PR:
  1. Coalesce the Chainstate loading sequence between `AppInitMain` and `*TestingSetup` (which makes it more tested)
  2. Makes the Chainstate loading sequence reusable in preparation for future work extracting out our consensus engine.

  Code-wise, this PR:
  1. Extracts `AppInitMain`'s Chainstate loading sequence into a `::LoadChainstateSequence` function
  2. Makes this `::LoadChainstateSequence` function reusable by
      1. Decoupling it from various concepts (`ArgsManager`, `uiInterface`, etc)
      2. Making it report errors using an `enum` rather than by setting a `bilingual_str`
  3. Makes `*TestingSetup` use this new `::LoadChainstateSequence`

  Reviewers: Aside from commentary, I've also included `git diff` flags of interest in the commit messages which I hope will aid review!

ACKs for top commit:
  ryanofsky:
    Code review ACK 7f15eff2dd. Thanks for updates!
  MarcoFalke:
    review ACK 7f15eff2dd 💳

Tree-SHA512: fb9a6cbd1c511a52b477c62a5e68e53a8be5dec2fff0e44a279966afb91efbab44bf1fe7c6b1519f8464ecc25f42dd4bae8e1efbf55ee91fc90fa0b92e3a83e2

2021-12-10 17:17:43 +01:00

blockstorage.cpp

Merge bitcoin/bitcoin#22937 : refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method

2021-10-15 10:01:56 +02:00

blockstorage.h

add missing atomic include

2021-06-22 11:06:30 +02:00

caches.cpp

node/caches: Remove intermediate variables

2021-12-07 14:48:49 -05:00

caches.h

Remove all #include // for * comments

2021-12-07 14:48:49 -05:00

chainstate.cpp

style-only: Remove redundant scope in *Chainstate

2021-12-07 14:48:49 -05:00

chainstate.h

Remove all #include // for * comments

2021-12-07 14:48:49 -05:00

coin.cpp

scripted-diff: tree-wide: Remove all review-only assertions

2021-06-10 15:05:24 -04:00

coin.h

node: Use mempool from node context instead of global

2019-12-05 14:22:05 -05:00

coinstats.cpp

scripted-diff: tree-wide: Remove all review-only assertions

2021-06-10 15:05:24 -04:00

coinstats.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

context.cpp

validation: Farewell, global Chainstate!

2021-06-10 15:05:25 -04:00

context.h

scripted-diff: Rename CAddrMan to AddrMan

2021-09-28 22:21:10 -04:00

interfaces.cpp

wallet: Replace confusing getAdjustedTime() with GetTime()

2021-12-01 16:26:11 +01:00

miner.cpp

mining, refactor: add m_mempool.cs thread safety lock assertions

2021-12-07 15:01:43 +01:00

miner.h

miner: Remove uncompiled MTP code

2021-12-01 09:32:03 +01:00

minisketchwrapper.cpp

scripted-diff: Move minisketchwrapper to src/node

2021-11-12 10:56:08 +01:00

minisketchwrapper.h

Sort file list after rename

2021-11-12 10:56:27 +01:00

psbt.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

psbt.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

README.md

doc: Remove irrelevant link to GitHub

2021-04-06 09:34:21 +02:00

transaction.cpp

[refactor] Don't call AcceptToMemoryPool() from outside validation.cpp

2021-11-03 14:34:41 +00:00

transaction.h

refactor: move GetTransaction(...) to node/transaction.cpp

2021-07-22 15:53:17 +02:00

ui_interface.cpp

multiprocess: Delay wallet client construction

2021-09-16 14:17:01 -04:00

ui_interface.h

multiprocess: Delay wallet client construction

2021-09-16 14:17:01 -04:00

utxo_snapshot.h

validation: remove nchaintx from assumeutxo metadata

2021-04-26 13:22:37 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.