mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-13 14:13:52 +02:00
Since #32420, createNewBlock has thrown `bad-cb-length` errors when called at low block heights because `OP_0` padding stopped being added to coinbase transactions. (#32420 did add an `include_dummy_extranonce` option which could bypass this, but it was not exposed to IPC clients.) Fix the problem by padding coinbase transactions with `OP_0` when necessary to produce valid blocks. Additionally this commit stops adding `OP_0` padding to the template `script_sig_prefix` field when `include_dummy_extranonce` is true. This is safe because non-IPC clients don't use this field, and IPC clients could never set the option to true, and are expected to add their own nonces in any case. This also improves documentation about the `script_sig_prefix` field and `getCoinbaseTx` method.
177 lines
6.6 KiB
C++
177 lines
6.6 KiB
C++
// Copyright (c) 2024-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_INTERFACES_MINING_H
|
|
#define BITCOIN_INTERFACES_MINING_H
|
|
|
|
#include <consensus/amount.h>
|
|
#include <interfaces/types.h>
|
|
#include <node/types.h>
|
|
#include <primitives/block.h>
|
|
#include <primitives/transaction.h>
|
|
#include <uint256.h>
|
|
#include <util/time.h>
|
|
|
|
#include <cstdint>
|
|
#include <memory>
|
|
#include <optional>
|
|
#include <vector>
|
|
|
|
namespace node {
|
|
struct NodeContext;
|
|
} // namespace node
|
|
|
|
class BlockValidationState;
|
|
class CScript;
|
|
|
|
namespace interfaces {
|
|
|
|
//! Block template interface
|
|
class BlockTemplate
|
|
{
|
|
public:
|
|
virtual ~BlockTemplate() = default;
|
|
|
|
virtual CBlockHeader getBlockHeader() = 0;
|
|
// Block contains a dummy coinbase transaction that should not be used and
|
|
// it may not match a transaction constructed from getCoinbaseTx().
|
|
virtual CBlock getBlock() = 0;
|
|
|
|
// Fees per transaction, not including coinbase transaction.
|
|
virtual std::vector<CAmount> getTxFees() = 0;
|
|
// Sigop cost per transaction, not including coinbase transaction.
|
|
virtual std::vector<int64_t> getTxSigops() = 0;
|
|
|
|
/** Return fields needed to construct a coinbase transaction */
|
|
virtual node::CoinbaseTx getCoinbaseTx() = 0;
|
|
|
|
/**
|
|
* Compute merkle path to the coinbase transaction
|
|
*
|
|
* @return merkle path ordered from the deepest
|
|
*/
|
|
virtual std::vector<uint256> getCoinbaseMerklePath() = 0;
|
|
|
|
/**
|
|
* Construct and broadcast the block. Modifies the template in place,
|
|
* updating the fields listed below as well as the merkle root.
|
|
*
|
|
* @param[in] version version block header field
|
|
* @param[in] timestamp time block header field (unix timestamp)
|
|
* @param[in] nonce nonce block header field
|
|
* @param[in] coinbase complete coinbase transaction (including witness)
|
|
*
|
|
* @note unlike the submitblock RPC, this method does NOT add the
|
|
* coinbase witness automatically.
|
|
*
|
|
* @note for heights <= 16, the BIP34 height push in getCoinbaseTx().script_sig_prefix
|
|
* is only one byte long, so the coinbase scriptSig needs at least
|
|
* one additional byte of data to avoid bad-cb-length.
|
|
*
|
|
* @returns if the block was processed, does not necessarily indicate validity.
|
|
*
|
|
* @note Returns true if the block is already known, which can happen if
|
|
* the solved block is constructed and broadcast by multiple nodes
|
|
* (e.g. both the miner who constructed the template and the pool).
|
|
*/
|
|
virtual bool submitSolution(uint32_t version, uint32_t timestamp, uint32_t nonce, CTransactionRef coinbase) = 0;
|
|
|
|
/**
|
|
* Waits for fees in the next block to rise, a new tip or the timeout.
|
|
*
|
|
* @param[in] options Control the timeout (default forever) and by how much total fees
|
|
* for the next block should rise (default infinite).
|
|
*
|
|
* @returns a new BlockTemplate or nothing if the timeout occurs.
|
|
*
|
|
* On testnet this will additionally return a template with difficulty 1 if
|
|
* the tip is more than 20 minutes old.
|
|
*/
|
|
virtual std::unique_ptr<BlockTemplate> waitNext(node::BlockWaitOptions options = {}) = 0;
|
|
|
|
/**
|
|
* Interrupts the current wait for the next block template.
|
|
*/
|
|
virtual void interruptWait() = 0;
|
|
};
|
|
|
|
//! Interface giving clients (RPC, Stratum v2 Template Provider in the future)
|
|
//! ability to create block templates.
|
|
class Mining
|
|
{
|
|
public:
|
|
virtual ~Mining() = default;
|
|
|
|
//! If this chain is exclusively used for testing
|
|
virtual bool isTestChain() = 0;
|
|
|
|
//! Returns whether IBD is still in progress.
|
|
virtual bool isInitialBlockDownload() = 0;
|
|
|
|
//! Returns the hash and height for the tip of this chain
|
|
virtual std::optional<BlockRef> getTip() = 0;
|
|
|
|
/**
|
|
* Waits for the connected tip to change. During node initialization, this will
|
|
* wait until the tip is connected (regardless of `timeout`).
|
|
*
|
|
* @param[in] current_tip block hash of the current chain tip. Function waits
|
|
* for the chain tip to differ from this.
|
|
* @param[in] timeout how long to wait for a new tip (default is forever)
|
|
*
|
|
* @retval BlockRef hash and height of the current chain tip after this call.
|
|
* @retval std::nullopt if the node is shut down or interrupt() is called.
|
|
*/
|
|
virtual std::optional<BlockRef> waitTipChanged(uint256 current_tip, MillisecondsDouble timeout = MillisecondsDouble::max()) = 0;
|
|
|
|
/**
|
|
* Construct a new block template.
|
|
*
|
|
* @param[in] options options for creating the block
|
|
* @param[in] cooldown wait for tip to be connected and IBD to complete.
|
|
* If the best header is ahead of the tip, wait for the
|
|
* tip to catch up. It's recommended to disable this on
|
|
* regtest and signets with only one miner, as these
|
|
* could stall.
|
|
* @retval BlockTemplate a block template.
|
|
* @retval std::nullptr if the node is shut down or interrupt() is called.
|
|
*/
|
|
virtual std::unique_ptr<BlockTemplate> createNewBlock(const node::BlockCreateOptions& options = {}, bool cooldown = true) = 0;
|
|
|
|
/**
|
|
* Interrupts createNewBlock and waitTipChanged.
|
|
*/
|
|
virtual void interrupt() = 0;
|
|
|
|
/**
|
|
* Checks if a given block is valid.
|
|
*
|
|
* @param[in] block the block to check
|
|
* @param[in] options verification options: the proof-of-work check can be
|
|
* skipped in order to verify a template generated by
|
|
* external software.
|
|
* @param[out] reason failure reason (BIP22)
|
|
* @param[out] debug more detailed rejection reason
|
|
* @returns whether the block is valid
|
|
*
|
|
* For signets the challenge verification is skipped when check_pow is false.
|
|
*/
|
|
virtual bool checkBlock(const CBlock& block, const node::BlockCheckOptions& options, std::string& reason, std::string& debug) = 0;
|
|
|
|
//! Get internal node context. Useful for RPC and testing,
|
|
//! but not accessible across processes.
|
|
virtual node::NodeContext* context() { return nullptr; }
|
|
};
|
|
|
|
//! Return implementation of Mining interface.
|
|
//!
|
|
//! @param[in] wait_loaded waits for chainstate data to be loaded before
|
|
//! returning. Used to prevent external clients from
|
|
//! being able to crash the node during startup.
|
|
std::unique_ptr<Mining> MakeMining(node::NodeContext& node, bool wait_loaded=true);
|
|
|
|
} // namespace interfaces
|
|
|
|
#endif // BITCOIN_INTERFACES_MINING_H
|